From: Rohan McLure <rmclure@linux.ibm.com>
To: linuxppc-dev@lists.ozlabs.org
Cc: Rohan McLure <rmclure@linux.ibm.com>
Subject: [PATCH v3 06/18] powerpc: Remove direct call to personality syscall handler
Date: Fri, 19 Aug 2022 13:37:54 +1000 [thread overview]
Message-ID: <20220819033806.162054-7-rmclure@linux.ibm.com> (raw)
In-Reply-To: <20220819033806.162054-1-rmclure@linux.ibm.com>
Syscall handlers should not be invoked internally by their symbol names,
as these symbols defined by the architecture-defined SYSCALL_DEFINE
macro. Fortunately, in the case of ppc64_personality, its call to
sys_personality can be replaced with an invocation to the
equivalent ksys_personality inline helper in <linux/syscalls.h>.
Signed-off-by: Rohan McLure <rmclure@linux.ibm.com>
---
V1 -> V2: Use inline helper to deduplicate bodies in compat/regular
implementations.
---
arch/powerpc/kernel/syscalls.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/kernel/syscalls.c b/arch/powerpc/kernel/syscalls.c
index e89a2176b2a3..e083935c5bf2 100644
--- a/arch/powerpc/kernel/syscalls.c
+++ b/arch/powerpc/kernel/syscalls.c
@@ -71,7 +71,7 @@ static inline long do_ppc64_personality(unsigned long personality)
if (personality(current->personality) == PER_LINUX32
&& personality(personality) == PER_LINUX)
personality = (personality & ~PER_MASK) | PER_LINUX32;
- ret = sys_personality(personality);
+ ret = ksys_personality(personality);
if (personality(ret) == PER_LINUX32)
ret = (ret & ~PER_MASK) | PER_LINUX;
return ret;
--
2.34.1
next prev parent reply other threads:[~2022-08-19 3:40 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-19 3:37 [PATCH v3 00/18] powerpc: Syscall wrapper and register clearing Rohan McLure
2022-08-19 3:37 ` [PATCH v3 01/18] powerpc: Remove asmlinkage from syscall handler definitions Rohan McLure
2022-08-19 3:37 ` [PATCH v3 02/18] powerpc: Use generic fallocate compatibility syscall Rohan McLure
2022-08-19 3:37 ` [PATCH v3 03/18] powerpc/32: Remove powerpc select specialisation Rohan McLure
2022-08-19 3:37 ` [PATCH v3 04/18] powerpc: Provide do_ppc64_personality helper Rohan McLure
2022-08-19 3:37 ` [PATCH v3 05/18] powerpc: Adopt SYSCALL_DEFINE for arch-specific syscall handlers Rohan McLure
2022-08-19 6:41 ` Christophe Leroy
2022-08-19 3:37 ` Rohan McLure [this message]
2022-08-19 3:37 ` [PATCH v3 07/18] powerpc: Remove direct call to mmap2 " Rohan McLure
2022-08-19 6:41 ` Christophe Leroy
2022-08-19 3:37 ` [PATCH v3 08/18] powerpc: Include all arch-specific syscall prototypes Rohan McLure
2022-08-19 3:37 ` [PATCH v3 09/18] powerpc: Enable compile-time check for syscall handlers Rohan McLure
2022-08-19 3:37 ` [PATCH v3 10/18] powerpc: Use common syscall handler type Rohan McLure
2022-08-19 3:37 ` [PATCH v3 11/18] powerpc: Add ZEROIZE_GPRS macros for register clears Rohan McLure
2022-08-19 6:45 ` Christophe Leroy
2022-08-19 3:38 ` [PATCH v3 12/18] Revert "powerpc/syscall: Save r3 in regs->orig_r3" Rohan McLure
2022-08-19 3:38 ` [PATCH v3 13/18] powerpc: Provide syscall wrapper Rohan McLure
2022-08-19 3:38 ` [PATCH v3 14/18] powerpc/64s: Clear/restore caller gprs in syscall interrupt/return Rohan McLure
2022-08-19 6:52 ` Christophe Leroy
2022-08-22 3:47 ` Rohan McLure
2022-08-19 3:38 ` [PATCH v3 15/18] powerpc/64s: Use {ZEROIZE,SAVE,REST}_GPRS macros in sc, scv 0 handlers Rohan McLure
2022-08-19 3:38 ` [PATCH v3 16/18] powerpc/32: Clarify interrupt restores with REST_GPR macro in entry_32.S Rohan McLure
2022-08-19 6:29 ` Christophe Leroy
2022-08-19 3:38 ` [PATCH v3 17/18] powerpc/64s: Fix comment on interrupt handler prologue Rohan McLure
2022-08-19 3:38 ` [PATCH v3 18/18] powerpc/64s: Clear gprs on interrupt routine entry Rohan McLure
2022-08-19 7:41 ` Christophe Leroy
2022-08-24 1:24 ` Rohan McLure
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220819033806.162054-7-rmclure@linux.ibm.com \
--to=rmclure@linux.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).