From: Rohan McLure <rmclure@linux.ibm.com>
To: linuxppc-dev@lists.ozlabs.org
Cc: Rohan McLure <rmclure@linux.ibm.com>
Subject: [PATCH v3 07/18] powerpc: Remove direct call to mmap2 syscall handlers
Date: Fri, 19 Aug 2022 13:37:55 +1000 [thread overview]
Message-ID: <20220819033806.162054-8-rmclure@linux.ibm.com> (raw)
In-Reply-To: <20220819033806.162054-1-rmclure@linux.ibm.com>
Syscall handlers should not be invoked internally by their symbol names,
as these symbols defined by the architecture-defined SYSCALL_DEFINE
macro. Move the compatibility syscall definition for mmap2 to
syscalls.c, so that all mmap implementations can share an inline helper
function, as is done with the personality handlers.
Signed-off-by: Rohan McLure <rmclure@linux.ibm.com>
---
V1 -> V2: Move mmap2 compat implementation to asm/kernel/syscalls.c.
---
arch/powerpc/kernel/sys_ppc32.c | 10 ----------
arch/powerpc/kernel/syscalls.c | 11 +++++++++++
2 files changed, 11 insertions(+), 10 deletions(-)
diff --git a/arch/powerpc/kernel/sys_ppc32.c b/arch/powerpc/kernel/sys_ppc32.c
index 60cb5b4413b0..dd9039671227 100644
--- a/arch/powerpc/kernel/sys_ppc32.c
+++ b/arch/powerpc/kernel/sys_ppc32.c
@@ -25,7 +25,6 @@
#include <linux/poll.h>
#include <linux/personality.h>
#include <linux/stat.h>
-#include <linux/mman.h>
#include <linux/in.h>
#include <linux/syscalls.h>
#include <linux/unistd.h>
@@ -48,15 +47,6 @@
#include <asm/syscalls.h>
#include <asm/switch_to.h>
-COMPAT_SYSCALL_DEFINE6(mmap2,
- unsigned long, addr, size_t, len,
- unsigned long, prot, unsigned long, flags,
- unsigned long, fd, unsigned long, pgoff)
-{
- /* This should remain 12 even if PAGE_SIZE changes */
- return sys_mmap(addr, len, prot, flags, fd, pgoff << 12);
-}
-
/*
* long long munging:
* The 32 bit ABI passes long longs in an odd even register pair.
diff --git a/arch/powerpc/kernel/syscalls.c b/arch/powerpc/kernel/syscalls.c
index e083935c5bf2..0afbcbd50433 100644
--- a/arch/powerpc/kernel/syscalls.c
+++ b/arch/powerpc/kernel/syscalls.c
@@ -56,6 +56,17 @@ SYSCALL_DEFINE6(mmap2, unsigned long, addr, size_t, len,
return do_mmap2(addr, len, prot, flags, fd, pgoff, PAGE_SHIFT-12);
}
+#ifdef CONFIG_COMPAT
+COMPAT_SYSCALL_DEFINE6(mmap2,
+ unsigned long, addr, size_t, len,
+ unsigned long, prot, unsigned long, flags,
+ unsigned long, fd, unsigned long, pgoff)
+{
+ /* This should remain 12 even if PAGE_SIZE changes */
+ return do_mmap2(addr, len, prot, flags, fd, pgoff << 12, PAGE_SHIFT-12);
+}
+#endif
+
SYSCALL_DEFINE6(mmap, unsigned long, addr, size_t, len,
unsigned long, prot, unsigned long, flags,
unsigned long, fd, off_t, offset)
--
2.34.1
next prev parent reply other threads:[~2022-08-19 3:50 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-19 3:37 [PATCH v3 00/18] powerpc: Syscall wrapper and register clearing Rohan McLure
2022-08-19 3:37 ` [PATCH v3 01/18] powerpc: Remove asmlinkage from syscall handler definitions Rohan McLure
2022-08-19 3:37 ` [PATCH v3 02/18] powerpc: Use generic fallocate compatibility syscall Rohan McLure
2022-08-19 3:37 ` [PATCH v3 03/18] powerpc/32: Remove powerpc select specialisation Rohan McLure
2022-08-19 3:37 ` [PATCH v3 04/18] powerpc: Provide do_ppc64_personality helper Rohan McLure
2022-08-19 3:37 ` [PATCH v3 05/18] powerpc: Adopt SYSCALL_DEFINE for arch-specific syscall handlers Rohan McLure
2022-08-19 6:41 ` Christophe Leroy
2022-08-19 3:37 ` [PATCH v3 06/18] powerpc: Remove direct call to personality syscall handler Rohan McLure
2022-08-19 3:37 ` Rohan McLure [this message]
2022-08-19 6:41 ` [PATCH v3 07/18] powerpc: Remove direct call to mmap2 syscall handlers Christophe Leroy
2022-08-19 3:37 ` [PATCH v3 08/18] powerpc: Include all arch-specific syscall prototypes Rohan McLure
2022-08-19 3:37 ` [PATCH v3 09/18] powerpc: Enable compile-time check for syscall handlers Rohan McLure
2022-08-19 3:37 ` [PATCH v3 10/18] powerpc: Use common syscall handler type Rohan McLure
2022-08-19 3:37 ` [PATCH v3 11/18] powerpc: Add ZEROIZE_GPRS macros for register clears Rohan McLure
2022-08-19 6:45 ` Christophe Leroy
2022-08-19 3:38 ` [PATCH v3 12/18] Revert "powerpc/syscall: Save r3 in regs->orig_r3" Rohan McLure
2022-08-19 3:38 ` [PATCH v3 13/18] powerpc: Provide syscall wrapper Rohan McLure
2022-08-19 3:38 ` [PATCH v3 14/18] powerpc/64s: Clear/restore caller gprs in syscall interrupt/return Rohan McLure
2022-08-19 6:52 ` Christophe Leroy
2022-08-22 3:47 ` Rohan McLure
2022-08-19 3:38 ` [PATCH v3 15/18] powerpc/64s: Use {ZEROIZE,SAVE,REST}_GPRS macros in sc, scv 0 handlers Rohan McLure
2022-08-19 3:38 ` [PATCH v3 16/18] powerpc/32: Clarify interrupt restores with REST_GPR macro in entry_32.S Rohan McLure
2022-08-19 6:29 ` Christophe Leroy
2022-08-19 3:38 ` [PATCH v3 17/18] powerpc/64s: Fix comment on interrupt handler prologue Rohan McLure
2022-08-19 3:38 ` [PATCH v3 18/18] powerpc/64s: Clear gprs on interrupt routine entry Rohan McLure
2022-08-19 7:41 ` Christophe Leroy
2022-08-24 1:24 ` Rohan McLure
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220819033806.162054-8-rmclure@linux.ibm.com \
--to=rmclure@linux.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).