From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BC5E1ECAAD4 for ; Mon, 29 Aug 2022 08:55:38 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4MGPRF15hQz3bk4 for ; Mon, 29 Aug 2022 18:55:37 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=CyMJlWd7; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=2604:1380:4641:c500::1; helo=dfw.source.kernel.org; envelope-from=pali@kernel.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=CyMJlWd7; dkim-atps=neutral Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4MGPQW3nZvz2xGK for ; Mon, 29 Aug 2022 18:54:59 +1000 (AEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E4A8360EB2; Mon, 29 Aug 2022 08:54:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 30CD8C433C1; Mon, 29 Aug 2022 08:54:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1661763294; bh=cpD20IECoAEsU5QWrTpmUWeRwStSRURBU0+JaQT7J7E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CyMJlWd73MEePoYJ/WtOSAwPovn50mfbBDP2m/BfY4rZ401xhXc+8J/nfG7ZeLzOy ZRL57h+IkrKMMKPzp4hoDWiEaFgXFfUXYnPKoF6yrNCunBKkdw7wTN3hjoHevTn765 byeu7aLXBA1k+PPgl1DYl1aJQjFkoAF2fqqVXLaVicqIVcKjL1DJatNBBXp6+/+HTB qOT6M33x0PVS2efbyDCyWPCd+VbB30nRHiCMqqEUb9Ub9G/sAaNWYeR+UtTz8VPXNh sYbXcEagfnm2+qbsgASS9ZI28oEseXeebL1QqBoUTPvtY2zG0rKTMDJpL6M7lTcQYA QzJGmHeNWxprg== Received: by pali.im (Postfix) id 4AF797DE; Mon, 29 Aug 2022 10:54:51 +0200 (CEST) Date: Mon, 29 Aug 2022 10:54:51 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Christophe Leroy Subject: Re: [PATCH v3] powerpc/boot: Don't always pass -mcpu=powerpc when building 32-bit uImage Message-ID: <20220829085451.upubyo5e7uop72lb@pali> References: <20220820105200.30425-1-pali@kernel.org> <20220828095659.4061-1-pali@kernel.org> <20220828174135.rcql4uiunqbnn5gh@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20180716 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-kernel@vger.kernel.org" , Paul Mackerras , Joel Stanley , "linuxppc-dev@lists.ozlabs.org" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Sunday 28 August 2022 17:43:53 Christophe Leroy wrote: > Le 28/08/2022 à 19:41, Pali Rohár a écrit : > > On Sunday 28 August 2022 17:39:25 Christophe Leroy wrote: > >> Le 28/08/2022 à 19:33, Christophe Leroy a écrit : > >>> > >>> > >>> Le 28/08/2022 à 11:56, Pali Rohár a écrit : > >>>> When CONFIG_TARGET_CPU is specified then pass its value to the compiler > >>>> -mcpu option. This fixes following build error when building kernel with > >>>> powerpc e500 SPE capable cross compilers: > >>>> > >>>>      BOOTAS  arch/powerpc/boot/crt0.o > >>>>    powerpc-linux-gnuspe-gcc: error: unrecognized argument in option > >>>> ‘-mcpu=powerpc’ > >>>>    powerpc-linux-gnuspe-gcc: note: valid arguments to ‘-mcpu=’ are: > >>>> 8540 8548 native > >>>>    make[1]: *** [arch/powerpc/boot/Makefile:231: > >>>> arch/powerpc/boot/crt0.o] Error 1 > >>> > >>> corenet64_smp_defconfig : > >>> > >>>   BOOTAS  arch/powerpc/boot/crt0.o > >>> powerpc64-linux-gcc: error: missing argument to '-mcpu=' > >>> make[1]: *** [arch/powerpc/boot/Makefile:237 : arch/powerpc/boot/crt0.o] > >>> Erreur 1 > >>> make: *** [arch/powerpc/Makefile:253 : uImage] Erreur 2 > >>> > >>> > >> > >> Seems like in fact, E5500_CPU and E6500_CPU are not taken into account > >> in CONFIG_TARGET_CPU, and get special treatment directly in > >> arch/powerpc/Makefile. > >> > >> This goes unnoticed because of CFLAGS-$(CONFIG_TARGET_CPU_BOOL) += > >> $(call cc-option,-mcpu=$(CONFIG_TARGET_CPU)) > >> > >> I think we need to fix that prior to your patch. > > > > It looks like that CONFIG_TARGET_CPU is broken. > > > > $ make ARCH=powerpc corenet64_smp_defconfig CROSS_COMPILE=powerpc64-linux-gnu- > > ... > > # configuration written to .config > > > > $ grep CONFIG_TARGET_CPU .config > > CONFIG_TARGET_CPU_BOOL=y > > > > CONFIG_TARGET_CPU_BOOL is set but CONFIG_TARGET_CPU not! > > Yes, because there is no default value for E5500_CPU and E6500_CPU. We > need to add one for each. I see... Will you prepare this fixup for your previous patch? And I think that following construct $(call cc-option,-mcpu=$(CONFIG_TARGET_CPU)) should be changed just to -mcpu=$(CONFIG_TARGET_CPU) Because if user specified that want build for specific target CPU, it should not be silently ignored.