From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5F5F5ECAAD1 for ; Thu, 1 Sep 2022 17:54:40 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4MJTFp6J8yz3fXB for ; Fri, 2 Sep 2022 03:54:38 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.crashing.org (client-ip=63.228.1.57; helo=gate.crashing.org; envelope-from=segher@kernel.crashing.org; receiver=) Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) by lists.ozlabs.org (Postfix) with ESMTP id 4MJTFL03zwz2xFx for ; Fri, 2 Sep 2022 03:54:13 +1000 (AEST) Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 281Hmx4r031531; Thu, 1 Sep 2022 12:48:59 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id 281Hmwrg031525; Thu, 1 Sep 2022 12:48:58 -0500 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Thu, 1 Sep 2022 12:48:58 -0500 From: Segher Boessenkool To: Christophe Leroy Subject: Re: [PATCH v2] powerpc: Fix irq_soft_mask_set() and irq_soft_mask_return() with sanitizer Message-ID: <20220901174858.GG25951@gate.crashing.org> References: <7c11b659-5b8e-256c-508e-39395041fccb@csgroup.eu> <20220831224522.GX25951@gate.crashing.org> <24253442-9878-c5ed-cbaa-05a5c4851a6e@csgroup.eu> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <24253442-9878-c5ed-cbaa-05a5c4851a6e@csgroup.eu> User-Agent: Mutt/1.4.2.3i X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-kernel@vger.kernel.org" , Nicholas Piggin , Zhouyi Zhou , "linuxppc-dev@lists.ozlabs.org" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, Sep 01, 2022 at 07:47:10AM +0000, Christophe Leroy wrote: > Le 01/09/2022 à 09:37, Gabriel Paubert a écrit : > > Agree, but there is one thing which escapes me: why is r3 listed in the > > outputs section (actually as a read write operand with the "+" > > constraint modifier) but is not used after the asm which is the last > > statement of function returning void? > > > > Do I miss something? > > As far as I remember, that's to tell GCC that r3 register is modified by > the callee. As it is an input, it couldn't be listed in the clobber list. Inputs can be clobbered just fine, in general. But here the operand is tied to a register variable, and that causes the error ("'asm' specifier for variable 'r3' conflicts with 'asm' clobber list"). Marking it in/out here is more appropriate anyway :-) Segher