linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Nicholas Piggin <npiggin@gmail.com>
To: linuxppc-dev@lists.ozlabs.org
Cc: Sachin Sant <sachinp@linux.ibm.com>, Nicholas Piggin <npiggin@gmail.com>
Subject: [PATCH v2 0/3] powerpc/64: interrupt soft-mask management fixes
Date: Tue,  6 Sep 2022 16:03:34 +1000	[thread overview]
Message-ID: <20220906060337.3302557-1-npiggin@gmail.com> (raw)

Since last posting I've added more debugging and done some test code
that tires to irritate this on hardware (e.g., put DEC into the
MUST_HARD_MASK category, set_dec(1) in the hash fault handler, run
with perf, etc), and also trigger interrupts at various points stepping
through in the simulator.

I haven't been able to break it. Sachin reported he couldn't reproduce
the previous lockups he saw so possibly that was a red herring.

I'd like to try again to close this if possible, it's probably one of
the last major known uglinesses in the soft masking code.

Thanks,
Nick

Nicholas Piggin (3):
  powerpc/64/interrupt: Fix return to masked context after hard-mask irq
    becomes pending
  powerpc/64s: Fix irq state management in runlatch functions
  powerpc/64s/interrupt: masked handler debug check for previous hard
    disable

 arch/powerpc/include/asm/runlatch.h  |  6 ++---
 arch/powerpc/kernel/exceptions-64s.S | 10 ++++++++
 arch/powerpc/kernel/interrupt.c      | 10 --------
 arch/powerpc/kernel/interrupt_64.S   | 34 +++++++++++++++++++++++++---
 4 files changed, 43 insertions(+), 17 deletions(-)

-- 
2.37.2


             reply	other threads:[~2022-09-06  6:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-06  6:03 Nicholas Piggin [this message]
2022-09-06  6:03 ` [PATCH v2 1/3] powerpc/64/interrupt: Fix return to masked context after hard-mask irq becomes pending Nicholas Piggin
2022-09-06  6:03 ` [PATCH v2 2/3] powerpc/64s: Fix irq state management in runlatch functions Nicholas Piggin
2022-09-06  6:03 ` [PATCH v2 3/3] powerpc/64s/interrupt: masked handler debug check for previous hard disable Nicholas Piggin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220906060337.3302557-1-npiggin@gmail.com \
    --to=npiggin@gmail.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=sachinp@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).