LinuxPPC-Dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: cgel.zte@gmail.com
To: benh@kernel.crashing.org
Cc: Zeal Robot <zealci@zte.com.cn>,
	linuxppc-dev@lists.ozlabs.org, Xu Panda <xu.panda@zte.com.cn>
Subject: [PATCH linux-next] macintosh/windfarm: fix comparing pointer to 0
Date: Sun, 18 Sep 2022 15:50:43 +0000	[thread overview]
Message-ID: <20220918155043.210309-1-xu.panda@zte.com.cn> (raw)

From: Xu Panda <xu.panda@zte.com.cn>

Comparing pointer whith NULL instead of comparing pointer to 0.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Xu Panda <xu.panda@zte.com.cn>
---
 drivers/macintosh/windfarm_pm121.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/macintosh/windfarm_pm121.c b/drivers/macintosh/windfarm_pm121.c
index 36312f163aac..82dcd35f439a 100644
--- a/drivers/macintosh/windfarm_pm121.c
+++ b/drivers/macintosh/windfarm_pm121.c
@@ -651,7 +651,7 @@ static void pm121_create_cpu_fans(void)

        /* First, locate the PID params in SMU SBD */
        hdr = smu_get_sdb_partition(SMU_SDB_CPUPIDDATA_ID, NULL);
-       if (hdr == 0) {
+       if (hdr == NULL) {
                printk(KERN_WARNING "pm121: CPU PID fan config not found.\n");
                goto fail;
        }
@@ -970,7 +970,7 @@ static int pm121_init_pm(void)
        const struct smu_sdbp_header *hdr;

        hdr = smu_get_sdb_partition(SMU_SDB_SENSORTREE_ID, NULL);
-       if (hdr != 0) {
+       if (hdr != NULL) {
                struct smu_sdbp_sensortree *st =
                        (struct smu_sdbp_sensortree *)&hdr[1];
                pm121_mach_model = st->model_id;
-- 
2.15.2


             reply	other threads:[~2022-09-18 15:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-18 15:50 cgel.zte [this message]
2022-09-18 17:45 ` [PATCH linux-next] macintosh/windfarm: fix comparing pointer to 0 Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220918155043.210309-1-xu.panda@zte.com.cn \
    --to=cgel.zte@gmail.com \
    --cc=benh@kernel.crashing.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=xu.panda@zte.com.cn \
    --cc=zealci@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox