From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 04033C433FE for ; Sun, 9 Oct 2022 12:06:07 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Mlgk61XtPz3dtV for ; Sun, 9 Oct 2022 23:06:06 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=HYhivCEF; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=2604:1380:4601:e00::1; helo=ams.source.kernel.org; envelope-from=pali@kernel.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=HYhivCEF; dkim-atps=neutral Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Mlgj53cPkz2y33 for ; Sun, 9 Oct 2022 23:05:13 +1100 (AEDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 59348B80B02; Sun, 9 Oct 2022 12:05:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F078BC433D6; Sun, 9 Oct 2022 12:05:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1665317109; bh=sa1sssn/6Unn/pQ50a8PSKlsizjsCiE1zUUQARnh83Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HYhivCEFFjHIN0oe9Zt1MRLwptLjNnmj2ZKeQJ7oWeW8YZy1ckr+NcdQrs+v6RA/W g5xaVgyQyaTSviqrZN2kGwSwmO1LLk0cDhOXe+14G/rl1/KL6mY2mwL8wq4QKwNrUA N3v0i6kSzZPSLozgVi1Kg1wZqQFO44TVtacLCUkYBa63AjnFHrxiblbUYS40Wc6GOf E4HQbW82GatKYWScuFUtDwiMA6W/UHZ4EYoN3MRpIF8oIiVVKbsYBoWErMar1DKIWe MpnNh4i/kufN4D/WtenE+nvAMzz6rtiUt3OvcA6VDpKzaOQYdLGmBX86yaWf1YaGbQ Zo0bAZBgL49iw== Received: by pali.im (Postfix) id 26F917C1; Sun, 9 Oct 2022 14:05:06 +0200 (CEST) Date: Sun, 9 Oct 2022 14:05:06 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Michael Ellerman , Nicholas Piggin , Christophe Leroy Subject: Re: [PATCH] powerpc: dts: turris1x.dts: Add channel labels for temperature sensor Message-ID: <20221009120506.itwa4n25nljn2tll@pali> References: <20220930123901.10251-1-pali@kernel.org> <20220930124618.kyaansrl7ls5kn3i@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220930124618.kyaansrl7ls5kn3i@pali> User-Agent: NeoMutt/20180716 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-hwmon@vger.kernel.org, Marek =?utf-8?B?QmVow7pu?= , Josef Schlehofer , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Friday 30 September 2022 14:46:18 Pali Rohár wrote: > + CC hwmon ML > > On Friday 30 September 2022 14:39:01 Pali Rohár wrote: > > Channel 0 of SA56004ED chip refers to internal SA56004ED chip sensor (chip > > itself is located on the board) and channel 1 of SA56004ED chip refers to > > external sensor which is connected to temperature diode of the P2020 CPU. > > > > Fixes: 54c15ec3b738 ("powerpc: dts: Add DTS file for CZ.NIC Turris 1.x routers") > > Signed-off-by: Pali Rohár > > --- > > With this change userspace 'sensors' applications prints labels: > > > > $ sensors > > sa56004-i2c-0-4c > > Adapter: MPC adapter (i2c@3000) > > board: +34.2°C (low = +0.0°C, high = +70.0°C) > > (crit = +85.0°C, hyst = +75.0°C) > > cpu: +58.9°C (low = +0.0°C, high = +70.0°C) > > (crit = +85.0°C, hyst = +75.0°C) > > > > And without this change it prints just generic tempX names: > > > > $ sensors > > sa56004-i2c-0-4c > > Adapter: MPC adapter (i2c@3000) > > temp1: +43.0°C (low = +0.0°C, high = +70.0°C) > > (crit = +85.0°C, hyst = +75.0°C) > > temp2: +63.4°C (low = +0.0°C, high = +70.0°C) > > (crit = +85.0°C, hyst = +75.0°C) > > --- > > arch/powerpc/boot/dts/turris1x.dts | 14 ++++++++++++++ > > 1 file changed, 14 insertions(+) > > > > diff --git a/arch/powerpc/boot/dts/turris1x.dts b/arch/powerpc/boot/dts/turris1x.dts > > index 4033c554b06a..5b5278c32e43 100644 > > --- a/arch/powerpc/boot/dts/turris1x.dts > > +++ b/arch/powerpc/boot/dts/turris1x.dts > > @@ -69,6 +69,20 @@ > > interrupt-parent = <&gpio>; > > interrupts = <12 IRQ_TYPE_LEVEL_LOW>, /* GPIO12 - ALERT pin */ > > <13 IRQ_TYPE_LEVEL_LOW>; /* GPIO13 - CRIT pin */ > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + /* Local temperature sensor (SA56004ED internal) */ > > + channel@0 { > > + reg = <0>; > > + label = "board"; > > + }; > > + > > + /* Remote temperature sensor (D+/D- connected to P2020 CPU Temperature Diode) */ > > + channel@1 { > > + reg = <1>; > > + label = "cpu"; > > + }; > > I'm not sure if you want UPPERCASE, lowercase, PascalCase, kebab-case > or snake_case format of labels. Or if you want also "temp" or > "temperature" keyword in the label. So please adjust label to the > preferred one, if proposed format is not the correct. Ok, if nobody complains then please take this patch as is. > > }; > > > > /* DDR3 SPD/EEPROM */ > > -- > > 2.20.1 > >