From: Bjorn Helgaas <helgaas@kernel.org>
To: Conor Dooley <conor.dooley@microchip.com>
Cc: "Krzysztof Wilczyński" <kw@linux.com>,
"Heiko Stuebner" <heiko@sntech.de>,
linux-pci@vger.kernel.org,
"Linus Walleij" <linus.walleij@linaro.org>,
llvm@lists.linux.dev, "Minghuan Lian" <minghuan.Lian@nxp.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Bharat Kumar Gogada" <bharat.kumar.gogada@amd.com>,
"Toan Le" <toan@os.amperecomputing.com>,
linux-riscv@lists.infradead.org,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"kernel test robot" <lkp@intel.com>,
"Joyce Ooi" <joyce.ooi@intel.com>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
bcm-kernel-feedback-list@broadcom.com,
"Mingkai Hu" <mingkai.hu@nxp.com>,
"Shawn Lin" <shawn.lin@rock-chips.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Ray Jui" <rjui@broadcom.com>,
linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
"Roy Zang" <roy.zang@nxp.com>, "Michal Simek" <monstr@monstr.eu>,
kbuild-all@lists.01.org, "Scott Branden" <sbranden@broadcom.com>,
"Daire McNamara" <daire.mcnamara@microchip.com>,
"Pali Rohár" <pali@kernel.org>,
linux-kernel@vger.kernel.org, "Tom Joseph" <tjoseph@cadence.com>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] PCI: Remove unnecessary of_irq.h includes
Date: Thu, 20 Oct 2022 08:45:47 -0500 [thread overview]
Message-ID: <20221020134547.GA94120@bhelgaas> (raw)
In-Reply-To: <Y1D2ubkwXqwx9LWD@wendy>
[+cc Pali, heads-up for trivial addition of <linux/irqdomain.h> to
pci-mvebu.c]
On Thu, Oct 20, 2022 at 08:20:25AM +0100, Conor Dooley wrote:
> On Thu, Oct 20, 2022 at 03:08:50PM +0800, kernel test robot wrote:
> > Hi Bjorn,
> >
> > I love your patch! Yet something to improve:
> >
> > >> drivers/pci/controller/pcie-microchip-host.c:473:31: error: incomplete definition of type 'struct irq_domain'
> > struct mc_pcie *port = domain->host_data;
>
> That's what I get for only visually inspecting the patch before Acking
> it.. Un-ack I suppose.
No problem!
I think what happened is the pcie-microchip-host.c uses
irq_domain_add_linear() so it needs <linux/irqdomain.h>, but it
currently gets it via <linux/of_irq.h>, which it doesn't otherwise
need.
I added a preparatory patch to include <linux/irqdomain.h> explicitly,
but I haven't been able to cross-build either riscv or ia64 to verify
this fix. I'll wait a few days and post an updated series for the
0-day bot to test.
Same situation for pcie-altera-msi.c.
pci-mvebu.c also relies on getting <linux/irqdomain.h> via
<linux/of_irq.h>, but it actually depends on of_irq.h, so I'll just
add an irqdomain.h include there.
Bjorn
next prev parent reply other threads:[~2022-10-20 13:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-19 19:54 [PATCH] PCI: Remove unnecessary of_irq.h includes Bjorn Helgaas
2022-10-19 20:11 ` Conor Dooley
2022-10-19 20:27 ` Roy Zang
2022-10-20 7:08 ` kernel test robot
2022-10-20 7:20 ` Conor Dooley
2022-10-20 13:45 ` Bjorn Helgaas [this message]
2022-10-20 13:52 ` Conor Dooley
2022-10-20 17:17 ` Pali Rohár
2022-10-20 8:09 ` kernel test robot
2022-10-20 13:41 ` Bjorn Helgaas
2022-10-20 15:04 ` Bjorn Helgaas
2022-10-21 0:49 ` [kbuild-all] " Chen, Rong A
2022-10-20 14:13 ` kernel test robot
2022-10-20 15:07 ` Bjorn Helgaas
2022-10-21 0:52 ` [kbuild-all] " Chen, Rong A
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221020134547.GA94120@bhelgaas \
--to=helgaas@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bharat.kumar.gogada@amd.com \
--cc=conor.dooley@microchip.com \
--cc=daire.mcnamara@microchip.com \
--cc=heiko@sntech.de \
--cc=jonathanh@nvidia.com \
--cc=joyce.ooi@intel.com \
--cc=kbuild-all@lists.01.org \
--cc=kishon@kernel.org \
--cc=kw@linux.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=lpieralisi@kernel.org \
--cc=minghuan.Lian@nxp.com \
--cc=mingkai.hu@nxp.com \
--cc=monstr@monstr.eu \
--cc=pali@kernel.org \
--cc=rjui@broadcom.com \
--cc=robh@kernel.org \
--cc=roy.zang@nxp.com \
--cc=sbranden@broadcom.com \
--cc=shawn.lin@rock-chips.com \
--cc=thierry.reding@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=tjoseph@cadence.com \
--cc=toan@os.amperecomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).