From: Jakub Kicinski <kuba@kernel.org>
To: Doug Berger <opendmb@gmail.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
kernel test robot <lkp@intel.com>,
linux-scsi@vger.kernel.org, netdev@vger.kernel.org,
Julia Lawall <Julia.Lawall@inria.fr>,
linux-mm@kvack.org, linux-mediatek@lists.infradead.org,
Andrew Morton <akpm@linux-foundation.org>,
ntfs3@lists.linux.dev, linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [linux-next:master] BUILD REGRESSION 89bf6e28373beef9577fa71f996a5f73a569617c
Date: Tue, 25 Oct 2022 16:17:16 -0700 [thread overview]
Message-ID: <20221025161716.1b92a033@kernel.org> (raw)
In-Reply-To: <8fbc9d02-3c73-5990-85af-82eecb6d64e3@gmail.com>
On Tue, 25 Oct 2022 16:04:15 -0700 Doug Berger wrote:
> > On Wed, 26 Oct 2022 01:17:48 +0800 kernel test robot wrote:
> >> drivers/net/ethernet/broadcom/genet/bcmgenet.c:1497:5-13: ERROR: invalid reference to the index variable of the iterator on line 1475
> >
> > CC Doug
> Thanks for highlighting this for me, but I happened to catch it from the
> linux-mm list and was just looking into it.
>
> It looks to me like a false positive since I am initializing the
> loc_rule variable in all paths outside of the list_for_each_entry() loop
> prior to its use on line 1497.
Ack, indeed the code looks right. Thanks for investigating.
> If desired I can submit a new patch to make coccinelle happy.
I wonder if Cocci can detect writes. Let me add Julia for visibility.
If not we can use a different variable for the "check if already
exists" iteration? It could make the code easier to follow, IMHO.
Or leave it be.
prev parent reply other threads:[~2022-10-25 23:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-25 17:17 [linux-next:master] BUILD REGRESSION 89bf6e28373beef9577fa71f996a5f73a569617c kernel test robot
2022-10-25 22:41 ` Jakub Kicinski
2022-10-25 23:04 ` Doug Berger
2022-10-25 23:17 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221025161716.1b92a033@kernel.org \
--to=kuba@kernel.org \
--cc=Julia.Lawall@inria.fr \
--cc=akpm@linux-foundation.org \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mm@kvack.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lkp@intel.com \
--cc=netdev@vger.kernel.org \
--cc=ntfs3@lists.linux.dev \
--cc=opendmb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).