From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DC828C4332F for ; Tue, 1 Nov 2022 22:44:47 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4N24pQ3Fdqz3cPg for ; Wed, 2 Nov 2022 09:44:46 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=WuFx8933; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=2604:1380:4641:c500::1; helo=dfw.source.kernel.org; envelope-from=pali@kernel.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=WuFx8933; dkim-atps=neutral Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4N24nP38QFz2ywV for ; Wed, 2 Nov 2022 09:43:53 +1100 (AEDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 16EA9611DA; Tue, 1 Nov 2022 22:43:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 575F7C433B5; Tue, 1 Nov 2022 22:43:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1667342630; bh=2zNKF9sIrblZIsup7pAfIEmiHmxsXlJEBUxwNTmO6lk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WuFx8933JHTEaadMAo6XrnWpo7g90tPRQXRB7DjNMKQsdDQFCmBF6z2ATeQ3euU32 YBGfwPJKcJyhJDvV2HVx01O8lxSvdmvftj49OjVWC2lj4f8SX+znJm4IHz+2p0iWHj BV+J+bK1SRItD5IU5Z15NXggaCX44NYUK+0I6LSjAg/1TQqaS67nRVOcttR0LLCc9V 45FZsSbEtoIaQMEwuvKXA4VFegTvmUt1t725ep8CTMfNLWrjykTJkuI+VuquWX55ty UdgdVccL3o85KRdikcu4o6sXDJx+6+WtFzQbSupglm8bbenKmKfmSOp9gBiKk2C0vq H9zjXfz5qaTfg== Received: by pali.im (Postfix) id 1312D7F8; Tue, 1 Nov 2022 23:43:48 +0100 (CET) Date: Tue, 1 Nov 2022 23:43:48 +0100 From: Pali =?utf-8?B?Um9ow6Fy?= To: Michael Ellerman , Nicholas Piggin , Christophe Leroy Subject: Re: [PATCH] powerpc: dts: turris1x.dts: Add channel labels for temperature sensor Message-ID: <20221101224348.xkpzucskunn46i5z@pali> References: <20220930123901.10251-1-pali@kernel.org> <20220930124618.kyaansrl7ls5kn3i@pali> <20221009120506.itwa4n25nljn2tll@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221009120506.itwa4n25nljn2tll@pali> User-Agent: NeoMutt/20180716 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-hwmon@vger.kernel.org, Marek =?utf-8?B?QmVow7pu?= , Josef Schlehofer , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Michael, could you take this patch? On Sunday 09 October 2022 14:05:06 Pali Rohár wrote: > On Friday 30 September 2022 14:46:18 Pali Rohár wrote: > > + CC hwmon ML > > > > On Friday 30 September 2022 14:39:01 Pali Rohár wrote: > > > Channel 0 of SA56004ED chip refers to internal SA56004ED chip sensor (chip > > > itself is located on the board) and channel 1 of SA56004ED chip refers to > > > external sensor which is connected to temperature diode of the P2020 CPU. > > > > > > Fixes: 54c15ec3b738 ("powerpc: dts: Add DTS file for CZ.NIC Turris 1.x routers") > > > Signed-off-by: Pali Rohár > > > --- > > > With this change userspace 'sensors' applications prints labels: > > > > > > $ sensors > > > sa56004-i2c-0-4c > > > Adapter: MPC adapter (i2c@3000) > > > board: +34.2°C (low = +0.0°C, high = +70.0°C) > > > (crit = +85.0°C, hyst = +75.0°C) > > > cpu: +58.9°C (low = +0.0°C, high = +70.0°C) > > > (crit = +85.0°C, hyst = +75.0°C) > > > > > > And without this change it prints just generic tempX names: > > > > > > $ sensors > > > sa56004-i2c-0-4c > > > Adapter: MPC adapter (i2c@3000) > > > temp1: +43.0°C (low = +0.0°C, high = +70.0°C) > > > (crit = +85.0°C, hyst = +75.0°C) > > > temp2: +63.4°C (low = +0.0°C, high = +70.0°C) > > > (crit = +85.0°C, hyst = +75.0°C) > > > --- > > > arch/powerpc/boot/dts/turris1x.dts | 14 ++++++++++++++ > > > 1 file changed, 14 insertions(+) > > > > > > diff --git a/arch/powerpc/boot/dts/turris1x.dts b/arch/powerpc/boot/dts/turris1x.dts > > > index 4033c554b06a..5b5278c32e43 100644 > > > --- a/arch/powerpc/boot/dts/turris1x.dts > > > +++ b/arch/powerpc/boot/dts/turris1x.dts > > > @@ -69,6 +69,20 @@ > > > interrupt-parent = <&gpio>; > > > interrupts = <12 IRQ_TYPE_LEVEL_LOW>, /* GPIO12 - ALERT pin */ > > > <13 IRQ_TYPE_LEVEL_LOW>; /* GPIO13 - CRIT pin */ > > > + #address-cells = <1>; > > > + #size-cells = <0>; > > > + > > > + /* Local temperature sensor (SA56004ED internal) */ > > > + channel@0 { > > > + reg = <0>; > > > + label = "board"; > > > + }; > > > + > > > + /* Remote temperature sensor (D+/D- connected to P2020 CPU Temperature Diode) */ > > > + channel@1 { > > > + reg = <1>; > > > + label = "cpu"; > > > + }; > > > > I'm not sure if you want UPPERCASE, lowercase, PascalCase, kebab-case > > or snake_case format of labels. Or if you want also "temp" or > > "temperature" keyword in the label. So please adjust label to the > > preferred one, if proposed format is not the correct. > > Ok, if nobody complains then please take this patch as is. > > > > }; > > > > > > /* DDR3 SPD/EEPROM */ > > > -- > > > 2.20.1 > > >