From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 349DDC4332F for ; Wed, 16 Nov 2022 16:17:35 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4NC7Vj64dNz3cMc for ; Thu, 17 Nov 2022 03:17:33 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=OKLQAXun; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=145.40.73.55; helo=sin.source.kernel.org; envelope-from=helgaas@kernel.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=OKLQAXun; dkim-atps=neutral Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4NC7Sk0yxRz3f3h for ; Thu, 17 Nov 2022 03:15:50 +1100 (AEDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 8D325CE1BD1; Wed, 16 Nov 2022 16:15:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7A606C433D6; Wed, 16 Nov 2022 16:15:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668615346; bh=sDJKa1fbG0u3Us3nL6jtxWazW2/yIEjiBXrsp/ZezNI=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=OKLQAXunR0A8tOp3VcPtuOkm+Fb0sHJnqyryDeFuwlCNZXpvXInros6PSED8376eZ IBexbk15bbBAN/CfADlMufcqkmkWw6VXAz9VYupLJ4TgYr2A5AD1mX2byD7cPqT1Vj LGeKraHBrWKWwFbCgk94zdAjCm1WoA+1WwuEOlx7B1udWeFdG4VadEko0xYYydS2Eu BNSE0qfMHIvhe7yuA1sQiBzZUjdvk3v3+q7EMfl1FWZBI1D1KDW16Gpg9AZNoePjCd IUbfeGRLsFunbPknRv0RhY9W8ziRmH2o+xa7hahtABjosB43Dxe9cl9/XwAzh/xkT0 uGk0NsCdAk7WQ== Date: Wed, 16 Nov 2022 10:15:45 -0600 From: Bjorn Helgaas To: Thomas Gleixner Subject: Re: [patch 17/39] PCI/MSI: Get rid of externs in msi.h Message-ID: <20221116161545.GA1114836@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221111122014.582175082@linutronix.de> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pci@vger.kernel.org, Will Deacon , Lorenzo Pieralisi , Dave Jiang , Ashok Raj , Joerg Roedel , x86@kernel.org, Jason Gunthorpe , Allen Hubbe , Kevin Tian , "Ahmed S. Darwish" , Jon Mason , linuxppc-dev@lists.ozlabs.org, Alex Williamson , Bjorn Helgaas , Dan Williams , Reinette Chatre , Greg Kroah-Hartman , LKML , Marc Zyngier , Logan Gunthorpe Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, Nov 11, 2022 at 02:54:42PM +0100, Thomas Gleixner wrote: > From: Ahmed S. Darwish > > Follow the style of > > Signed-off-by: Ahmed S. Darwish > Signed-off-by: Thomas Gleixner Acked-by: Bjorn Helgaas > --- > drivers/pci/msi/msi.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > --- a/drivers/pci/msi/msi.h > +++ b/drivers/pci/msi/msi.h > @@ -5,12 +5,12 @@ > > #define msix_table_size(flags) ((flags & PCI_MSIX_FLAGS_QSIZE) + 1) > > -extern int pci_msi_setup_msi_irqs(struct pci_dev *dev, int nvec, int type); > -extern void pci_msi_teardown_msi_irqs(struct pci_dev *dev); > +int pci_msi_setup_msi_irqs(struct pci_dev *dev, int nvec, int type); > +void pci_msi_teardown_msi_irqs(struct pci_dev *dev); > > #ifdef CONFIG_PCI_MSI_ARCH_FALLBACKS > -extern int pci_msi_legacy_setup_msi_irqs(struct pci_dev *dev, int nvec, int type); > -extern void pci_msi_legacy_teardown_msi_irqs(struct pci_dev *dev); > +int pci_msi_legacy_setup_msi_irqs(struct pci_dev *dev, int nvec, int type); > +void pci_msi_legacy_teardown_msi_irqs(struct pci_dev *dev); > #else > static inline int pci_msi_legacy_setup_msi_irqs(struct pci_dev *dev, int nvec, int type) > { >