From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B1892C4332F for ; Sat, 24 Dec 2022 17:45:57 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4NfWg752TFz3c8N for ; Sun, 25 Dec 2022 04:45:55 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=dUAVA1qE; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=145.40.68.75; helo=ams.source.kernel.org; envelope-from=pali@kernel.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=dUAVA1qE; dkim-atps=neutral Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4NfWf50jqmz2yNX for ; Sun, 25 Dec 2022 04:45:00 +1100 (AEDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 409E0B80185; Sat, 24 Dec 2022 17:44:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B0E61C433D2; Sat, 24 Dec 2022 17:44:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1671903896; bh=He27IQA6KWGHia3dQKQhu9qvd62uNfXqU30MadzXD7w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dUAVA1qE8G9kwB7CUsS8aorbmPKeDcbUc0NsvtCqjl9JOhF4Z/mGTev5zfewOgEu8 Ikuqp3eWfeFbPzTp6XyPSDrLnU+6EpfCfBCTZqaOXHT1ML6VQ6jc7mDZ2mAKIqv6z+ nMzA0CSWU2uNFZl1SL3VmY0QNrbqn+Bp/5W80L86rQvk4hMp6MD2tLSMzQhUet8OBB kz6nPQz/t+UeF3a103Yz522wOFta8hshg54VPU8+Ek+YEsVqMXwzrHwq9qp9mAQIIu OdsuYg60k6cVekRP8pC5ftp+b5Gtk6Lw+BAz9uK3W1PCYHcaM2zWXIH+z4Nq5I0d+v LjAOVk2LfC3UA== Received: by pali.im (Postfix) id 8BFD0720; Sat, 24 Dec 2022 18:44:52 +0100 (CET) Date: Sat, 24 Dec 2022 18:44:52 +0100 From: Pali =?utf-8?B?Um9ow6Fy?= To: Christophe Leroy Subject: Re: [PATCH v3] powerpc/boot: Don't always pass -mcpu=powerpc when building 32-bit uImage Message-ID: <20221224174452.xxlkmos7yoy3qn42@pali> References: <20220820105200.30425-1-pali@kernel.org> <20220828095659.4061-1-pali@kernel.org> <20220828174135.rcql4uiunqbnn5gh@pali> <20221208191602.diywrt3g2f6zmt4s@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20180716 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-kernel@vger.kernel.org" , Paul Mackerras , Joel Stanley , "linuxppc-dev@lists.ozlabs.org" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thursday 08 December 2022 19:57:39 Christophe Leroy wrote: > Le 08/12/2022 à 20:16, Pali Rohár a écrit : > > On Sunday 28 August 2022 17:43:53 Christophe Leroy wrote: > >> Le 28/08/2022 à 19:41, Pali Rohár a écrit : > >>> On Sunday 28 August 2022 17:39:25 Christophe Leroy wrote: > >>>> Le 28/08/2022 à 19:33, Christophe Leroy a écrit : > >>>>> > >>>>> > >>>>> Le 28/08/2022 à 11:56, Pali Rohár a écrit : > >>>>>> When CONFIG_TARGET_CPU is specified then pass its value to the compiler > >>>>>> -mcpu option. This fixes following build error when building kernel with > >>>>>> powerpc e500 SPE capable cross compilers: > >>>>>> > >>>>>>      BOOTAS  arch/powerpc/boot/crt0.o > >>>>>>    powerpc-linux-gnuspe-gcc: error: unrecognized argument in option > >>>>>> ‘-mcpu=powerpc’ > >>>>>>    powerpc-linux-gnuspe-gcc: note: valid arguments to ‘-mcpu=’ are: > >>>>>> 8540 8548 native > >>>>>>    make[1]: *** [arch/powerpc/boot/Makefile:231: > >>>>>> arch/powerpc/boot/crt0.o] Error 1 > >>>>> > >>>>> corenet64_smp_defconfig : > >>>>> > >>>>>   BOOTAS  arch/powerpc/boot/crt0.o > >>>>> powerpc64-linux-gcc: error: missing argument to '-mcpu=' > >>>>> make[1]: *** [arch/powerpc/boot/Makefile:237 : arch/powerpc/boot/crt0.o] > >>>>> Erreur 1 > >>>>> make: *** [arch/powerpc/Makefile:253 : uImage] Erreur 2 > >>>>> > >>>>> > >>>> > >>>> Seems like in fact, E5500_CPU and E6500_CPU are not taken into account > >>>> in CONFIG_TARGET_CPU, and get special treatment directly in > >>>> arch/powerpc/Makefile. > >>>> > >>>> This goes unnoticed because of CFLAGS-$(CONFIG_TARGET_CPU_BOOL) += > >>>> $(call cc-option,-mcpu=$(CONFIG_TARGET_CPU)) > >>>> > >>>> I think we need to fix that prior to your patch. > >>> > >>> It looks like that CONFIG_TARGET_CPU is broken. > >>> > >>> $ make ARCH=powerpc corenet64_smp_defconfig CROSS_COMPILE=powerpc64-linux-gnu- > >>> ... > >>> # configuration written to .config > >>> > >>> $ grep CONFIG_TARGET_CPU .config > >>> CONFIG_TARGET_CPU_BOOL=y > >>> > >>> CONFIG_TARGET_CPU_BOOL is set but CONFIG_TARGET_CPU not! > >> > >> Yes, because there is no default value for E5500_CPU and E6500_CPU. We > >> need to add one for each. > > > > With "[PATCH v1] powerpc/64: Set default CPU in Kconfig" patch from > > https://lore.kernel.org/linuxppc-dev/3fd60c2d8a28668a42b766b18362a526ef47e757.1670420281.git.christophe.leroy@csgroup.eu/ > > this change does not throw above compile error anymore. > > > That patch should land in powerpc/next soon. When it has landed, could > you resent this patch so that snowpatch checks the build again ? Yes. But I'm still waiting because patch is not in powerpc/next yet. > Because at the time being it is flagged as "failed", see > https://patchwork.ozlabs.org/project/linuxppc-dev/patch/20220828095659.4061-1-pali@kernel.org/ > > Christophe