linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Russell Currey <ruscur@russell.cc>
To: linuxppc-dev@lists.ozlabs.org
Cc: ajd@linux.ibm.com, gregkh@linuxfoundation.org,
	nayna@linux.ibm.com, linux-kernel@vger.kernel.org,
	zohar@linux.ibm.com, Russell Currey <ruscur@russell.cc>,
	gcwilson@linux.ibm.com
Subject: [PATCH v2 3/7] powerpc/secvar: Use sysfs_emit() instead of sprintf()
Date: Fri, 30 Dec 2022 15:20:10 +1100	[thread overview]
Message-ID: <20221230042014.154483-4-ruscur@russell.cc> (raw)
In-Reply-To: <20221230042014.154483-1-ruscur@russell.cc>

The secvar format string and object size sysfs files are both ASCII
text, and should use sysfs_emit().  No functional change.

Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Russell Currey <ruscur@russell.cc>
---
v2: new

 arch/powerpc/kernel/secvar-sysfs.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/powerpc/kernel/secvar-sysfs.c b/arch/powerpc/kernel/secvar-sysfs.c
index 1ee4640a2641..02e9fee1552e 100644
--- a/arch/powerpc/kernel/secvar-sysfs.c
+++ b/arch/powerpc/kernel/secvar-sysfs.c
@@ -35,7 +35,7 @@ static ssize_t format_show(struct kobject *kobj, struct kobj_attribute *attr,
 	if (rc)
 		goto out;
 
-	rc = sprintf(buf, "%s\n", format);
+	rc = sysfs_emit(buf, "%s\n", format);
 
 out:
 	of_node_put(node);
@@ -57,7 +57,7 @@ static ssize_t size_show(struct kobject *kobj, struct kobj_attribute *attr,
 		return rc;
 	}
 
-	return sprintf(buf, "%llu\n", dsize);
+	return sysfs_emit(buf, "%llu\n", dsize);
 }
 
 static ssize_t data_read(struct file *filep, struct kobject *kobj,
-- 
2.38.1


  parent reply	other threads:[~2022-12-30  4:24 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-30  4:20 [PATCH v2 0/7] pseries dynamic secure boot interface using secvar Russell Currey
2022-12-30  4:20 ` [PATCH v2 1/7] powerpc/pseries: Log hcall return codes for PLPKS debug Russell Currey
2023-01-04  4:45   ` Andrew Donnellan
2022-12-30  4:20 ` [PATCH v2 2/7] powerpc/secvar: WARN_ON_ONCE() if multiple secvar ops are set Russell Currey
2023-01-04  7:10   ` Andrew Donnellan
2022-12-30  4:20 ` Russell Currey [this message]
2023-01-04  7:12   ` [PATCH v2 3/7] powerpc/secvar: Use sysfs_emit() instead of sprintf() Andrew Donnellan
2022-12-30  4:20 ` [PATCH v2 4/7] powerpc/secvar: Handle format string in the consumer Russell Currey
2023-01-04  7:31   ` Andrew Donnellan
2022-12-30  4:20 ` [PATCH v2 5/7] powerpc/secvar: Handle max object size " Russell Currey
2023-01-04  7:50   ` Andrew Donnellan
2022-12-30  4:20 ` [PATCH v2 6/7] powerpc/secvar: Extend sysfs to include config vars Russell Currey
2023-01-05  7:28   ` Andrew Donnellan
2023-01-06  6:33     ` Russell Currey
2023-01-06  4:15   ` Michael Ellerman
2023-01-06  6:35     ` Russell Currey
2022-12-30  4:20 ` [PATCH v2 7/7] powerpc/pseries: Implement secvars for dynamic secure boot Russell Currey
2023-01-05  8:15   ` Andrew Donnellan
2023-01-06  6:49     ` Russell Currey
2023-01-09  4:42       ` Andrew Donnellan
2023-01-06 10:49   ` Michael Ellerman
2023-01-09  3:33     ` Andrew Donnellan
2023-01-09  3:34     ` Russell Currey
2023-01-09  5:20       ` Andrew Donnellan
2023-01-10  1:27         ` Russell Currey
2023-01-10  3:59     ` Andrew Donnellan
2023-01-11  3:57     ` Andrew Donnellan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221230042014.154483-4-ruscur@russell.cc \
    --to=ruscur@russell.cc \
    --cc=ajd@linux.ibm.com \
    --cc=gcwilson@linux.ibm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=nayna@linux.ibm.com \
    --cc=zohar@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).