From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9C4B5C677F1 for ; Wed, 11 Jan 2023 15:41:27 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4NsX396ZDYz3cf1 for ; Thu, 12 Jan 2023 02:41:25 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=Q+o9216w; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=bootlin.com (client-ip=2001:4b98:dc4:8::224; helo=relay4-d.mail.gandi.net; envelope-from=herve.codina@bootlin.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=Q+o9216w; dkim-atps=neutral Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::224]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4NsX292PNDz2yJv for ; Thu, 12 Jan 2023 02:40:32 +1100 (AEDT) Received: (Authenticated sender: herve.codina@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id B16AFE0004; Wed, 11 Jan 2023 15:40:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1673451624; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TJ80tI+n7E12DAvDikBDbLVrg9IXgTxZ252Cq+neEbQ=; b=Q+o9216wXpyzH4Fmo4XE+A/19Rhli449oB8gxh74cMuVSBe7TmgTWv0NVMgETjHj7ICimI 2lEldE8luCvEuRzv4wncGEOGkp8+YWnj/gHNVwVIcANGc/i9KFCarw2xI7Zy7ii4mw01BP 3yh4Y2Qf6FLQR/pCfsBovsMC1nhClDVRgsfz9BsqGrMm8sPNTEXSy366YeN1nX8+aedw2l 5dU2xzoQw9jeYIRqNq8AjlA436V/DgDKdEL+uikobI8yvJhFeEtymQvw2NPhOwbDD2+MwT mU28pFltJe6k53uG/R2oCKCPp6dR2f20BtbgaXKCRweyOUiSP64AKbrgZhfqEA== Date: Wed, 11 Jan 2023 16:40:18 +0100 From: Herve Codina To: Christophe Leroy Subject: Re: [PATCH v2 06/10] soc: fsl: qe: Add support for QMC Message-ID: <20230111164018.676a8ca1@bootlin.com> In-Reply-To: References: <20230106163746.439717-1-herve.codina@bootlin.com> <20230106163746.439717-7-herve.codina@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.34; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devicetree@vger.kernel.org" , "alsa-devel@alsa-project.org" , Fabio Estevam , "linux-kernel@vger.kernel.org" , Thomas Petazzoni , Xiubo Li , Takashi Iwai , Liam Girdwood , Rob Herring , Li Yang , Nicolin Chen , "linuxppc-dev@lists.ozlabs.org" , Mark Brown , Nicholas Piggin , Krzysztof Kozlowski , Jaroslav Kysela , Shengjiu Wang , "linux-arm-kernel@lists.infradead.org" , Qiang Zhao Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hi Christophe, On Wed, 11 Jan 2023 13:58:03 +0000 Christophe Leroy wrote: > Le 06/01/2023 =C3=A0 17:37, Herve Codina a =C3=A9crit=C2=A0: > > The QMC (QUICC Multichannel Controller) is available on some > > PowerQUICC SoC such as the MPC885 or MPC866. =20 >=20 > Same, that's QMC for CPM for the time being, should that be made clear=20 > in the subject ? Also same answer: Will changing the subject be enough or do I need to move it to new created drivers/soc/fsl/cpm/ directory ? >=20 > QE also has QMC and this driver might be used for QE QMC as well with=20 > some enhancement, maybe that could be explained here ? Yes and we plan to have it working on QE too. What do you think if I add the following: The QMC is also available on some Quicc Engine SoC. This current version support CPM1 SoC only. Some enhancement are needed to support Quicc Engine SoC. >=20 > I see you are using in_be16(), out_be16() etc .... > That's specific to powerpc arch, maybe it is better to use ioread16be,=20 > iowrite16be() etc .... > See commit 3f39f38ea91d ("soc: fsl: qe: replace qe_io{read,write}*=20 > wrappers by generic io{read,write}*") and commit 6ac9b61786cc ("soc:=20 > fsl: qe: introduce qe_io{read,write}* wrappers") for information. You're right. I will switch to io{read,write}{16,32}be. I prefer avoid the use of qe_* wrappers as the driver is not (yet) compatible with QE. >=20 > >=20 > > It emulates up to 64 channels within one serial controller > > using the same TDM physical interface routed from the TSA. > >=20 > > Signed-off-by: Herve Codina =20 >=20 > In some places, you comments use the network style, not the generic style. I will fix them. >=20 > Christophe Thanks for the review, Herv=C3=A9 --=20 Herv=C3=A9 Codina, Bootlin Embedded Linux and Kernel engineering https://bootlin.com