linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Michal Suchanek <msuchanek@suse.de>
Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE"
	<devicetree@vger.kernel.org>, "Erhard F ." <erhard_f@mailbox.org>,
	linuxppc-dev@lists.ozlabs.org,
	Javier Martinez Canillas <javierm@redhat.com>,
	open list <linux-kernel@vger.kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Michal Suchanek <msuchanek@suse.de>,
	Frank Rowand <frowand.list@gmail.com>
Subject: [PATCH] of: Make of framebuffer devices unique
Date: Tue, 17 Jan 2023 17:58:04 +0100	[thread overview]
Message-ID: <20230117165804.18036-1-msuchanek@suse.de> (raw)

Since Linux 5.19 this error is observed:

sysfs: cannot create duplicate filename '/devices/platform/of-display'

This is because multiple devices with the same name 'of-display' are
created on the same bus.

Update the code to create numbered device names for the non-boot
disaplay.

cc: linuxppc-dev@lists.ozlabs.org
References: https://bugzilla.kernel.org/show_bug.cgi?id=216095
Fixes: 52b1b46c39ae ("of: Create platform devices for OF framebuffers")
Reported-by: Erhard F. <erhard_f@mailbox.org>
Suggested-by: Thomas Zimmermann <tzimmermann@suse.de>
Signed-off-by: Michal Suchanek <msuchanek@suse.de>
---
 drivers/of/platform.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/of/platform.c b/drivers/of/platform.c
index 81c8c227ab6b..f2a5d679a324 100644
--- a/drivers/of/platform.c
+++ b/drivers/of/platform.c
@@ -525,6 +525,7 @@ static int __init of_platform_default_populate_init(void)
 	if (IS_ENABLED(CONFIG_PPC)) {
 		struct device_node *boot_display = NULL;
 		struct platform_device *dev;
+		int display_number = 1;
 		int ret;
 
 		/* Check if we have a MacOS display without a node spec */
@@ -561,10 +562,15 @@ static int __init of_platform_default_populate_init(void)
 			boot_display = node;
 			break;
 		}
+
 		for_each_node_by_type(node, "display") {
+			char *buf[14];
 			if (!of_get_property(node, "linux,opened", NULL) || node == boot_display)
 				continue;
-			of_platform_device_create(node, "of-display", NULL);
+			ret = snprintf(buf, "of-display-%d", display_number++);
+			if (ret >= sizeof(buf))
+				continue;
+			of_platform_device_create(node, buf, NULL);
 		}
 
 	} else {
-- 
2.35.3


             reply	other threads:[~2023-01-17 16:59 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-17 16:58 Michal Suchanek [this message]
2023-01-18 16:24 ` [PATCH] of: Make of framebuffer devices unique Rob Herring
2023-01-18 20:13 ` Erhard F.
2023-01-18 21:46   ` Michal Suchánek
2023-01-19  8:00     ` Thomas Zimmermann
2023-01-19  9:01       ` Michal Suchánek
2023-01-19  9:18         ` Thomas Zimmermann
2023-01-18 21:50   ` [PATCH] of: Fix of platform build on powerpc due to bad of disaply code Michal Suchanek
2023-01-19  9:53     ` [PATCH v2] " Michal Suchanek
2023-01-19 10:00       ` Thomas Zimmermann
2023-01-19 10:24       ` Christophe Leroy
2023-01-19 10:34         ` Michal Suchánek
2023-01-20 12:10           ` Michal Suchánek
2023-01-19 13:11         ` Thomas Zimmermann
2023-01-19 13:23           ` Michal Suchánek
2023-01-19 15:20             ` Thomas Zimmermann
2023-01-20 11:27               ` Michal Suchánek
2023-01-20 11:39                 ` Thomas Zimmermann
2023-01-20 11:56                   ` Michal Suchánek
2023-01-19 11:42       ` Erhard F.
2023-01-19 15:18       ` Rob Herring
2023-01-20 17:23       ` Rob Herring
2023-01-20 17:52         ` Michal Suchánek
2023-01-20 18:09         ` [PATCH v3] of: Make of framebuffer devices unique Michal Suchanek
2023-01-30 16:50           ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230117165804.18036-1-msuchanek@suse.de \
    --to=msuchanek@suse.de \
    --cc=devicetree@vger.kernel.org \
    --cc=erhard_f@mailbox.org \
    --cc=frowand.list@gmail.com \
    --cc=javierm@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=robh+dt@kernel.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).