From: Nathan Lynch via B4 Submission Endpoint <devnull+nathanl.linux.ibm.com@kernel.org>
To: Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Kajol Jain <kjain@linux.ibm.com>,
Laurent Dufour <ldufour@linux.ibm.com>,
Mahesh J Salgaonkar <mahesh@linux.ibm.com>,
Andrew Donnellan <ajd@linux.ibm.com>,
Nick Child <nnac123@linux.ibm.com>
Cc: Nathan Lynch <nathanl@linux.ibm.com>, linuxppc-dev@lists.ozlabs.org
Subject: [PATCH v3 00/20] RTAS maintenance
Date: Fri, 10 Feb 2023 12:41:48 -0600 [thread overview]
Message-ID: <20230125-b4-powerpc-rtas-queue-v3-0-26929c8cce78@linux.ibm.com> (raw)
Proposed changes for the RTAS subsystem and client code.
Fixes that are subject to backporting are at the front of the queue.
The rest of the queue is roughly ordered with respect to maturity:
i.e. patches that have already garnered some review and discussion
precede newer, more experimental changes.
Major features:
* Static tracepoints around RTAS entry/exit.
* An allocator for work area buffers.
* A new client of the work area allocator in the form of a
higher-level API for PAPR system parameter retrieval.
* Constant-time symbolic RTAS function token lookups.
Tested with ppc64le in PowerVM LPARs and QEMU's pseries
model. Obsolescent RTAS platforms (chrp, cell, maple) get build
coverage.
---
Changes in v3:
* Additions:
- Ensure 4KB alignment for rtas_data_buf.
* Modifications to existing patches (all per Michael Ellerman)
- Rename "ret" to "retry" in rtas_busy_delay_early().
- Reset the stuck counter when rtas_busy_delay_early() warns.
- Explain addition of __ref to rtas_busy_delay().
- Spell out function index constants instead of cpp-pasting.
- Use more conventional header inclusion guards in new heaaders.
- Align early_work_area_buf.
- Prevent bad arguments to rtas_work_area_alloc() with a
compile-time assertion.
- Discard pr_devel() from rtas-work-area.c.
- Access work area allocator state through a single struct instead
of a pointer indirection.
- Initialize work area descriptors more conventionally.
- Ensure rtas_function_token() returns RTAS_UNKNOWN_SERVICE on
non-RTAS platforms.
- Move rtas-work-area.c to platforms/pseries/ and initialize it on
pseries only.
* Link to v2: https://lore.kernel.org/r/20230125-b4-powerpc-rtas-queue-v2-0-9aa6bd058063@linux.ibm.com
Changes in v2:
* Drop applied patches:
- powerpc/rtas: document rtas_call()
- powerpc/rtasd: use correct OF API for event scan rate
- powerpc/rtas: avoid device tree lookups in rtas_os_term()
- powerpc/rtas: avoid scheduling in rtas_os_term()
- powerpc/pseries/eeh: use correct API for error log size
- powerpc/rtas: clean up rtas_error_log_max initialization
- powerpc/rtas: clean up includes
- powerpc/rtas: define pr_fmt and convert printk call sites
- powerpc/rtas: mandate RTAS syscall filtering
* Additions:
- Safe early-boot fallback in rtas_busy_delay().
- Fixes for missed RTAS function call retries in various places.
- Remove RTAS timebase sync from pseries, previously posted
separately as "powerpc/pseries: drop RTAS-based timebase
synchronization":
https://lore.kernel.org/linuxppc-dev/20230110042845.121792-1-nathanl@linux.ibm.com/T/#u
- RTAS work area buffer allocator.
- Conversion of pseries DLPAR code to work area allocator.
- A pseries-specific PAPR system parameter API built on top of the
RTAS work area allocator.
- Conversion of ibm,get-system-parameter users to papr_sysparm API.
- New rtas_function_token() API and associated conversions.
* Modifications to existing patches:
- Convert RTAS tracepoint definitions to unconditional
variants (TRACE_EVENT_CONDITION() -> TRACE_EVENT()), dropping a
cpu_online() check that duplicates work already done at the call
site.
- Skip tracepoints in unsafe contexts (real mode, CPU
offline). (Nicholas Piggin)
- Use bool bitfield for "banned on LE" function flag.
- Better documentation for "banned on LE" function flag. (Andrew Donnellan)
- Drop unnecessary cast for xa_load() key argument. (Nick Child)
* Link to v1: https://lore.kernel.org/r/20221118150751.469393-1-nathanl@linux.ibm.com
---
Nathan Lynch (20):
powerpc/rtas: handle extended delays safely in early boot
powerpc/perf/hv-24x7: add missing RTAS retry status handling
powerpc/pseries/lpar: add missing RTAS retry status handling
powerpc/pseries/lparcfg: add missing RTAS retry status handling
powerpc/pseries/setup: add missing RTAS retry status handling
powerpc/rtas: ensure 4KB alignment for rtas_data_buf
powerpc/pseries: drop RTAS-based timebase synchronization
powerpc/rtas: improve function information lookups
powerpc/rtas: strengthen do_enter_rtas() type safety, drop inline
powerpc/tracing: tracepoints for RTAS entry and exit
powerpc/rtas: add tracepoints around RTAS entry
powerpc/pseries: add RTAS work area allocator
powerpc/pseries/dlpar: use RTAS work area API
powerpc/pseries: PAPR system parameter API
powerpc/pseries: convert CMO probe to papr_sysparm API
powerpc/pseries/lparcfg: convert to papr_sysparm API
powerpc/pseries/hv-24x7: convert to papr_sysparm API
powerpc/pseries/lpar: convert to papr_sysparm API
powerpc/rtas: introduce rtas_function_token() API
powerpc/rtas: arch-wide function token lookup conversions
arch/powerpc/include/asm/papr-sysparm.h | 38 +
arch/powerpc/include/asm/rtas-work-area.h | 96 +++
arch/powerpc/include/asm/rtas.h | 184 +++++
arch/powerpc/include/asm/trace.h | 103 +++
arch/powerpc/kernel/rtas-proc.c | 24 +-
arch/powerpc/kernel/rtas-rtc.c | 6 +-
arch/powerpc/kernel/rtas.c | 951 ++++++++++++++++++++----
arch/powerpc/kernel/rtas_flash.c | 21 +-
arch/powerpc/kernel/rtas_pci.c | 8 +-
arch/powerpc/kernel/rtasd.c | 2 +-
arch/powerpc/perf/hv-24x7.c | 45 +-
arch/powerpc/platforms/52xx/efika.c | 4 +-
arch/powerpc/platforms/cell/ras.c | 4 +-
arch/powerpc/platforms/cell/smp.c | 4 +-
arch/powerpc/platforms/chrp/nvram.c | 4 +-
arch/powerpc/platforms/chrp/pci.c | 4 +-
arch/powerpc/platforms/chrp/setup.c | 4 +-
arch/powerpc/platforms/maple/setup.c | 4 +-
arch/powerpc/platforms/pseries/Makefile | 2 +-
arch/powerpc/platforms/pseries/dlpar.c | 29 +-
arch/powerpc/platforms/pseries/eeh_pseries.c | 22 +-
arch/powerpc/platforms/pseries/hotplug-cpu.c | 4 +-
arch/powerpc/platforms/pseries/io_event_irq.c | 2 +-
arch/powerpc/platforms/pseries/lpar.c | 37 +-
arch/powerpc/platforms/pseries/lparcfg.c | 104 +--
arch/powerpc/platforms/pseries/mobility.c | 4 +-
arch/powerpc/platforms/pseries/msi.c | 4 +-
arch/powerpc/platforms/pseries/nvram.c | 4 +-
arch/powerpc/platforms/pseries/papr-sysparm.c | 151 ++++
arch/powerpc/platforms/pseries/pci.c | 2 +-
arch/powerpc/platforms/pseries/ras.c | 2 +-
arch/powerpc/platforms/pseries/rtas-work-area.c | 209 ++++++
arch/powerpc/platforms/pseries/setup.c | 27 +-
arch/powerpc/platforms/pseries/smp.c | 12 +-
arch/powerpc/sysdev/xics/ics-rtas.c | 8 +-
arch/powerpc/xmon/xmon.c | 16 +-
36 files changed, 1717 insertions(+), 428 deletions(-)
---
base-commit: 0bfb97203f5f300777624a2ad6f8f84aea3e8658
change-id: 20230125-b4-powerpc-rtas-queue-cf85ec465ff9
Best regards,
--
Nathan Lynch <nathanl@linux.ibm.com>
next reply other threads:[~2023-02-10 18:43 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-10 18:41 Nathan Lynch via B4 Submission Endpoint [this message]
2023-02-10 18:41 ` [PATCH v3 01/20] powerpc/rtas: handle extended delays safely in early boot Nathan Lynch via B4 Submission Endpoint
2023-02-10 18:41 ` [PATCH v3 02/20] powerpc/perf/hv-24x7: add missing RTAS retry status handling Nathan Lynch via B4 Submission Endpoint
2023-02-10 18:41 ` [PATCH v3 03/20] powerpc/pseries/lpar: " Nathan Lynch via B4 Submission Endpoint
2023-02-10 18:41 ` [PATCH v3 04/20] powerpc/pseries/lparcfg: " Nathan Lynch via B4 Submission Endpoint
2023-02-10 18:41 ` [PATCH v3 05/20] powerpc/pseries/setup: " Nathan Lynch via B4 Submission Endpoint
2023-02-10 18:41 ` [PATCH v3 06/20] powerpc/rtas: ensure 4KB alignment for rtas_data_buf Nathan Lynch via B4 Submission Endpoint
2023-02-10 18:41 ` [PATCH v3 07/20] powerpc/pseries: drop RTAS-based timebase synchronization Nathan Lynch via B4 Submission Endpoint
2023-02-10 18:41 ` [PATCH v3 08/20] powerpc/rtas: improve function information lookups Nathan Lynch via B4 Submission Endpoint
2023-02-10 18:41 ` [PATCH v3 09/20] powerpc/rtas: strengthen do_enter_rtas() type safety, drop inline Nathan Lynch via B4 Submission Endpoint
2023-02-10 18:41 ` [PATCH v3 10/20] powerpc/tracing: tracepoints for RTAS entry and exit Nathan Lynch via B4 Submission Endpoint
2023-02-10 18:41 ` [PATCH v3 11/20] powerpc/rtas: add tracepoints around RTAS entry Nathan Lynch via B4 Submission Endpoint
2023-02-10 18:42 ` [PATCH v3 12/20] powerpc/pseries: add RTAS work area allocator Nathan Lynch via B4 Submission Endpoint
2023-02-10 18:42 ` [PATCH v3 13/20] powerpc/pseries/dlpar: use RTAS work area API Nathan Lynch via B4 Submission Endpoint
2023-02-10 18:42 ` [PATCH v3 14/20] powerpc/pseries: PAPR system parameter API Nathan Lynch via B4 Submission Endpoint
2023-02-10 18:42 ` [PATCH v3 15/20] powerpc/pseries: convert CMO probe to papr_sysparm API Nathan Lynch via B4 Submission Endpoint
2023-02-10 18:42 ` [PATCH v3 16/20] powerpc/pseries/lparcfg: convert " Nathan Lynch via B4 Submission Endpoint
2023-02-10 18:42 ` [PATCH v3 17/20] powerpc/pseries/hv-24x7: " Nathan Lynch via B4 Submission Endpoint
2023-02-10 18:42 ` [PATCH v3 18/20] powerpc/pseries/lpar: " Nathan Lynch via B4 Submission Endpoint
2023-02-10 18:42 ` [PATCH v3 19/20] powerpc/rtas: introduce rtas_function_token() API Nathan Lynch via B4 Submission Endpoint
2023-02-10 18:42 ` [PATCH v3 20/20] powerpc/rtas: arch-wide function token lookup conversions Nathan Lynch via B4 Submission Endpoint
2023-02-15 12:41 ` [PATCH v3 00/20] RTAS maintenance Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230125-b4-powerpc-rtas-queue-v3-0-26929c8cce78@linux.ibm.com \
--to=devnull+nathanl.linux.ibm.com@kernel.org \
--cc=ajd@linux.ibm.com \
--cc=christophe.leroy@csgroup.eu \
--cc=kjain@linux.ibm.com \
--cc=ldufour@linux.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mahesh@linux.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=nathanl@linux.ibm.com \
--cc=nnac123@linux.ibm.com \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).