From: Nathan Lynch via B4 Submission Endpoint <devnull+nathanl.linux.ibm.com@kernel.org>
To: Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Kajol Jain <kjain@linux.ibm.com>,
Laurent Dufour <ldufour@linux.ibm.com>,
Mahesh J Salgaonkar <mahesh@linux.ibm.com>,
Andrew Donnellan <ajd@linux.ibm.com>,
Nick Child <nnac123@linux.ibm.com>
Cc: Nathan Lynch <nathanl@linux.ibm.com>, linuxppc-dev@lists.ozlabs.org
Subject: [PATCH v3 15/20] powerpc/pseries: convert CMO probe to papr_sysparm API
Date: Fri, 10 Feb 2023 12:42:03 -0600 [thread overview]
Message-ID: <20230125-b4-powerpc-rtas-queue-v3-15-26929c8cce78@linux.ibm.com> (raw)
In-Reply-To: <20230125-b4-powerpc-rtas-queue-v3-0-26929c8cce78@linux.ibm.com>
From: Nathan Lynch <nathanl@linux.ibm.com>
Convert the direct invocation of the ibm,get-system-parameter RTAS
function to papr_sysparm_get().
Signed-off-by: Nathan Lynch <nathanl@linux.ibm.com>
---
arch/powerpc/platforms/pseries/setup.c | 23 ++++++-----------------
1 file changed, 6 insertions(+), 17 deletions(-)
diff --git a/arch/powerpc/platforms/pseries/setup.c b/arch/powerpc/platforms/pseries/setup.c
index 74e50b6b28d4..420a2fa48292 100644
--- a/arch/powerpc/platforms/pseries/setup.c
+++ b/arch/powerpc/platforms/pseries/setup.c
@@ -57,6 +57,7 @@
#include <asm/pmc.h>
#include <asm/xics.h>
#include <asm/xive.h>
+#include <asm/papr-sysparm.h>
#include <asm/ppc-pci.h>
#include <asm/i8259.h>
#include <asm/udbg.h>
@@ -941,32 +942,21 @@ void pSeries_coalesce_init(void)
*/
static void __init pSeries_cmo_feature_init(void)
{
- const s32 token = rtas_token("ibm,get-system-parameter");
+ static struct papr_sysparm_buf buf __initdata;
+ static_assert(sizeof(buf.val) >= CMO_MAXLENGTH);
char *ptr, *key, *value, *end;
- int call_status;
int page_order = IOMMU_PAGE_SHIFT_4K;
pr_debug(" -> fw_cmo_feature_init()\n");
- do {
- spin_lock(&rtas_data_buf_lock);
- call_status = rtas_call(token, 3, 1, NULL,
- CMO_CHARACTERISTICS_TOKEN,
- __pa(rtas_data_buf),
- RTAS_DATA_BUF_SIZE);
- if (call_status == 0)
- break;
- spin_unlock(&rtas_data_buf_lock);
- } while (rtas_busy_delay(call_status));
-
- if (call_status != 0) {
+ if (papr_sysparm_get(PAPR_SYSPARM_COOP_MEM_OVERCOMMIT_ATTRS, &buf)) {
pr_debug("CMO not available\n");
pr_debug(" <- fw_cmo_feature_init()\n");
return;
}
- end = rtas_data_buf + CMO_MAXLENGTH - 2;
- ptr = rtas_data_buf + 2; /* step over strlen value */
+ end = &buf.val[CMO_MAXLENGTH];
+ ptr = &buf.val[0];
key = value = ptr;
while (*ptr && (ptr <= end)) {
@@ -1012,7 +1002,6 @@ static void __init pSeries_cmo_feature_init(void)
} else
pr_debug("CMO not enabled, PrPSP=%d, SecPSP=%d\n", CMO_PrPSP,
CMO_SecPSP);
- spin_unlock(&rtas_data_buf_lock);
pr_debug(" <- fw_cmo_feature_init()\n");
}
--
2.39.1
next prev parent reply other threads:[~2023-02-10 18:59 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-10 18:41 [PATCH v3 00/20] RTAS maintenance Nathan Lynch via B4 Submission Endpoint
2023-02-10 18:41 ` [PATCH v3 01/20] powerpc/rtas: handle extended delays safely in early boot Nathan Lynch via B4 Submission Endpoint
2023-02-10 18:41 ` [PATCH v3 02/20] powerpc/perf/hv-24x7: add missing RTAS retry status handling Nathan Lynch via B4 Submission Endpoint
2023-02-10 18:41 ` [PATCH v3 03/20] powerpc/pseries/lpar: " Nathan Lynch via B4 Submission Endpoint
2023-02-10 18:41 ` [PATCH v3 04/20] powerpc/pseries/lparcfg: " Nathan Lynch via B4 Submission Endpoint
2023-02-10 18:41 ` [PATCH v3 05/20] powerpc/pseries/setup: " Nathan Lynch via B4 Submission Endpoint
2023-02-10 18:41 ` [PATCH v3 06/20] powerpc/rtas: ensure 4KB alignment for rtas_data_buf Nathan Lynch via B4 Submission Endpoint
2023-02-10 18:41 ` [PATCH v3 07/20] powerpc/pseries: drop RTAS-based timebase synchronization Nathan Lynch via B4 Submission Endpoint
2023-02-10 18:41 ` [PATCH v3 08/20] powerpc/rtas: improve function information lookups Nathan Lynch via B4 Submission Endpoint
2023-02-10 18:41 ` [PATCH v3 09/20] powerpc/rtas: strengthen do_enter_rtas() type safety, drop inline Nathan Lynch via B4 Submission Endpoint
2023-02-10 18:41 ` [PATCH v3 10/20] powerpc/tracing: tracepoints for RTAS entry and exit Nathan Lynch via B4 Submission Endpoint
2023-02-10 18:41 ` [PATCH v3 11/20] powerpc/rtas: add tracepoints around RTAS entry Nathan Lynch via B4 Submission Endpoint
2023-02-10 18:42 ` [PATCH v3 12/20] powerpc/pseries: add RTAS work area allocator Nathan Lynch via B4 Submission Endpoint
2023-02-10 18:42 ` [PATCH v3 13/20] powerpc/pseries/dlpar: use RTAS work area API Nathan Lynch via B4 Submission Endpoint
2023-02-10 18:42 ` [PATCH v3 14/20] powerpc/pseries: PAPR system parameter API Nathan Lynch via B4 Submission Endpoint
2023-02-10 18:42 ` Nathan Lynch via B4 Submission Endpoint [this message]
2023-02-10 18:42 ` [PATCH v3 16/20] powerpc/pseries/lparcfg: convert to papr_sysparm API Nathan Lynch via B4 Submission Endpoint
2023-02-10 18:42 ` [PATCH v3 17/20] powerpc/pseries/hv-24x7: " Nathan Lynch via B4 Submission Endpoint
2023-02-10 18:42 ` [PATCH v3 18/20] powerpc/pseries/lpar: " Nathan Lynch via B4 Submission Endpoint
2023-02-10 18:42 ` [PATCH v3 19/20] powerpc/rtas: introduce rtas_function_token() API Nathan Lynch via B4 Submission Endpoint
2023-02-10 18:42 ` [PATCH v3 20/20] powerpc/rtas: arch-wide function token lookup conversions Nathan Lynch via B4 Submission Endpoint
2023-02-15 12:41 ` [PATCH v3 00/20] RTAS maintenance Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230125-b4-powerpc-rtas-queue-v3-15-26929c8cce78@linux.ibm.com \
--to=devnull+nathanl.linux.ibm.com@kernel.org \
--cc=ajd@linux.ibm.com \
--cc=christophe.leroy@csgroup.eu \
--cc=kjain@linux.ibm.com \
--cc=ldufour@linux.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mahesh@linux.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=nathanl@linux.ibm.com \
--cc=nnac123@linux.ibm.com \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).