linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: kvm@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>,
	Sean Christopherson <seanjc@google.com>
Cc: Claudio Imbrenda <imbrenda@linux.ibm.com>,
	Janosch Frank <frankja@linux.ibm.com>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Marc Zyngier <maz@kernel.org>,
	David Hildenbrand <david@redhat.com>,
	linux-kernel@vger.kernel.org,
	Oliver Upton <oliver.upton@linux.dev>,
	Zenghui Yu <yuzenghui@huawei.com>,
	James Morse <james.morse@arm.com>,
	kvm-riscv@lists.infradead.org, kvmarm@lists.linux.dev,
	Christian Borntraeger <borntraeger@linux.ibm.com>,
	linuxppc-dev@lists.ozlabs.org
Subject: [PATCH 0/7] KVM: Standardize on "int" return types instead of "long"
Date: Fri,  3 Feb 2023 10:42:23 +0100	[thread overview]
Message-ID: <20230203094230.266952-1-thuth@redhat.com> (raw)

This patch series is a follow-up from one of my patches in 2022 and
Sean's reply here:

 https://lore.kernel.org/kvm/YpZu6%2Fk+8EydfBKf@google.com/

KVM functions use "long" return values for functions that are wired up
to "struct file_operations", but otherwise use "int" return values for
functions that can return 0/-errno in order to avoid unintentional
divergences between 32-bit and 64-bit kernels. Some related functions
that are not part of a "struct file_operations" still use "long", though,
which can cause confusion or even subtle problems (see second patch).
Thus let's standardize on using "int" for return values in these functions
to avoid such problems in the future.

Thomas Huth (7):
  KVM: Standardize on "int" return types instead of "long" in kvm_main.c
  KVM: x86: Improve return type handling in
    kvm_vm_ioctl_get_nr_mmu_pages()
  KVM: Move KVM_GET_NR_MMU_PAGES into the deprecation section
  KVM: PPC: Standardize on "int" return types in the powerpc KVM code
  KVM: s390: Use "int" as return type for kvm_s390_get/set_skeys()
  KVM: arm64: Change return type of kvm_vm_ioctl_mte_copy_tags() to
    "int"
  KVM: Change return type of kvm_arch_vm_ioctl() to "int"

 arch/arm64/include/asm/kvm_host.h   |  4 ++--
 arch/arm64/kvm/arm.c                |  3 +--
 arch/arm64/kvm/guest.c              |  4 ++--
 arch/mips/kvm/mips.c                |  4 ++--
 arch/powerpc/include/asm/kvm_ppc.h  | 14 +++++++-------
 arch/powerpc/kvm/book3s_64_mmu_hv.c | 14 +++++++-------
 arch/powerpc/kvm/book3s_64_vio.c    |  4 ++--
 arch/powerpc/kvm/book3s_hv.c        |  6 +++---
 arch/powerpc/kvm/book3s_pr.c        |  4 ++--
 arch/powerpc/kvm/powerpc.c          |  5 ++---
 arch/riscv/kvm/vm.c                 |  3 +--
 arch/s390/kvm/kvm-s390.c            |  7 +++----
 arch/x86/kvm/x86.c                  |  8 +++++---
 include/linux/kvm_host.h            |  3 +--
 include/uapi/linux/kvm.h            |  3 ++-
 virt/kvm/kvm_main.c                 |  4 ++--
 16 files changed, 44 insertions(+), 46 deletions(-)

-- 
2.31.1


             reply	other threads:[~2023-02-03  9:43 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-03  9:42 Thomas Huth [this message]
2023-02-03  9:42 ` [PATCH 1/7] KVM: Standardize on "int" return types instead of "long" in kvm_main.c Thomas Huth
2023-02-03  9:42 ` [PATCH 2/7] KVM: x86: Improve return type handling in kvm_vm_ioctl_get_nr_mmu_pages() Thomas Huth
2023-02-03 17:48   ` Sean Christopherson
2023-02-07  9:26     ` Thomas Huth
2023-02-07 16:25       ` Sean Christopherson
2023-02-03  9:42 ` [PATCH 3/7] KVM: Move KVM_GET_NR_MMU_PAGES into the deprecation section Thomas Huth
2023-02-03 10:16   ` Nicholas Piggin
2023-02-03 10:54     ` Thomas Huth
2023-02-03  9:42 ` [PATCH 4/7] KVM: PPC: Standardize on "int" return types in the powerpc KVM code Thomas Huth
2023-02-03 10:21   ` Nicholas Piggin
2023-02-03  9:42 ` [PATCH 5/7] KVM: s390: Use "int" as return type for kvm_s390_get/set_skeys() Thomas Huth
2023-02-07 15:36   ` Claudio Imbrenda
2023-02-03  9:42 ` [PATCH 6/7] KVM: arm64: Change return type of kvm_vm_ioctl_mte_copy_tags() to "int" Thomas Huth
2023-02-07  0:09   ` Gavin Shan
2023-02-07 10:09     ` Thomas Huth
2023-02-07 22:16       ` Gavin Shan
2023-02-08  8:49         ` Cornelia Huck
2023-02-08 11:51           ` Steven Price
2023-02-08 12:16             ` Thomas Huth
2023-02-03  9:42 ` [PATCH 7/7] KVM: Change return type of kvm_arch_vm_ioctl() " Thomas Huth
2023-02-08 17:35   ` Claudio Imbrenda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230203094230.266952-1-thuth@redhat.com \
    --to=thuth@redhat.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=david@redhat.com \
    --cc=frankja@linux.ibm.com \
    --cc=imbrenda@linux.ibm.com \
    --cc=james.morse@arm.com \
    --cc=kvm-riscv@lists.infradead.org \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=maz@kernel.org \
    --cc=oliver.upton@linux.dev \
    --cc=pbonzini@redhat.com \
    --cc=seanjc@google.com \
    --cc=suzuki.poulose@arm.com \
    --cc=yuzenghui@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).