From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7375FC636CD for ; Tue, 7 Feb 2023 15:37:47 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4PB6hT6Y3Qz3cff for ; Wed, 8 Feb 2023 02:37:45 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=gOZf7ZXZ; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux.ibm.com (client-ip=148.163.158.5; helo=mx0b-001b2d01.pphosted.com; envelope-from=imbrenda@linux.ibm.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=gOZf7ZXZ; dkim-atps=neutral Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4PB6gP2bZ6z3bT0 for ; Wed, 8 Feb 2023 02:36:48 +1100 (AEDT) Received: from pps.filterd (m0098421.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 317FHYDG029274; Tue, 7 Feb 2023 15:36:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding; s=pp1; bh=1THnRWeDL5EycU0KSF5rNw1gmtsHkkvviicj+5+IlfI=; b=gOZf7ZXZ8dplyODS3aGlH+TLt485eAuYKKaAAXObqznZqnA006AKZCcN5KKkN/rNhxW6 5THM8sU8hL2sr76rhF/wy0B0fPRbkIvFfraAem5qXSr0em4emDNG2alSu3aUueWaVO2N OnJMf1VQpmAwrlLIu8ocx/5Fx1uVWG4Jp2DYdPXCcB1uXLubA8aL36PHEuWXVyrdDfpk JtF57C3dXxFUUPG+dBna1WxARpnp9phG/YauTJkSKZmlmK/TeUWpx3t3dSJzYug8fzPu L6a4j26d9HkRy4aXq9qnPAOMQ+2s1wzcuDPeW2/eCcWK8YoCvp6wFl7cMEG+dL3jtTkx bw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3nks5f8hka-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 07 Feb 2023 15:36:16 +0000 Received: from m0098421.ppops.net (m0098421.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 317FJQdM005425; Tue, 7 Feb 2023 15:36:16 GMT Received: from ppma05fra.de.ibm.com (6c.4a.5195.ip4.static.sl-reverse.com [149.81.74.108]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3nks5f8hhu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 07 Feb 2023 15:36:15 +0000 Received: from pps.filterd (ppma05fra.de.ibm.com [127.0.0.1]) by ppma05fra.de.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 3172fI09017256; Tue, 7 Feb 2023 15:36:13 GMT Received: from smtprelay04.fra02v.mail.ibm.com ([9.218.2.228]) by ppma05fra.de.ibm.com (PPS) with ESMTPS id 3nhf06tpa9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 07 Feb 2023 15:36:13 +0000 Received: from smtpav03.fra02v.mail.ibm.com (smtpav03.fra02v.mail.ibm.com [10.20.54.102]) by smtprelay04.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 317Fa9UW15925584 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 7 Feb 2023 15:36:09 GMT Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CB11F20063; Tue, 7 Feb 2023 15:36:09 +0000 (GMT) Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6D21A2004B; Tue, 7 Feb 2023 15:36:09 +0000 (GMT) Received: from p-imbrenda (unknown [9.152.224.56]) by smtpav03.fra02v.mail.ibm.com (Postfix) with ESMTP; Tue, 7 Feb 2023 15:36:09 +0000 (GMT) Date: Tue, 7 Feb 2023 16:36:07 +0100 From: Claudio Imbrenda To: Thomas Huth Subject: Re: [PATCH 5/7] KVM: s390: Use "int" as return type for kvm_s390_get/set_skeys() Message-ID: <20230207163607.4cf6739c@p-imbrenda> In-Reply-To: <20230203094230.266952-6-thuth@redhat.com> References: <20230203094230.266952-1-thuth@redhat.com> <20230203094230.266952-6-thuth@redhat.com> Organization: IBM X-Mailer: Claws Mail 4.1.1 (GTK 3.24.35; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: h1QNOgTrAn4DjVcRnfzpjxJfKWNrvq6W X-Proofpoint-GUID: 90LiL_K4VkqoTHGkM7gQCTWyDwGtHxR- X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1 definitions=2023-02-07_07,2023-02-06_03,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 malwarescore=0 bulkscore=0 spamscore=0 lowpriorityscore=0 adultscore=0 suspectscore=0 mlxlogscore=999 phishscore=0 clxscore=1011 priorityscore=1501 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2302070138 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Janosch Frank , kvm@vger.kernel.org, Suzuki K Poulose , Sean Christopherson , David Hildenbrand , linux-kernel@vger.kernel.org, Oliver Upton , Zenghui Yu , James Morse , kvm-riscv@lists.infradead.org, Marc Zyngier , kvmarm@lists.linux.dev, Paolo Bonzini , Christian Borntraeger , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, 3 Feb 2023 10:42:28 +0100 Thomas Huth wrote: > These two functions only return normal integers, so it does not > make sense to declare the return type as "long" here. > > Signed-off-by: Thomas Huth Reviewed-by: Claudio Imbrenda > --- > arch/s390/kvm/kvm-s390.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c > index e4890e04b210..8ad1972b8a73 100644 > --- a/arch/s390/kvm/kvm-s390.c > +++ b/arch/s390/kvm/kvm-s390.c > @@ -1992,7 +1992,7 @@ static int kvm_s390_vm_has_attr(struct kvm *kvm, struct kvm_device_attr *attr) > return ret; > } > > -static long kvm_s390_get_skeys(struct kvm *kvm, struct kvm_s390_skeys *args) > +static int kvm_s390_get_skeys(struct kvm *kvm, struct kvm_s390_skeys *args) > { > uint8_t *keys; > uint64_t hva; > @@ -2040,7 +2040,7 @@ static long kvm_s390_get_skeys(struct kvm *kvm, struct kvm_s390_skeys *args) > return r; > } > > -static long kvm_s390_set_skeys(struct kvm *kvm, struct kvm_s390_skeys *args) > +static int kvm_s390_set_skeys(struct kvm *kvm, struct kvm_s390_skeys *args) > { > uint8_t *keys; > uint64_t hva;