From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7A89EC636D4 for ; Fri, 10 Feb 2023 20:05:22 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4PD4Tr4dbyz3f69 for ; Sat, 11 Feb 2023 07:05:20 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=Ec302W45; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=139.178.84.217; helo=dfw.source.kernel.org; envelope-from=helgaas@kernel.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=Ec302W45; dkim-atps=neutral Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4PD4Sn0LbQz3f62 for ; Sat, 11 Feb 2023 07:04:24 +1100 (AEDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 62ACC61E90; Fri, 10 Feb 2023 20:04:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9022CC433D2; Fri, 10 Feb 2023 20:04:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676059461; bh=9WmhS+AFzxhdlQZRvRCBT4MfcWL+Y2Jom7fpas4JOgc=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=Ec302W45QuG/EuSGN6UmNSOfRiZhIlWJafp6zqBbVA2oNbH8jESPcrwarBuikZeI9 uxwHM5wUCZseGzbBte3PBvDCSCiUVXTWVUNqdFyW8xi/L81VfUMLctRmqEkQDRbeoV potZEheCBcay6U6EP8jcWDVDqitT8D4/fFGP43Vc/hT0Kd9ByTD3ZWFOrrH8T0WwhR zE6b4twEDpnplXv8bT38jmCOo2WwN7QmsiSm8QDYhceBmHVDKad/08Z0HpkvA4jBi4 HpL2WT54s6csNuZ/aEX2pPoIPyvi1dRXKhXlnI2fJjOATmZj0aSbGE4f9AKjRwI4T6 a0YE6gw9ZnThg== Date: Fri, 10 Feb 2023 14:04:19 -0600 From: Bjorn Helgaas To: ALOK TIWARI Subject: Re: [External] : [PATCH v3 1/1] PCI: layerscape: Add EP mode support for ls1028a Message-ID: <20230210200419.GA2694677@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7ab8bdac-3264-2718-e5c9-53bcaa5db010@oracle.com> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: imx@lists.linux.dev, kw@linux.com, linux-pci@vger.kernel.org, lpieralisi@kernel.org, Frank Li , linux-kernel@vger.kernel.org, minghuan.lian@nxp.com, mingkai.hu@nxp.com, roy.zang@nxp.com, bhelgaas@google.com, linuxppc-dev@lists.ozlabs.org, robh@kernel.org, linux-arm-kernel@lists.infradead.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, Feb 10, 2023 at 11:51:46PM +0530, ALOK TIWARI wrote: > LGTM, Thanks a lot for looking at this! In the Linux world, "LGTM" is not something a maintainer can really act on. If you respond with a "Reviewed-by" tag as described here: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=v6.1#n495 maintainers (or tooling like b4) can add it to the patch when merging it. Here are some examples of how it can be used: https://lore.kernel.org/linux-pci/BN9PR11MB527699243353309A1DDFEFBE8CDE9@BN9PR11MB5276.namprd11.prod.outlook.com/ https://lore.kernel.org/linux-pci/Y9AEzVrTB4Sobufr@memverge.com/ https://lore.kernel.org/linux-pci/a20028e6-3318-26ca-117a-26c87c292139@linaro.org/ Bjorn > On 2/9/2023 8:40 PM, Frank Li wrote: > > From: Xiaowei Bao > > > > Add PCIe EP mode support for ls1028a. > > > > Signed-off-by: Xiaowei Bao > > Signed-off-by: Hou Zhiqiang > > Signed-off-by: Frank Li > > Acked-by: Roy Zang