From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B300AC05027 for ; Fri, 17 Feb 2023 20:01:22 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4PJN4101wtz3fT4 for ; Sat, 18 Feb 2023 07:01:21 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lug-owl.de (client-ip=188.68.32.151; helo=lug-owl.de; envelope-from=jbglaw@lug-owl.de; receiver=) Received: from lug-owl.de (lug-owl.de [188.68.32.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4PJN3L3RQ1z3bjx for ; Sat, 18 Feb 2023 07:00:46 +1100 (AEDT) Received: by lug-owl.de (Postfix, from userid 1001) id 6A4C142073; Fri, 17 Feb 2023 21:00:43 +0100 (CET) Date: Fri, 17 Feb 2023 21:00:43 +0100 From: Jan-Benedict Glaw To: Christophe Leroy Subject: Re: microwatt_defconfig broken: fined reference to `hash__tlb_flush' Message-ID: <20230217200043.cubehrboeqeyfhip@lug-owl.de> References: <20230217171407.zuhmdozno3am6flk@lug-owl.de> <670dd176-c896-12ea-228e-c7db32f5b955@csgroup.eu> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="5gr232aitmpevuyt" Content-Disposition: inline In-Reply-To: <670dd176-c896-12ea-228e-c7db32f5b955@csgroup.eu> X-Operating-System: Linux chamaeleon 5.14.0-0.bpo.2-amd64 X-gpg-fingerprint: 250D 3BCF 7127 0D8C A444 A961 1DBD 5E75 8399 E1BB X-gpg-key: wwwkeys.de.pgp.net X-Echelon-Enable: howto poison arsenous mail psychological biological nuclear warfare test the bombastical terror of flooding the spy listeners explosion sex drugs and rock'n'roll X-TKUeV: howto poison arsenous mail psychological biological nuclear warfare test the bombastical terror of flooding the spy listeners explosion sex drugs and rock'n'roll X-message-flag: Please send plain text messages only. Do not send HTML emails. Thank you. User-Agent: NeoMutt/20170113 (1.7.2) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linuxppc-dev@lists.ozlabs.org" , Benjamin Gray Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" --5gr232aitmpevuyt Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, 2023-02-17 19:44:27 +0000, Christophe Leroy wrote: >=20 >=20 > Le 17/02/2023 =C3=A0 18:14, Jan-Benedict Glaw a =C3=A9crit=C2=A0: > > Hi! > >=20 > > My CI builds showed that the microwatt_defconfig broke somewhere between > > (upstream Linus) 6d796c50f84ca79f1722bb131799e5a5710c4700 (last known g= ood, log > > at [1]) and 033c40a89f55525139fd5b6342281b09b97d05bf (first known bad, = log at > > [2]) with this: > >=20 > > [...] > > make V=3D1 ARCH=3Dpowerpc CROSS_COMPILE=3Dpowerpc64le-linux- INSTALL_MO= D_PATH=3D/var/lib/laminar/run/linux-powerpc-microwatt_defconfig/28/linux-po= werpc-microwatt_defconfig INSTALL_DTBS_PATH=3D/var/lib/laminar/run/linux-po= werpc-microwatt_defconfig/28/linux-powerpc-microwatt_defconfig all > > [...] > > [mk all 2023-02-17 01:42:27] + powerpc64le-linux-ld -EL -z noexecstack = --no-warn-rwx-segments -Bstatic --build-id=3Dsha1 --orphan-handling=3Dwarn = --script=3D./arch/powerpc/kernel/vmlinux.lds --strip-debug -o .tmp_vmlinux.= kallsyms1 --whole-archive vmlinux.a init/version-timestamp.o --no-whole-arc= hive --start-group lib/lib.a --end-group > > [mk all 2023-02-17 01:42:28] powerpc64le-linux-ld: mm/memory.o: in func= tion `tlb_flush_mmu_tlbonly': > > [mk all 2023-02-17 01:42:28] memory.c:(.text+0x320): undefined referenc= e to `hash__tlb_flush' > > [mk all 2023-02-17 01:42:28] powerpc64le-linux-ld: mm/mmu_gather.o: in = function `tlb_flush_mmu_tlbonly': > > [mk all 2023-02-17 01:42:28] mmu_gather.c:(.text+0xe0): undefined refer= ence to `hash__tlb_flush' > > [mk all 2023-02-17 01:42:28] powerpc64le-linux-ld: mm/mprotect.o: in fu= nction `change_protection': > > [mk all 2023-02-17 01:42:28] mprotect.c:(.text+0x59c): undefined refere= nce to `hash__tlb_flush' > > [mk all 2023-02-17 01:42:28] powerpc64le-linux-ld: mm/madvise.o: in fun= ction `tlb_end_vma.isra.0': > > [mk all 2023-02-17 01:42:28] madvise.c:(.text+0x1f0): undefined referen= ce to `hash__tlb_flush' > > [mk all 2023-02-17 01:42:28] make[1]: *** [scripts/Makefile.vmlinux:35:= vmlinux] Error 1 > > [mk all 2023-02-17 01:42:28] make: *** [Makefile:1264: vmlinux] Error 2 >=20 >=20 > The fix is available here :=20 > https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/= ?id=3D4302abc628fc0dc08e5855f21bbfaed407a72bc3 I can give that patch a try, but on the first glimpse, it won't help: diff --git a/arch/powerpc/include/asm/book3s/64/tlbflush.h b/arch/powerpc/i= nclude/asm/book3s/64/tlbflush.h index d5cd16270c5d5..2bbc0fcce04a3 100644 --- a/arch/powerpc/include/asm/book3s/64/tlbflush.h +++ b/arch/powerpc/include/asm/book3s/64/tlbflush.h @@ -97,8 +97,8 @@ static inline void tlb_flush(struct mmu_gather *tlb) { if (radix_enabled()) radix__tlb_flush(tlb); - - return hash__tlb_flush(tlb); + else + hash__tlb_flush(tlb); } =20 #ifdef CONFIG_SMP The patch handles a return-type issue. My above issue is a linkage issue, the linker cannot find hash__tlb_flush(). Or am I mistaken? MfG, JBG --=20 --5gr232aitmpevuyt Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQQlDTvPcScNjKREqWEdvV51g5nhuwUCY+/c6QAKCRAdvV51g5nh uzfmAJ9JvOzFDlDHFBb9pgVSAYkuNi/uNACfSU4udup5CUnEuIaWhEdgZEhCyTM= =E7Qo -----END PGP SIGNATURE----- --5gr232aitmpevuyt--