From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0466AC636D7 for ; Tue, 21 Feb 2023 21:50:36 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4PLtJC3B5wz3cBj for ; Wed, 22 Feb 2023 08:50:35 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=mebYZWm2; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=2604:1380:4641:c500::1; helo=dfw.source.kernel.org; envelope-from=pali@kernel.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=mebYZWm2; dkim-atps=neutral Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4PLtH75RClz307T for ; Wed, 22 Feb 2023 08:49:39 +1100 (AEDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5EE6C61073; Tue, 21 Feb 2023 21:49:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A439BC433D2; Tue, 21 Feb 2023 21:49:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1677016173; bh=pAbh1qpRwZHYif3dhmhr56zWO0B5N9xahJp3h56mwko=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mebYZWm2Wf7RzrZ8nzhMD2km5MO1Fc2LwHieKlcVPAGwLju+WVkIv5xfk6bjuamxo NNXDpOFrFytFY7C0AmOWcsHVU9XSi4uVmzK0DoJuJBhPgI86JCKN4rw4CxvK3xM+P8 2xiRjZbBUHFevJHx/5WlYUG/k1KxcLAfQKUZb5QPGRVLQVdy8ubs4eCuYR5EzoZnPu qEtBNpPLjQc8BciDHTFOPaEeTZG43nexmjdt1p29OcTOw+7bHl7ynarHI/mO/dtSy/ lyhOQ1KBNx09qQuoMeGJaaCuYgESpkJDc8HDBy4/urZt3yVIowVKkntlACd2tC1g0h aBobFGeTqx5Iw== Received: by pali.im (Postfix) id 94696708; Tue, 21 Feb 2023 22:49:30 +0100 (CET) Date: Tue, 21 Feb 2023 22:49:30 +0100 From: Pali =?utf-8?B?Um9ow6Fy?= To: Paul Gortmaker Subject: Re: [PATCH 4/4] powerpc: remove orphaned MPC85xx kernel config fragments. Message-ID: <20230221214930.35ttgzntv2vfwlo6@pali> References: <20230221194637.28436-1-paul.gortmaker@windriver.com> <20230221194637.28436-5-paul.gortmaker@windriver.com> <20230221200308.gu3pwrg7layxzkpt@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Li Yang , Scott Wood , Claudiu Manoil , Paul Mackerras , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tuesday 21 February 2023 16:29:32 Paul Gortmaker wrote: > [Re: [PATCH 4/4] powerpc: remove orphaned MPC85xx kernel config fragments.] On 21/02/2023 (Tue 21:03) Pali Roh??r wrote: > > > On Tuesday 21 February 2023 14:46:37 Paul Gortmaker wrote: > > > None of these have a reference anymore anywhere, such as like this: > > > > > > arch/powerpc/Makefile: $(call merge_into_defconfig,mpc85xx_base.config,\ > > > > > > As such, we probably should just clean up and remove them. > > > > > > Cc: Scott Wood > > > Cc: Michael Ellerman > > > Cc: Benjamin Herrenschmidt > > > Cc: Paul Mackerras > > > Signed-off-by: Paul Gortmaker > > > --- > > > arch/powerpc/configs/85xx-32bit.config | 5 - > > > arch/powerpc/configs/85xx-hw.config | 139 ------------------------- > > > arch/powerpc/configs/85xx-smp.config | 2 - > > > 3 files changed, 146 deletions(-) > > > delete mode 100644 arch/powerpc/configs/85xx-32bit.config > > > delete mode 100644 arch/powerpc/configs/85xx-hw.config > > > delete mode 100644 arch/powerpc/configs/85xx-smp.config > > > > This change is likely going to break mpc85xx platform because defconfig > > files includes all these files which you are going to remove. For > > example in arch/powerpc/Makefile is: > > > > PHONY += mpc85xx_smp_defconfig > > mpc85xx_smp_defconfig: > > $(call merge_into_defconfig,mpc85xx_base.config,\ > > 85xx-32bit 85xx-smp 85xx-hw fsl-emb-nonhw) > > OK, it seems you've answered a question for me. That being "why didn't > grep find a reference to these fragments?" > > It seems the ".config" extension is optional? I really do not know. (And I'm not sure if I want to know answer :D) > This seems inconsistent at best, to reference some files with the > .config extension and others without it. Not blaming you for that, > but it is probably something that needs looking into. I agree it is inconsistent. But it was there before I looked or touched any powerpc code. So it looks like something which nobody wanted to cleanup because "it works" and had no motivation. > I am fine with dropping this config frag patch as we figure that out. > > Paul. > -- > > > > > And for P2020 boards I'm using mpc85xx_smp_defconfig configuration as > > this one compiles SMP kernel, ideal for P2020 which is dual-core SoC.