From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 06782C61DA3 for ; Tue, 21 Feb 2023 22:08:20 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4PLthf3k26z3cF0 for ; Wed, 22 Feb 2023 09:08:18 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=tVaBdTfB; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=2604:1380:4601:e00::1; helo=ams.source.kernel.org; envelope-from=pali@kernel.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=tVaBdTfB; dkim-atps=neutral Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4PLtgY39Grz3bNj for ; Wed, 22 Feb 2023 09:07:21 +1100 (AEDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 3F777B810C2; Tue, 21 Feb 2023 22:07:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CC447C433D2; Tue, 21 Feb 2023 22:07:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1677017237; bh=tUOy/Lf1lFHgC7syFw0zK0WWOYCVNyNpVhUbmup6Fd8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tVaBdTfB6Bew3XtYjJJNXMDKVRnEiHCnSWelKVN35VFRr2nmTrZ8BXqKReYrFWdZ7 Ui2G8/NE8BTHI2c7JbA5GpG5Q/401Ct2SYke1CcBG4mBFUXanfeasPu9v/enikA/UB K6em/0hFwcgyDBiDI9nqadTeVxFzpncD45+bBhLPVret8SH/CFcORz2b4K5oVBW/h4 bgWr6CznlF7j8B9Nf+qgLw7RYnv7TgaQQMiV0GV8+p0cSykJLiFs0hM6GYLbFRVfjw 6MziZa/qH9jW6TAq6XjKyVXCSA81fp3Fqko8XLFJb8M+nwHuvMS7tPlynZpp6XSlpY Od+TPZtxLkGfA== Received: by pali.im (Postfix) id 61424708; Tue, 21 Feb 2023 23:07:14 +0100 (CET) Date: Tue, 21 Feb 2023 23:07:14 +0100 From: Pali =?utf-8?B?Um9ow6Fy?= To: Christophe Leroy Subject: Re: [PATCH v3 0/8] powerpc/85xx: p2020: Create one unified machine description Message-ID: <20230221220714.pm64kwsnf3erdjcm@pali> References: <20230218111405.27688-1-pali@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230218111405.27688-1-pali@kernel.org> User-Agent: NeoMutt/20180716 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sinan Akman , linux-kernel@vger.kernel.org, Nicholas Piggin , Scott Wood , Martin Kennedy , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hello Christophe! Could you look at this v3 series? I addressed those small issues and hopefully it should be ready. It would be great to have this finally in v6.3 release. On Saturday 18 February 2023 12:13:57 Pali Rohár wrote: > This patch series unifies all P2020 boards and machine descriptions into > one generic unified P2020 machine description. With this generic machine > description, kernel can boot on any P2020-based board with correct DTS > file. > > Tested on CZ.NIC Turris 1.1 board with has Freescale P2020 processor. > Kernel during booting correctly detects P2020 and prints: > [ 0.000000] Using Freescale P2020 machine description > > Changes in v3: > * Use 'if (IS_ENABLED(CONFIG_PPC_I8259))' instead of '#ifdef CONFIG_PPC_I8259' > * Simplify p2020_probe() > * Patches generated by -M and -C git options > > Link to v2: https://lore.kernel.org/linuxppc-dev/20221224211425.14983-1-pali@kernel.org/ > > Changes in v2: > * Added patch "p2020: Move i8259 code into own function" (separated from the next one) > * Renamed CONFIG_P2020 to CONFIG_PPC_P2020 > * Fixed descriptions > > Link to v1: https://lore.kernel.org/linuxppc-dev/20220819191557.28116-1-pali@kernel.org/ > > Pali Rohár (8): > powerpc/85xx: Mark mpc85xx_rdb_pic_init() as static > powerpc/85xx: Mark mpc85xx_ds_pic_init() as static > powerpc/85xx: p2020: Move all P2020 machine descriptions to p2020.c > powerpc/85xx: p2020: Move i8259 code into own function > powerpc/85xx: p2020: Unify .setup_arch and .init_IRQ callbacks > powerpc/85xx: p2020: Define just one machine description > powerpc/85xx: p2020: Enable boards by new config option > CONFIG_PPC_P2020 > powerpc: dts: turris1x.dts: Remove "fsl,P2020RDB-PC" compatible string > > arch/powerpc/boot/dts/turris1x.dts | 2 +- > arch/powerpc/platforms/85xx/Kconfig | 22 ++- > arch/powerpc/platforms/85xx/Makefile | 1 + > arch/powerpc/platforms/85xx/mpc85xx_ds.c | 25 +--- > arch/powerpc/platforms/85xx/mpc85xx_rdb.c | 46 +----- > .../platforms/85xx/{mpc85xx_ds.c => p2020.c} | 135 ++++++------------ > 6 files changed, 68 insertions(+), 163 deletions(-) > copy arch/powerpc/platforms/85xx/{mpc85xx_ds.c => p2020.c} (52%) > > -- > 2.20.1 >