From: "Pali Rohár" <pali@kernel.org>
To: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: Sinan Akman <sinan@writeme.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Nicholas Piggin <npiggin@gmail.com>,
Scott Wood <oss@buserror.net>,
Martin Kennedy <hurricos@gmail.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH v3 0/8] powerpc/85xx: p2020: Create one unified machine description
Date: Wed, 22 Feb 2023 08:52:08 +0100 [thread overview]
Message-ID: <20230222075208.y2nxqttaxfwsd4ye@pali> (raw)
In-Reply-To: <a692823b-eada-3072-c9e9-83877480454f@csgroup.eu>
On Wednesday 22 February 2023 06:39:07 Christophe Leroy wrote:
> Hi,
>
> Le 21/02/2023 à 23:07, Pali Rohár a écrit :
> > Hello Christophe! Could you look at this v3 series?
> > I addressed those small issues and hopefully it should be ready.
> > It would be great to have this finally in v6.3 release.
>
> I started looking at your series and I will try to provide a feedback
> within a few days.
>
> By the way I see that Paul Gortmaker has started removal of several 85xx
> boards. Should we first take Paul's removal series then see what remains
> before applying yours ? That would make your series even more efficient.
I have already replied to Paul patch series. The important thing is that
we are touching different files, so patch series should be independent.
> Christoph
>
> >
> > On Saturday 18 February 2023 12:13:57 Pali Rohár wrote:
> >> This patch series unifies all P2020 boards and machine descriptions into
> >> one generic unified P2020 machine description. With this generic machine
> >> description, kernel can boot on any P2020-based board with correct DTS
> >> file.
> >>
> >> Tested on CZ.NIC Turris 1.1 board with has Freescale P2020 processor.
> >> Kernel during booting correctly detects P2020 and prints:
> >> [ 0.000000] Using Freescale P2020 machine description
> >>
> >> Changes in v3:
> >> * Use 'if (IS_ENABLED(CONFIG_PPC_I8259))' instead of '#ifdef CONFIG_PPC_I8259'
> >> * Simplify p2020_probe()
> >> * Patches generated by -M and -C git options
> >>
> >> Link to v2: https://lore.kernel.org/linuxppc-dev/20221224211425.14983-1-pali@kernel.org/
> >>
> >> Changes in v2:
> >> * Added patch "p2020: Move i8259 code into own function" (separated from the next one)
> >> * Renamed CONFIG_P2020 to CONFIG_PPC_P2020
> >> * Fixed descriptions
> >>
> >> Link to v1: https://lore.kernel.org/linuxppc-dev/20220819191557.28116-1-pali@kernel.org/
> >>
> >> Pali Rohár (8):
> >> powerpc/85xx: Mark mpc85xx_rdb_pic_init() as static
> >> powerpc/85xx: Mark mpc85xx_ds_pic_init() as static
> >> powerpc/85xx: p2020: Move all P2020 machine descriptions to p2020.c
> >> powerpc/85xx: p2020: Move i8259 code into own function
> >> powerpc/85xx: p2020: Unify .setup_arch and .init_IRQ callbacks
> >> powerpc/85xx: p2020: Define just one machine description
> >> powerpc/85xx: p2020: Enable boards by new config option
> >> CONFIG_PPC_P2020
> >> powerpc: dts: turris1x.dts: Remove "fsl,P2020RDB-PC" compatible string
> >>
> >> arch/powerpc/boot/dts/turris1x.dts | 2 +-
> >> arch/powerpc/platforms/85xx/Kconfig | 22 ++-
> >> arch/powerpc/platforms/85xx/Makefile | 1 +
> >> arch/powerpc/platforms/85xx/mpc85xx_ds.c | 25 +---
> >> arch/powerpc/platforms/85xx/mpc85xx_rdb.c | 46 +-----
> >> .../platforms/85xx/{mpc85xx_ds.c => p2020.c} | 135 ++++++------------
> >> 6 files changed, 68 insertions(+), 163 deletions(-)
> >> copy arch/powerpc/platforms/85xx/{mpc85xx_ds.c => p2020.c} (52%)
> >>
> >> --
> >> 2.20.1
> >>
next prev parent reply other threads:[~2023-02-22 7:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-18 11:13 [PATCH v3 0/8] powerpc/85xx: p2020: Create one unified machine description Pali Rohár
2023-02-18 11:13 ` [PATCH v3 1/8] powerpc/85xx: Mark mpc85xx_rdb_pic_init() as static Pali Rohár
2023-02-18 11:13 ` [PATCH v3 2/8] powerpc/85xx: Mark mpc85xx_ds_pic_init() " Pali Rohár
2023-02-18 11:14 ` [PATCH v3 3/8] powerpc/85xx: p2020: Move all P2020 machine descriptions to p2020.c Pali Rohár
2023-02-18 11:14 ` [PATCH v3 4/8] powerpc/85xx: p2020: Move i8259 code into own function Pali Rohár
2023-02-18 11:14 ` [PATCH v3 5/8] powerpc/85xx: p2020: Unify .setup_arch and .init_IRQ callbacks Pali Rohár
2023-02-18 11:14 ` [PATCH v3 6/8] powerpc/85xx: p2020: Define just one machine description Pali Rohár
2023-02-18 11:14 ` [PATCH v3 7/8] powerpc/85xx: p2020: Enable boards by new config option CONFIG_PPC_P2020 Pali Rohár
2023-02-18 11:14 ` [PATCH v3 8/8] powerpc: dts: turris1x.dts: Remove "fsl,P2020RDB-PC" compatible string Pali Rohár
2023-02-21 22:07 ` [PATCH v3 0/8] powerpc/85xx: p2020: Create one unified machine description Pali Rohár
2023-02-22 6:39 ` Christophe Leroy
2023-02-22 7:52 ` Pali Rohár [this message]
2023-02-22 14:41 ` Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230222075208.y2nxqttaxfwsd4ye@pali \
--to=pali@kernel.org \
--cc=christophe.leroy@csgroup.eu \
--cc=hurricos@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=npiggin@gmail.com \
--cc=oss@buserror.net \
--cc=sinan@writeme.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).