* [PATCH v3] macintosh: via-pmu-led: fix Kconfig for ADB_PMU_LED_DISK
@ 2023-02-23 17:20 Randy Dunlap
0 siblings, 0 replies; only message in thread
From: Randy Dunlap @ 2023-02-23 17:20 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, Paul Mackerras, linuxppc-dev, Elimar Riesebieter
LEDS_TRIGGER_DISK depends on ATA, so selecting LEDS_TRIGGER_DISK
when ATA is not set/enabled causes a Kconfig warning:
WARNING: unmet direct dependencies detected for LEDS_TRIGGER_DISK
Depends on [n]: NEW_LEDS [=y] && LEDS_TRIGGERS [=y] && ATA [=n]
Selected by [y]:
- ADB_PMU_LED_DISK [=y] && MACINTOSH_DRIVERS [=y] && ADB_PMU_LED [=y] && LEDS_CLASS [=y]
Fix this by making ADB_PMU_LED_DISK depend on LEDS_TRIGGER_DISK
instead of selecting it.
Seen on both PPC32 and PPC64.
Fixes: 0e865a80c135 ("macintosh: Remove dependency on IDE_GD_ATA if ADB_PMU_LED_DISK is selected")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Elimar Riesebieter <riesebie@lxtec.de>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: linuxppc-dev@lists.ozlabs.org
---
v2: add a complete Subject: line
v3: change select to depends on (Michael)
drivers/macintosh/Kconfig | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff -- a/drivers/macintosh/Kconfig b/drivers/macintosh/Kconfig
--- a/drivers/macintosh/Kconfig
+++ b/drivers/macintosh/Kconfig
@@ -88,8 +88,7 @@ config ADB_PMU_LED_DISK
bool "Use front LED as DISK LED by default"
depends on ADB_PMU_LED
depends on LEDS_CLASS
- select LEDS_TRIGGERS
- select LEDS_TRIGGER_DISK
+ depends on LEDS_TRIGGER_DISK
help
This option makes the front LED default to the disk trigger
so that it blinks on disk activity.
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-02-23 17:21 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-23 17:20 [PATCH v3] macintosh: via-pmu-led: fix Kconfig for ADB_PMU_LED_DISK Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).