From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BADBBC64EC7 for ; Wed, 1 Mar 2023 13:06:51 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4PRZJ970cLz3cKG for ; Thu, 2 Mar 2023 00:06:49 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lst.de (client-ip=213.95.11.211; helo=verein.lst.de; envelope-from=hch@lst.de; receiver=) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4PRZHZ5R57z3bTc for ; Thu, 2 Mar 2023 00:06:18 +1100 (AEDT) Received: by verein.lst.de (Postfix, from userid 2407) id 57C3B67373; Wed, 1 Mar 2023 14:06:13 +0100 (CET) Date: Wed, 1 Mar 2023 14:06:13 +0100 From: Christoph Hellwig To: Jiaxun Yang Subject: Re: [PATCH v2 5/5] of: address: Always use dma_default_coherent for default coherency Message-ID: <20230301130613.GC467@lst.de> References: <20230223113644.23356-1-jiaxun.yang@flygoat.com> <20230223113644.23356-6-jiaxun.yang@flygoat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230223113644.23356-6-jiaxun.yang@flygoat.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: tsbogend@alpha.franken.de, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, palmer@dabbelt.com, paul.walmsley@sifive.com, robin.murphy@arm.com, linux-riscv@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, hch@lst.de, m.szyprowski@samsung.com Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" > - select OF_DMA_DEFAULT_COHERENT if !NOT_COHERENT_CACHE Doesn't powerpc need to select CONFIG_ARCH_DMA_DEFAULT_COHERENT now, or even better should be doing that in the patch adding that symbol? In fact I wonder if adding CONFIG_ARCH_DMA_DEFAULT_COHERENT and removing OF_DMA_DEFAULT_COHERENT should be one patch, as that seems to bring over the intent a little better I'd say.