From: Nathan Chancellor <nathan@kernel.org>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kbuild@vger.kernel.org
Subject: Re: [PATCH 1/2] powerpc/64: Move CPU -mtune options into Kconfig
Date: Thu, 2 Mar 2023 09:30:55 -0700 [thread overview]
Message-ID: <20230302163055.GA3010526@dev-arch.thelio-3990X> (raw)
In-Reply-To: <20230302131656.50626-1-mpe@ellerman.id.au>
On Fri, Mar 03, 2023 at 12:16:55AM +1100, Michael Ellerman wrote:
> Currently the -mtune options are set in the Makefile, depending on what
> is the compiler supports.
>
> One downside of doing it that way is that the chosen -mtune option is
> not recorded in the .config.
>
> Another downside is that doing more complicated logic to calculate the
> correct option gets messy in the Makefile.
>
> So move the determination of which -mtune option to use into Kconfig
> logic.
>
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
> ---
> arch/powerpc/Makefile | 4 +---
> arch/powerpc/platforms/Kconfig.cputype | 6 ++++++
> 2 files changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/arch/powerpc/Makefile b/arch/powerpc/Makefile
> index 87d6ac27eebd..779956007f0c 100644
> --- a/arch/powerpc/Makefile
> +++ b/arch/powerpc/Makefile
> @@ -156,9 +156,7 @@ endif
> CFLAGS-$(CONFIG_TARGET_CPU_BOOL) += -mcpu=$(CONFIG_TARGET_CPU)
> AFLAGS-$(CONFIG_TARGET_CPU_BOOL) += -mcpu=$(CONFIG_TARGET_CPU)
>
> -CFLAGS-$(CONFIG_POWERPC64_CPU) += $(call cc-option,-mtune=power10, \
> - $(call cc-option,-mtune=power9, \
> - $(call cc-option,-mtune=power8)))
> +CFLAGS-y += $(CONFIG_TUNE_CPU)
>
> asinstr := $(call as-instr,lis 9$(comma)foo@high,-DHAVE_AS_ATHIGH=1)
>
> diff --git a/arch/powerpc/platforms/Kconfig.cputype b/arch/powerpc/platforms/Kconfig.cputype
> index 046b571496b1..7d7477b73951 100644
> --- a/arch/powerpc/platforms/Kconfig.cputype
> +++ b/arch/powerpc/platforms/Kconfig.cputype
> @@ -273,6 +273,12 @@ config TARGET_CPU
> default "e500mc" if E500MC_CPU
> default "powerpc" if POWERPC_CPU
>
> +config TUNE_CPU
> + string
> + default "-mtune=power10" if POWERPC64_CPU && CC_IS_GCC && $(cc-option,-mtune=power10)
> + default "-mtune=power9" if POWERPC64_CPU && CC_IS_GCC && $(cc-option,-mtune=power9)
> + default "-mtune=power8" if POWERPC64_CPU && CC_IS_GCC && $(cc-option,-mtune=power8)
Would it be cleaner to hoist the POWERPC64_CPU dependency?
config TUNE_CPU
string
default "-mtune=power10" if CC_IS_GCC && $(cc-option,-mtune=power10)
default "-mtune=power9" if CC_IS_GCC && $(cc-option,-mtune=power9)
default "-mtune=power8" if CC_IS_GCC && $(cc-option,-mtune=power8)
depends on POWERPC64_CPU
> +
> config PPC_BOOK3S
> def_bool y
> depends on PPC_BOOK3S_32 || PPC_BOOK3S_64
> --
> 2.39.2
>
next prev parent reply other threads:[~2023-03-02 16:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-02 13:16 [PATCH 1/2] powerpc/64: Move CPU -mtune options into Kconfig Michael Ellerman
2023-03-02 13:16 ` [PATCH 2/2] powerpc/64: Use -mtune=pwr10/9/8 for clang Michael Ellerman
2023-03-02 16:43 ` Nathan Chancellor
2023-03-02 23:53 ` Michael Ellerman
2023-03-03 15:14 ` Nathan Chancellor
2023-03-02 16:30 ` Nathan Chancellor [this message]
2023-03-02 23:54 ` [PATCH 1/2] powerpc/64: Move CPU -mtune options into Kconfig Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230302163055.GA3010526@dev-arch.thelio-3990X \
--to=nathan@kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox