* [PATCH] soc: fsl: qe: remove unused qe_ic_from_irq function
@ 2023-03-19 15:37 Tom Rix
2023-03-20 7:14 ` Christophe Leroy
0 siblings, 1 reply; 2+ messages in thread
From: Tom Rix @ 2023-03-19 15:37 UTC (permalink / raw)
To: qiang.zhao, leoyang.li, nathan, ndesaulniers
Cc: Tom Rix, llvm, linuxppc-dev, linux-kernel, linux-arm-kernel
clang with W=1 reports
drivers/soc/fsl/qe/qe_ic.c:235:29: error: unused function
'qe_ic_from_irq' [-Werror,-Wunused-function]
static inline struct qe_ic *qe_ic_from_irq(unsigned int virq)
^
This function is not used, so remove it.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/soc/fsl/qe/qe_ic.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/soc/fsl/qe/qe_ic.c b/drivers/soc/fsl/qe/qe_ic.c
index bbae3d39c7be..c0b4f865fba9 100644
--- a/drivers/soc/fsl/qe/qe_ic.c
+++ b/drivers/soc/fsl/qe/qe_ic.c
@@ -232,11 +232,6 @@ static inline void qe_ic_write(__be32 __iomem *base, unsigned int reg,
iowrite32be(value, base + (reg >> 2));
}
-static inline struct qe_ic *qe_ic_from_irq(unsigned int virq)
-{
- return irq_get_chip_data(virq);
-}
-
static inline struct qe_ic *qe_ic_from_irq_data(struct irq_data *d)
{
return irq_data_get_irq_chip_data(d);
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] soc: fsl: qe: remove unused qe_ic_from_irq function
2023-03-19 15:37 [PATCH] soc: fsl: qe: remove unused qe_ic_from_irq function Tom Rix
@ 2023-03-20 7:14 ` Christophe Leroy
0 siblings, 0 replies; 2+ messages in thread
From: Christophe Leroy @ 2023-03-20 7:14 UTC (permalink / raw)
To: Tom Rix, qiang.zhao@nxp.com, leoyang.li@nxp.com,
nathan@kernel.org, ndesaulniers@google.com
Cc: llvm@lists.linux.dev, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Le 19/03/2023 à 16:37, Tom Rix a écrit :
> clang with W=1 reports
> drivers/soc/fsl/qe/qe_ic.c:235:29: error: unused function
> 'qe_ic_from_irq' [-Werror,-Wunused-function]
> static inline struct qe_ic *qe_ic_from_irq(unsigned int virq)
> ^
> This function is not used, so remove it.
You should mention that it is not used anymore since commit d7c2878cfcfa
("soc: fsl: qe: remove unused qe_ic_set_* functions")
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> drivers/soc/fsl/qe/qe_ic.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/soc/fsl/qe/qe_ic.c b/drivers/soc/fsl/qe/qe_ic.c
> index bbae3d39c7be..c0b4f865fba9 100644
> --- a/drivers/soc/fsl/qe/qe_ic.c
> +++ b/drivers/soc/fsl/qe/qe_ic.c
> @@ -232,11 +232,6 @@ static inline void qe_ic_write(__be32 __iomem *base, unsigned int reg,
> iowrite32be(value, base + (reg >> 2));
> }
>
> -static inline struct qe_ic *qe_ic_from_irq(unsigned int virq)
> -{
> - return irq_get_chip_data(virq);
> -}
> -
> static inline struct qe_ic *qe_ic_from_irq_data(struct irq_data *d)
> {
> return irq_data_get_irq_chip_data(d);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-20 7:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-19 15:37 [PATCH] soc: fsl: qe: remove unused qe_ic_from_irq function Tom Rix
2023-03-20 7:14 ` Christophe Leroy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).