From: Ricardo Ribalda <ribalda@chromium.org>
To: Eric Biederman <ebiederm@xmission.com>,
Philipp Rudo <prudo@linux.vnet.ibm.com>,
Dave Young <dyoung@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Nathan Chancellor <nathan@kernel.org>, Tom Rix <trix@redhat.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>
Cc: Nick Desaulniers <ndesaulniers@google.com>,
Baoquan He <bhe@redhat.com>, Philipp Rudo <prudo@redhat.com>,
llvm@lists.linux.dev, Ross Zwisler <zwisler@google.com>,
linux-kernel@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>,
stable@vger.kernel.org, Simon Horman <horms@kernel.org>,
Ricardo Ribalda <ribalda@chromium.org>,
linux-riscv@lists.infradead.org, linuxppc-dev@lists.ozlabs.org,
kexec@lists.infradead.org
Subject: [PATCH v6 3/4] powerpc/purgatory: Remove profile optimization flags
Date: Mon, 01 May 2023 14:38:21 +0200 [thread overview]
Message-ID: <20230321-kexec_clang16-v6-3-a2255e81ab45@chromium.org> (raw)
In-Reply-To: <20230321-kexec_clang16-v6-0-a2255e81ab45@chromium.org>
If PGO is enabled, the purgatory ends up with multiple .text sections.
This is not supported by kexec and crashes the system.
Cc: stable@vger.kernel.org
Fixes: 930457057abe ("kernel/kexec_file.c: split up __kexec_load_puragory")
Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
---
arch/powerpc/purgatory/Makefile | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/powerpc/purgatory/Makefile b/arch/powerpc/purgatory/Makefile
index 6f5e2727963c..5efb164330b2 100644
--- a/arch/powerpc/purgatory/Makefile
+++ b/arch/powerpc/purgatory/Makefile
@@ -5,6 +5,11 @@ KCSAN_SANITIZE := n
targets += trampoline_$(BITS).o purgatory.ro
+# When profile optimization is enabled, llvm emits two different overlapping
+# text sections, which is not supported by kexec. Remove profile optimization
+# flags.
+KBUILD_CFLAGS := $(filter-out -fprofile-sample-use=% -fprofile-use=%,$(KBUILD_CFLAGS))
+
LDFLAGS_purgatory.ro := -e purgatory_start -r --no-undefined
$(obj)/purgatory.ro: $(obj)/trampoline_$(BITS).o FORCE
--
2.40.1.495.gc816e09b53d-goog
next prev parent reply other threads:[~2023-05-01 12:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-01 12:38 [PATCH v6 0/4] kexec: Fix kexec_file_load for llvm16 with PGO Ricardo Ribalda
2023-05-01 12:38 ` [PATCH v6 1/4] kexec: Support purgatories with .text.hot sections Ricardo Ribalda
2023-05-01 12:38 ` [PATCH v6 2/4] x86/purgatory: Remove profile optimization flags Ricardo Ribalda
2023-05-01 12:38 ` Ricardo Ribalda [this message]
2023-05-01 12:38 ` [PATCH v6 4/4] risc/purgatory: Add linker script Ricardo Ribalda
2023-05-01 12:44 ` Palmer Dabbelt
2023-05-01 16:19 ` Nick Desaulniers
2023-05-01 17:18 ` Ricardo Ribalda
2023-05-01 17:28 ` Conor Dooley
2023-05-01 17:36 ` Ricardo Ribalda
2023-05-01 17:40 ` Conor Dooley
2023-05-01 19:54 ` Ricardo Ribalda
2023-05-05 12:30 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230321-kexec_clang16-v6-3-a2255e81ab45@chromium.org \
--to=ribalda@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=aou@eecs.berkeley.edu \
--cc=bhe@redhat.com \
--cc=bp@alien8.de \
--cc=christophe.leroy@csgroup.eu \
--cc=dave.hansen@linux.intel.com \
--cc=dyoung@redhat.com \
--cc=ebiederm@xmission.com \
--cc=horms@kernel.org \
--cc=hpa@zytor.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=llvm@lists.linux.dev \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=npiggin@gmail.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=prudo@linux.vnet.ibm.com \
--cc=prudo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=trix@redhat.com \
--cc=x86@kernel.org \
--cc=zwisler@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).