From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C13D1C6FD18 for ; Wed, 29 Mar 2023 18:16:15 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4PmvrF6f6Wz3f4p for ; Thu, 30 Mar 2023 05:16:13 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=arm.com (client-ip=217.140.110.172; helo=foss.arm.com; envelope-from=sudeep.holla@arm.com; receiver=) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lists.ozlabs.org (Postfix) with ESMTP id 4Pmvqf4xqGz3c7X for ; Thu, 30 Mar 2023 05:15:39 +1100 (AEDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B965B2F4; Wed, 29 Mar 2023 11:15:50 -0700 (PDT) Received: from bogus (unknown [10.57.52.160]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5F9453F6C4; Wed, 29 Mar 2023 11:14:57 -0700 (PDT) Date: Wed, 29 Mar 2023 19:14:23 +0100 From: Sudeep Holla To: Rob Herring Subject: Re: [PATCH 04/19] of: Move CPU node related functions to their own file Message-ID: <20230329181423.6e2z2giwkgdvhshn@bogus> References: <20230329-dt-cpu-header-cleanups-v1-0-581e2605fe47@kernel.org> <20230329-dt-cpu-header-cleanups-v1-4-581e2605fe47@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230329-dt-cpu-header-cleanups-v1-4-581e2605fe47@kernel.org> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nishanth Menon , Huacai Chen , "Rafael J. Wysocki" , Yangtao Li , Viresh Kumar , Lorenzo Pieralisi , Amit Kucheria , Jiaxun Yang , linux-mips@vger.kernel.org, linux-tegra@vger.kernel.org, Thierry Reding , sparclinux@vger.kernel.org, linux-riscv@lists.infradead.org, Frank Rowand , Viresh Kumar , Bjorn Andersson , Marc Zyngier , Samuel Holland , Daniel Lezcano , Russell King , Jernej Skrabec , Jonathan Hunter , Chen-Yu Tsai , Andy Gross , Anup Patel , Zhang Rui , linux-sunxi@lists.linux.dev, devicetree@vger.kernel.org, A lbert Ou , linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, Nicholas Piggin , Rob Herring , linux-mediatek@lists.infradead.org, Paul Walmsley , Matthias Brugger , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, AngeloGioacchino Del Regno , Stephen Boyd , Greg Kroah-Hartman , Amit Daniel Kachhap , linux-kernel@vger.kernel.org, Konrad Dybcio , Palmer Dabbelt , Sudeep Holla , linuxppc-dev@lists.ozlabs.org, "David S. Miller" , Lukasz Luba Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Wed, Mar 29, 2023 at 10:52:01AM -0500, Rob Herring wrote: > drivers/of/base.c is quite long and we've accumulated a number of CPU > node functions. Let's move them to a new file, cpu.c, along with the > lone of_cpu_device_node_get() in of_device.h. Moving the declaration has > no effect yet as of.h is included by of_device.h. This serves as > preparation to disentangle the includes in of_device.h and > of_platform.h. > Makes sense to have its own file for CPUs, I am sure there will be more additions 😉. FWIW, Reviewed-by: Sudeep Holla -- Regards, Sudeep