* [PATCH 2/2] ASoC: fsl_mqs: call pm_runtime_disable() on error path
@ 2023-04-03 15:27 Liliang Ye
2023-04-17 19:15 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Liliang Ye @ 2023-04-03 15:27 UTC (permalink / raw)
To: Shengjiu Wang, Xiubo Li, Fabio Estevam, Nicolin Chen,
Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai
Cc: hust-os-kernel-patches, alsa-devel, Dan Carpenter, Liliang Ye,
Shengjiu Wang, linux-kernel, linuxppc-dev
pm_runtime_disable was missed in cleanup operation, which corresponds to
the earlier call to pm_runtime_enable.
To fix this, add pm_runtime_disable() on error path.
Fixes: 9e28f6532c61 ("ASoC: fsl_mqs: Add MQS component driver")
Signed-off-by: Liliang Ye <yll@hust.edu.cn>
Reviewed-by: Dan Carpenter <error27@gmail.com>
---
sound/soc/fsl/fsl_mqs.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/sound/soc/fsl/fsl_mqs.c b/sound/soc/fsl/fsl_mqs.c
index 32d20d351bbf..129d426c60c4 100644
--- a/sound/soc/fsl/fsl_mqs.c
+++ b/sound/soc/fsl/fsl_mqs.c
@@ -251,9 +251,13 @@ static int fsl_mqs_probe(struct platform_device *pdev)
ret = devm_snd_soc_register_component(&pdev->dev, &soc_codec_fsl_mqs,
&fsl_mqs_dai, 1);
if (ret)
- return ret;
+ goto err_pm_disable;
return 0;
+
+err_pm_disable:
+ pm_runtime_disable(&pdev->dev);
+ return ret;
}
static int fsl_mqs_remove(struct platform_device *pdev)
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 2/2] ASoC: fsl_mqs: call pm_runtime_disable() on error path
2023-04-03 15:27 [PATCH 2/2] ASoC: fsl_mqs: call pm_runtime_disable() on error path Liliang Ye
@ 2023-04-17 19:15 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2023-04-17 19:15 UTC (permalink / raw)
To: Liliang Ye
Cc: hust-os-kernel-patches, alsa-devel, linuxppc-dev, Dan Carpenter,
Xiubo Li, Shengjiu Wang, Shengjiu Wang, Takashi Iwai,
Liam Girdwood, Jaroslav Kysela, Nicolin Chen, Fabio Estevam,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 243 bytes --]
On Mon, Apr 03, 2023 at 11:27:37PM +0800, Liliang Ye wrote:
> pm_runtime_disable was missed in cleanup operation, which corresponds to
> the earlier call to pm_runtime_enable.
This doesn't apply against current code, please check and resend.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-04-17 19:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-03 15:27 [PATCH 2/2] ASoC: fsl_mqs: call pm_runtime_disable() on error path Liliang Ye
2023-04-17 19:15 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).