From: Nathan Chancellor <nathan@kernel.org>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: kernel test robot <lkp@intel.com>,
Masahiro Yamada <masahiroy@kernel.org>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
linux-kernel@vger.kernel.org, oe-kbuild-all@lists.linux.dev
Subject: Re: arch/powerpc/kvm/../kernel/head_booke.h:20:6: warning: "THREAD_SHIFT" is not defined, evaluates to 0
Date: Fri, 7 Apr 2023 16:15:00 -0700 [thread overview]
Message-ID: <20230407231500.GA2598451@dev-arch.thelio-3990X> (raw)
In-Reply-To: <CAKwvOdmXTOaK+JALp+fr4Q_MtVgi23Te9RvLPF8-Sisc3qWQ=A@mail.gmail.com>
On Fri, Apr 07, 2023 at 04:08:43PM -0700, Nick Desaulniers wrote:
> On Tue, Apr 4, 2023 at 6:29 PM kernel test robot <lkp@intel.com> wrote:
> >
> > Hi Masahiro,
> >
> > FYI, the error/warning still remains.
> >
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> > head: 76f598ba7d8e2bfb4855b5298caedd5af0c374a8
> > commit: 80b6093b55e31c2c40ff082fb32523d4e852954f kbuild: add -Wundef to KBUILD_CPPFLAGS for W=1 builds
> > date: 4 months ago
> > config: powerpc-buildonly-randconfig-r003-20230405 (https://download.01.org/0day-ci/archive/20230405/202304050954.yskLdczH-lkp@intel.com/config)
> > compiler: powerpc-linux-gcc (GCC) 12.1.0
> > reproduce (this is a W=1 build):
> > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > chmod +x ~/bin/make.cross
> > # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=80b6093b55e31c2c40ff082fb32523d4e852954f
> > git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> > git fetch --no-tags linus master
> > git checkout 80b6093b55e31c2c40ff082fb32523d4e852954f
> > # save the config file
> > mkdir build_dir && cp config build_dir/.config
> > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=powerpc olddefconfig
> > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=powerpc SHELL=/bin/bash arch/powerpc/kernel/ arch/powerpc/kvm/ virt/
> >
> > If you fix the issue, kindly add following tag where applicable
> > | Reported-by: kernel test robot <lkp@intel.com>
> > | Link: https://lore.kernel.org/oe-kbuild-all/202304050954.yskLdczH-lkp@intel.com/
> >
> > All warnings (new ones prefixed by >>):
> >
> > In file included from arch/powerpc/kvm/bookehv_interrupts.S:26:
> > >> arch/powerpc/kvm/../kernel/head_booke.h:20:6: warning: "THREAD_SHIFT" is not defined, evaluates to 0 [-Wundef]
> > 20 | #if (THREAD_SHIFT < 15)
> > | ^~~~~~~~~~~~
>
> Should arch/powerpc/kernel/head_booke.h be #include'ing
> asm/thread_info.h before using THREAD_SHIFT?
I think so, sorry for not cc'ing you on
https://lore.kernel.org/linuxppc-dev/20230406-wundef-thread_shift_booke-v1-1-8deffa4d84f9@kernel.org/
> >
> >
> > vim +/THREAD_SHIFT +20 arch/powerpc/kvm/../kernel/head_booke.h
> >
> > 1a4b739bbb4f88 Christophe Leroy 2019-04-30 10
> > 63dafe5728e735 Becky Bruce 2006-01-14 11 /*
> > 63dafe5728e735 Becky Bruce 2006-01-14 12 * Macros used for common Book-e exception handling
> > 63dafe5728e735 Becky Bruce 2006-01-14 13 */
> > 63dafe5728e735 Becky Bruce 2006-01-14 14
> > 63dafe5728e735 Becky Bruce 2006-01-14 15 #define SET_IVOR(vector_number, vector_label) \
> > 63dafe5728e735 Becky Bruce 2006-01-14 16 li r26,vector_label@l; \
> > 63dafe5728e735 Becky Bruce 2006-01-14 17 mtspr SPRN_IVOR##vector_number,r26; \
> > 63dafe5728e735 Becky Bruce 2006-01-14 18 sync
> > 63dafe5728e735 Becky Bruce 2006-01-14 19
> > e12401222f749c Yuri Tikhonov 2009-01-29 @20 #if (THREAD_SHIFT < 15)
> > e12401222f749c Yuri Tikhonov 2009-01-29 21 #define ALLOC_STACK_FRAME(reg, val) \
> > e12401222f749c Yuri Tikhonov 2009-01-29 22 addi reg,reg,val
> > e12401222f749c Yuri Tikhonov 2009-01-29 23 #else
> > e12401222f749c Yuri Tikhonov 2009-01-29 24 #define ALLOC_STACK_FRAME(reg, val) \
> > e12401222f749c Yuri Tikhonov 2009-01-29 25 addis reg,reg,val@ha; \
> > e12401222f749c Yuri Tikhonov 2009-01-29 26 addi reg,reg,val@l
> > e12401222f749c Yuri Tikhonov 2009-01-29 27 #endif
> > e12401222f749c Yuri Tikhonov 2009-01-29 28
> >
> > :::::: The code at line 20 was first introduced by commit
> > :::::: e12401222f749c37277a313d631dc024bbfd3b00 powerpc/44x: Support for 256KB PAGE_SIZE
> >
> > :::::: TO: Yuri Tikhonov <yur@emcraft.com>
> > :::::: CC: Josh Boyer <jwboyer@linux.vnet.ibm.com>
> >
> > --
> > 0-DAY CI Kernel Test Service
> > https://github.com/intel/lkp-tests
>
>
>
> --
> Thanks,
> ~Nick Desaulniers
prev parent reply other threads:[~2023-04-07 23:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <202304050954.yskLdczH-lkp@intel.com>
2023-04-07 23:08 ` arch/powerpc/kvm/../kernel/head_booke.h:20:6: warning: "THREAD_SHIFT" is not defined, evaluates to 0 Nick Desaulniers
2023-04-07 23:15 ` Nathan Chancellor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230407231500.GA2598451@dev-arch.thelio-3990X \
--to=nathan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lkp@intel.com \
--cc=masahiroy@kernel.org \
--cc=ndesaulniers@google.com \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).