From: Rohan McLure <rmclure@linux.ibm.com>
To: linuxppc-dev@lists.ozlabs.org
Cc: Rohan McLure <rmclure@linux.ibm.com>, npiggin@gmail.com, arnd@arndb.de
Subject: [PATCH 03/12] powerpc: qspinlock: Enforce qnode writes prior to publishing to queue
Date: Mon, 8 May 2023 12:01:11 +1000 [thread overview]
Message-ID: <20230508020120.218494-4-rmclure@linux.ibm.com> (raw)
In-Reply-To: <20230508020120.218494-1-rmclure@linux.ibm.com>
Use a compiler barrier to enforce that all fields of a new struct qnode
be written to (especially the lock value) before publishing the qnode to
the waitqueue.
Signed-off-by: Rohan McLure <rmclure@linux.ibm.com>
---
arch/powerpc/lib/qspinlock.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/powerpc/lib/qspinlock.c b/arch/powerpc/lib/qspinlock.c
index 579290d55abf..d548001a86be 100644
--- a/arch/powerpc/lib/qspinlock.c
+++ b/arch/powerpc/lib/qspinlock.c
@@ -567,6 +567,10 @@ static __always_inline void queued_spin_lock_mcs_queue(struct qspinlock *lock, b
node->cpu = smp_processor_id();
node->yield_cpu = -1;
node->locked = 1;
+ /*
+ * Assign all attributes of a node before it can be published.
+ */
+ barrier();
tail = encode_tail_cpu(node->cpu);
--
2.37.2
next prev parent reply other threads:[~2023-05-08 2:04 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-08 2:01 [PATCH 00/12] powerpc: KCSAN fix warnings and mark accesses Rohan McLure
2023-05-08 2:01 ` [PATCH 01/12] powerpc: qspinlock: Fix qnode->locked value interpretation Rohan McLure
2023-05-09 2:01 ` Nicholas Piggin
2023-05-09 4:26 ` Rohan McLure
2023-05-08 2:01 ` [PATCH 02/12] powerpc: qspinlock: Mark accesses to qnode lock checks Rohan McLure
2023-05-09 2:02 ` Nicholas Piggin
2023-05-08 2:01 ` Rohan McLure [this message]
2023-05-09 2:04 ` [PATCH 03/12] powerpc: qspinlock: Enforce qnode writes prior to publishing to queue Nicholas Piggin
2023-05-09 5:26 ` Rohan McLure
2023-05-09 6:45 ` Nicholas Piggin
2023-05-08 2:01 ` [PATCH 04/12] asm-generic/mmiowb: Mark accesses to fix KCSAN warnings Rohan McLure
2023-05-08 6:30 ` Arnd Bergmann
2023-05-08 15:44 ` [PATCH 4/12] " Gautam Menghani
2023-05-09 2:16 ` [PATCH 04/12] " Nicholas Piggin
2023-05-08 2:01 ` [PATCH 05/12] powerpc: Mark [h]ssr_valid accesses in check_return_regs_valid Rohan McLure
2023-05-09 2:17 ` Nicholas Piggin
2023-05-08 2:01 ` [PATCH 06/12] powerpc: Mark accesses to power_save callback in arch_cpu_idle Rohan McLure
2023-05-09 2:21 ` Nicholas Piggin
2023-05-08 2:01 ` [PATCH 07/12] powerpc: powernv: Fix KCSAN datarace warnings on idle_state contention Rohan McLure
2023-05-09 2:26 ` Nicholas Piggin
2023-05-10 2:00 ` Rohan McLure
2023-05-08 2:01 ` [PATCH 08/12] powerpc: Annotate accesses to ipi message flags Rohan McLure
2023-05-09 2:28 ` Nicholas Piggin
2023-05-08 2:01 ` [PATCH 09/12] powerpc: Mark writes registering ipi to host cpu through kvm Rohan McLure
2023-05-09 2:30 ` Nicholas Piggin
2023-05-08 2:01 ` [PATCH 10/12] powerpc: powernv: Annotate data races in opal events Rohan McLure
2023-05-09 2:31 ` Nicholas Piggin
2023-05-08 2:01 ` [PATCH 11/12] powerpc: powernv: Annotate asynchronous access to opal tokens Rohan McLure
2023-05-08 2:01 ` [PATCH 12/12] powerpc: Mark asynchronous accesses to irq_data Rohan McLure
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230508020120.218494-4-rmclure@linux.ibm.com \
--to=rmclure@linux.ibm.com \
--cc=arnd@arndb.de \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).