From: "Pali Rohár" <pali@kernel.org>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: Sasha Levin <sashal@kernel.org>,
arnd@arndb.de, linus.walleij@linaro.org,
Randy Dunlap <rdunlap@infradead.org>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
andriy.shevchenko@linux.intel.com, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH AUTOSEL 6.3 6/7] powerpc/fsl_uli1575: Allow to disable FSL_ULI1575 support
Date: Tue, 9 May 2023 09:18:35 +0200 [thread overview]
Message-ID: <20230509071835.rrfefrhwtwsxlngy@pali> (raw)
In-Reply-To: <87jzxix9g7.fsf@mail.lhotse>
On Tuesday 09 May 2023 17:14:48 Michael Ellerman wrote:
> Randy Dunlap <rdunlap@infradead.org> writes:
> > Hi--
> >
> > Just a heads up. This patch can cause build errors.
> > I sent a patch for these on 2023-APR-28:
> > https://lore.kernel.org/linuxppc-dev/20230429043519.19807-1-rdunlap@infradead.org/
> >
> > Michael, I think this is your area if I'm not mistaken.
>
> Yes. The fix is in my fixes branch as:
> 536d948a8dee ("powerpc/fsl_uli1575: fix kconfig warnings and build errors")
>
> But I don't think this commit (22fdf79171e8) really warrants going to
> stable, it's a nice-to-have but doesn't fix any pressing bugs.
Exactly. And also this patch alone without 1/8 would not work as in 1/8
https://lore.kernel.org/all/20230409000812.18904-2-pali@kernel.org/ was
added static inline variant of function which is used when ULI is
disabled.
> cheers
>
> > On 5/8/23 20:54, Sasha Levin wrote:
> >> From: Pali Rohár <pali@kernel.org>
> >>
> >> [ Upstream commit 22fdf79171e8509db54599fd2c05ef0022ee83f5 ]
> >>
> >> ULI1575 PCIe south bridge exists only on some Freescale boards. Allow to
> >> disable CONFIG_FSL_ULI1575 symbol when it is not explicitly selected and
> >> only implied. This is achieved by marking symbol as visible by providing
> >> short description. Also adds dependency for this symbol to prevent enabling
> >> it on platforms on which driver does not compile.
> >>
> >> Signed-off-by: Pali Rohár <pali@kernel.org>
> >> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> >> Link: https://msgid.link/20230409000812.18904-7-pali@kernel.org
> >> Signed-off-by: Sasha Levin <sashal@kernel.org>
> >> ---
> >> arch/powerpc/platforms/Kconfig | 4 +++-
> >> 1 file changed, 3 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/arch/powerpc/platforms/Kconfig b/arch/powerpc/platforms/Kconfig
> >> index d41dad227de84..608ac0290e3aa 100644
> >> --- a/arch/powerpc/platforms/Kconfig
> >> +++ b/arch/powerpc/platforms/Kconfig
> >> @@ -261,7 +261,9 @@ config CPM2
> >> on it (826x, 827x, 8560).
> >>
> >> config FSL_ULI1575
> >> - bool
> >> + bool "ULI1575 PCIe south bridge support"
> >> + depends on FSL_SOC_BOOKE || PPC_86xx
> >> + select FSL_PCI
> >> select GENERIC_ISA_DMA
> >> help
> >> Supports for the ULI1575 PCIe south bridge that exists on some
> >
> > --
> > ~Randy
next prev parent reply other threads:[~2023-05-09 7:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-09 3:54 [PATCH AUTOSEL 6.3 1/7] powerpc: Use of_property_present() for testing DT property presence Sasha Levin
2023-05-09 3:54 ` [PATCH AUTOSEL 6.3 6/7] powerpc/fsl_uli1575: Allow to disable FSL_ULI1575 support Sasha Levin
2023-05-09 4:18 ` Randy Dunlap
2023-05-09 7:14 ` Michael Ellerman
2023-05-09 7:18 ` Pali Rohár [this message]
2023-05-18 17:47 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230509071835.rrfefrhwtwsxlngy@pali \
--to=pali@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=rdunlap@infradead.org \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox