* [PATCH v2 RESEND] ASoC: fsl MPC52xx drivers require PPC_BESTCOMM
@ 2023-05-21 22:57 Randy Dunlap
2023-05-30 23:38 ` Randy Dunlap
2023-06-25 13:45 ` Shengjiu Wang
0 siblings, 2 replies; 4+ messages in thread
From: Randy Dunlap @ 2023-05-21 22:57 UTC (permalink / raw)
To: linux-kernel
Cc: alsa-devel, Xiubo Li, linuxppc-dev, Randy Dunlap, Liam Girdwood,
Jaroslav Kysela, Grant Likely, Mark Brown, Takashi Iwai,
Shengjiu Wang
Both SND_MPC52xx_SOC_PCM030 and SND_MPC52xx_SOC_EFIKA select
SND_SOC_MPC5200_AC97. The latter symbol depends on PPC_BESTCOMM,
so the 2 former symbols should also depend on PPC_BESTCOMM since
"select" does not follow any dependency chains.
This prevents a kconfig warning and build errors:
WARNING: unmet direct dependencies detected for SND_SOC_MPC5200_AC97
Depends on [n]: SOUND [=y] && !UML && SND [=m] && SND_SOC [=m] && SND_POWERPC_SOC [=m] && PPC_MPC52xx [=y] && PPC_BESTCOMM [=n]
Selected by [m]:
- SND_MPC52xx_SOC_PCM030 [=m] && SOUND [=y] && !UML && SND [=m] && SND_SOC [=m] && SND_POWERPC_SOC [=m] && PPC_MPC5200_SIMPLE [=y]
- SND_MPC52xx_SOC_EFIKA [=m] && SOUND [=y] && !UML && SND [=m] && SND_SOC [=m] && SND_POWERPC_SOC [=m] && PPC_EFIKA [=y]
ERROR: modpost: "mpc5200_audio_dma_destroy" [sound/soc/fsl/mpc5200_psc_ac97.ko] undefined!
ERROR: modpost: "mpc5200_audio_dma_create" [sound/soc/fsl/mpc5200_psc_ac97.ko] undefined!
Fixes: 40d9ec14e7e1 ("ASoC: remove BROKEN from Efika and pcm030 fabric drivers")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Grant Likely <grant.likely@secretlab.ca>
Cc: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Shengjiu Wang <shengjiu.wang@gmail.com>
Cc: Xiubo Li <Xiubo.Lee@gmail.com>
Cc: alsa-devel@alsa-project.org
Cc: linuxppc-dev@lists.ozlabs.org
Cc: Jaroslav Kysela <perex@perex.cz>
Cc: Takashi Iwai <tiwai@suse.com>
---
v2: use correct email address for Mark Brown.
sound/soc/fsl/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff -- a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig
--- a/sound/soc/fsl/Kconfig
+++ b/sound/soc/fsl/Kconfig
@@ -243,7 +243,7 @@ config SND_SOC_MPC5200_AC97
config SND_MPC52xx_SOC_PCM030
tristate "SoC AC97 Audio support for Phytec pcm030 and WM9712"
- depends on PPC_MPC5200_SIMPLE
+ depends on PPC_MPC5200_SIMPLE && PPC_BESTCOMM
select SND_SOC_MPC5200_AC97
select SND_SOC_WM9712
help
@@ -252,7 +252,7 @@ config SND_MPC52xx_SOC_PCM030
config SND_MPC52xx_SOC_EFIKA
tristate "SoC AC97 Audio support for bbplan Efika and STAC9766"
- depends on PPC_EFIKA
+ depends on PPC_EFIKA && PPC_BESTCOMM
select SND_SOC_MPC5200_AC97
select SND_SOC_STAC9766
help
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 RESEND] ASoC: fsl MPC52xx drivers require PPC_BESTCOMM
2023-05-21 22:57 [PATCH v2 RESEND] ASoC: fsl MPC52xx drivers require PPC_BESTCOMM Randy Dunlap
@ 2023-05-30 23:38 ` Randy Dunlap
2023-06-17 5:08 ` Randy Dunlap
2023-06-25 13:45 ` Shengjiu Wang
1 sibling, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2023-05-30 23:38 UTC (permalink / raw)
To: linux-kernel
Cc: alsa-devel, Xiubo Li, linuxppc-dev, Takashi Iwai, Liam Girdwood,
Jaroslav Kysela, Grant Likely, Mark Brown, Shengjiu Wang
Hello maintainers,
I am still seeing these build errors on linux-next-20230530.
Is there a problem with the patch?
Thanks.
On 5/21/23 15:57, Randy Dunlap wrote:
> Both SND_MPC52xx_SOC_PCM030 and SND_MPC52xx_SOC_EFIKA select
> SND_SOC_MPC5200_AC97. The latter symbol depends on PPC_BESTCOMM,
> so the 2 former symbols should also depend on PPC_BESTCOMM since
> "select" does not follow any dependency chains.
>
> This prevents a kconfig warning and build errors:
>
> WARNING: unmet direct dependencies detected for SND_SOC_MPC5200_AC97
> Depends on [n]: SOUND [=y] && !UML && SND [=m] && SND_SOC [=m] && SND_POWERPC_SOC [=m] && PPC_MPC52xx [=y] && PPC_BESTCOMM [=n]
> Selected by [m]:
> - SND_MPC52xx_SOC_PCM030 [=m] && SOUND [=y] && !UML && SND [=m] && SND_SOC [=m] && SND_POWERPC_SOC [=m] && PPC_MPC5200_SIMPLE [=y]
> - SND_MPC52xx_SOC_EFIKA [=m] && SOUND [=y] && !UML && SND [=m] && SND_SOC [=m] && SND_POWERPC_SOC [=m] && PPC_EFIKA [=y]
>
> ERROR: modpost: "mpc5200_audio_dma_destroy" [sound/soc/fsl/mpc5200_psc_ac97.ko] undefined!
> ERROR: modpost: "mpc5200_audio_dma_create" [sound/soc/fsl/mpc5200_psc_ac97.ko] undefined!
>
> Fixes: 40d9ec14e7e1 ("ASoC: remove BROKEN from Efika and pcm030 fabric drivers")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Grant Likely <grant.likely@secretlab.ca>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Liam Girdwood <lgirdwood@gmail.com>
> Cc: Shengjiu Wang <shengjiu.wang@gmail.com>
> Cc: Xiubo Li <Xiubo.Lee@gmail.com>
> Cc: alsa-devel@alsa-project.org
> Cc: linuxppc-dev@lists.ozlabs.org
> Cc: Jaroslav Kysela <perex@perex.cz>
> Cc: Takashi Iwai <tiwai@suse.com>
> ---
> v2: use correct email address for Mark Brown.
>
> sound/soc/fsl/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff -- a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig
> --- a/sound/soc/fsl/Kconfig
> +++ b/sound/soc/fsl/Kconfig
> @@ -243,7 +243,7 @@ config SND_SOC_MPC5200_AC97
>
> config SND_MPC52xx_SOC_PCM030
> tristate "SoC AC97 Audio support for Phytec pcm030 and WM9712"
> - depends on PPC_MPC5200_SIMPLE
> + depends on PPC_MPC5200_SIMPLE && PPC_BESTCOMM
> select SND_SOC_MPC5200_AC97
> select SND_SOC_WM9712
> help
> @@ -252,7 +252,7 @@ config SND_MPC52xx_SOC_PCM030
>
> config SND_MPC52xx_SOC_EFIKA
> tristate "SoC AC97 Audio support for bbplan Efika and STAC9766"
> - depends on PPC_EFIKA
> + depends on PPC_EFIKA && PPC_BESTCOMM
> select SND_SOC_MPC5200_AC97
> select SND_SOC_STAC9766
> help
--
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 RESEND] ASoC: fsl MPC52xx drivers require PPC_BESTCOMM
2023-05-30 23:38 ` Randy Dunlap
@ 2023-06-17 5:08 ` Randy Dunlap
0 siblings, 0 replies; 4+ messages in thread
From: Randy Dunlap @ 2023-06-17 5:08 UTC (permalink / raw)
To: linux-kernel
Cc: alsa-devel, Xiubo Li, linuxppc-dev, Takashi Iwai, Liam Girdwood,
Jaroslav Kysela, Grant Likely, Mark Brown, Shengjiu Wang
Hi Mark, Liam,
On 5/30/23 16:38, Randy Dunlap wrote:
> Hello maintainers,
>
> I am still seeing these build errors on linux-next-20230530.
>
> Is there a problem with the patch?
> Thanks.
>
I am still seeing build errors on linux-next-20230615.
Is there a problem with the patch?
Can it be applied/merged?
Thanks.
> On 5/21/23 15:57, Randy Dunlap wrote:
>> Both SND_MPC52xx_SOC_PCM030 and SND_MPC52xx_SOC_EFIKA select
>> SND_SOC_MPC5200_AC97. The latter symbol depends on PPC_BESTCOMM,
>> so the 2 former symbols should also depend on PPC_BESTCOMM since
>> "select" does not follow any dependency chains.
>>
>> This prevents a kconfig warning and build errors:
>>
>> WARNING: unmet direct dependencies detected for SND_SOC_MPC5200_AC97
>> Depends on [n]: SOUND [=y] && !UML && SND [=m] && SND_SOC [=m] && SND_POWERPC_SOC [=m] && PPC_MPC52xx [=y] && PPC_BESTCOMM [=n]
>> Selected by [m]:
>> - SND_MPC52xx_SOC_PCM030 [=m] && SOUND [=y] && !UML && SND [=m] && SND_SOC [=m] && SND_POWERPC_SOC [=m] && PPC_MPC5200_SIMPLE [=y]
>> - SND_MPC52xx_SOC_EFIKA [=m] && SOUND [=y] && !UML && SND [=m] && SND_SOC [=m] && SND_POWERPC_SOC [=m] && PPC_EFIKA [=y]
>>
>> ERROR: modpost: "mpc5200_audio_dma_destroy" [sound/soc/fsl/mpc5200_psc_ac97.ko] undefined!
>> ERROR: modpost: "mpc5200_audio_dma_create" [sound/soc/fsl/mpc5200_psc_ac97.ko] undefined!
>>
>> Fixes: 40d9ec14e7e1 ("ASoC: remove BROKEN from Efika and pcm030 fabric drivers")
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Cc: Grant Likely <grant.likely@secretlab.ca>
>> Cc: Mark Brown <broonie@kernel.org>
>> Cc: Liam Girdwood <lgirdwood@gmail.com>
>> Cc: Shengjiu Wang <shengjiu.wang@gmail.com>
>> Cc: Xiubo Li <Xiubo.Lee@gmail.com>
>> Cc: alsa-devel@alsa-project.org
>> Cc: linuxppc-dev@lists.ozlabs.org
>> Cc: Jaroslav Kysela <perex@perex.cz>
>> Cc: Takashi Iwai <tiwai@suse.com>
>> ---
>> v2: use correct email address for Mark Brown.
>>
>> sound/soc/fsl/Kconfig | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff -- a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig
>> --- a/sound/soc/fsl/Kconfig
>> +++ b/sound/soc/fsl/Kconfig
>> @@ -243,7 +243,7 @@ config SND_SOC_MPC5200_AC97
>>
>> config SND_MPC52xx_SOC_PCM030
>> tristate "SoC AC97 Audio support for Phytec pcm030 and WM9712"
>> - depends on PPC_MPC5200_SIMPLE
>> + depends on PPC_MPC5200_SIMPLE && PPC_BESTCOMM
>> select SND_SOC_MPC5200_AC97
>> select SND_SOC_WM9712
>> help
>> @@ -252,7 +252,7 @@ config SND_MPC52xx_SOC_PCM030
>>
>> config SND_MPC52xx_SOC_EFIKA
>> tristate "SoC AC97 Audio support for bbplan Efika and STAC9766"
>> - depends on PPC_EFIKA
>> + depends on PPC_EFIKA && PPC_BESTCOMM
>> select SND_SOC_MPC5200_AC97
>> select SND_SOC_STAC9766
>> help
>
--
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 RESEND] ASoC: fsl MPC52xx drivers require PPC_BESTCOMM
2023-05-21 22:57 [PATCH v2 RESEND] ASoC: fsl MPC52xx drivers require PPC_BESTCOMM Randy Dunlap
2023-05-30 23:38 ` Randy Dunlap
@ 2023-06-25 13:45 ` Shengjiu Wang
1 sibling, 0 replies; 4+ messages in thread
From: Shengjiu Wang @ 2023-06-25 13:45 UTC (permalink / raw)
To: Randy Dunlap
Cc: alsa-devel, Xiubo Li, Takashi Iwai, linux-kernel, Liam Girdwood,
Grant Likely, Mark Brown, Jaroslav Kysela, linuxppc-dev
[-- Attachment #1: Type: text/plain, Size: 2641 bytes --]
On Mon, May 22, 2023 at 6:57 AM Randy Dunlap <rdunlap@infradead.org> wrote:
> Both SND_MPC52xx_SOC_PCM030 and SND_MPC52xx_SOC_EFIKA select
> SND_SOC_MPC5200_AC97. The latter symbol depends on PPC_BESTCOMM,
> so the 2 former symbols should also depend on PPC_BESTCOMM since
> "select" does not follow any dependency chains.
>
> This prevents a kconfig warning and build errors:
>
> WARNING: unmet direct dependencies detected for SND_SOC_MPC5200_AC97
> Depends on [n]: SOUND [=y] && !UML && SND [=m] && SND_SOC [=m] &&
> SND_POWERPC_SOC [=m] && PPC_MPC52xx [=y] && PPC_BESTCOMM [=n]
> Selected by [m]:
> - SND_MPC52xx_SOC_PCM030 [=m] && SOUND [=y] && !UML && SND [=m] &&
> SND_SOC [=m] && SND_POWERPC_SOC [=m] && PPC_MPC5200_SIMPLE [=y]
> - SND_MPC52xx_SOC_EFIKA [=m] && SOUND [=y] && !UML && SND [=m] &&
> SND_SOC [=m] && SND_POWERPC_SOC [=m] && PPC_EFIKA [=y]
>
> ERROR: modpost: "mpc5200_audio_dma_destroy"
> [sound/soc/fsl/mpc5200_psc_ac97.ko] undefined!
> ERROR: modpost: "mpc5200_audio_dma_create"
> [sound/soc/fsl/mpc5200_psc_ac97.ko] undefined!
>
> Fixes: 40d9ec14e7e1 ("ASoC: remove BROKEN from Efika and pcm030 fabric
> drivers")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Grant Likely <grant.likely@secretlab.ca>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Liam Girdwood <lgirdwood@gmail.com>
> Cc: Shengjiu Wang <shengjiu.wang@gmail.com>
> Cc: Xiubo Li <Xiubo.Lee@gmail.com>
> Cc: alsa-devel@alsa-project.org
> Cc: linuxppc-dev@lists.ozlabs.org
> Cc: Jaroslav Kysela <perex@perex.cz>
> Cc: Takashi Iwai <tiwai@suse.com>
>
Acked-by: Shengjiu Wang <shengjiu.wang@gmail.com>
Best regards
Wang shengjiu
> ---
> v2: use correct email address for Mark Brown.
>
> sound/soc/fsl/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff -- a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig
> --- a/sound/soc/fsl/Kconfig
> +++ b/sound/soc/fsl/Kconfig
> @@ -243,7 +243,7 @@ config SND_SOC_MPC5200_AC97
>
> config SND_MPC52xx_SOC_PCM030
> tristate "SoC AC97 Audio support for Phytec pcm030 and WM9712"
> - depends on PPC_MPC5200_SIMPLE
> + depends on PPC_MPC5200_SIMPLE && PPC_BESTCOMM
> select SND_SOC_MPC5200_AC97
> select SND_SOC_WM9712
> help
> @@ -252,7 +252,7 @@ config SND_MPC52xx_SOC_PCM030
>
> config SND_MPC52xx_SOC_EFIKA
> tristate "SoC AC97 Audio support for bbplan Efika and STAC9766"
> - depends on PPC_EFIKA
> + depends on PPC_EFIKA && PPC_BESTCOMM
> select SND_SOC_MPC5200_AC97
> select SND_SOC_STAC9766
> help
>
[-- Attachment #2: Type: text/html, Size: 4192 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-06-25 22:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-21 22:57 [PATCH v2 RESEND] ASoC: fsl MPC52xx drivers require PPC_BESTCOMM Randy Dunlap
2023-05-30 23:38 ` Randy Dunlap
2023-06-17 5:08 ` Randy Dunlap
2023-06-25 13:45 ` Shengjiu Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).