From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
To: Gaurav Batra <gbatra@linux.vnet.ibm.com>
Cc: brking@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org,
gjoyce@linux.vnet.ibm.com
Subject: Re: [PATCH v3] powerpc/iommu: DMA address offset is incorrectly calculated with 2MB TCEs
Date: Mon, 22 May 2023 12:57:56 +0530 [thread overview]
Message-ID: <20230522072756.GA416000@linux.vnet.ibm.com> (raw)
In-Reply-To: <20230504175913.83844-1-gbatra@linux.vnet.ibm.com>
* Gaurav Batra <gbatra@linux.vnet.ibm.com> [2023-05-04 12:59:13]:
> When DMA window is backed by 2MB TCEs, the DMA address for the mapped
> page should be the offset of the page relative to the 2MB TCE. The code
> was incorrectly setting the DMA address to the beginning of the TCE
> range.
>
> Mellanox driver is reporting timeout trying to ENABLE_HCA for an SR-IOV
> ethernet port, when DMA window is backed by 2MB TCEs.
>
> Fixes: 387273118714 ("powerps/pseries/dma: Add support for 2M IOMMU page size")
>
> Signed-off-by: Gaurav Batra <gbatra@linux.vnet.ibm.com>
>
Works with this patch.
Tested-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
> Reviewed-by: Greg Joyce <gjoyce@linux.vnet.ibm.com>
> Reviewed-by: Brian King <brking@linux.vnet.ibm.com>
> ---
--
Thanks and Regards
Srikar Dronamraju
next prev parent reply other threads:[~2023-05-22 7:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-04 17:59 [PATCH v3] powerpc/iommu: DMA address offset is incorrectly calculated with 2MB TCEs Gaurav Batra
2023-05-22 7:27 ` Srikar Dronamraju [this message]
2023-07-03 5:21 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230522072756.GA416000@linux.vnet.ibm.com \
--to=srikar@linux.vnet.ibm.com \
--cc=brking@linux.vnet.ibm.com \
--cc=gbatra@linux.vnet.ibm.com \
--cc=gjoyce@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).