From: Steven Rostedt <rostedt@goodmis.org>
To: Naveen N Rao <naveen@kernel.org>
Cc: "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
Nicholas Piggin <npiggin@gmail.com>
Subject: Re: [RFC PATCH] powerpc/ftrace: Refactoring and support for -fpatchable-function-entry
Date: Tue, 23 May 2023 09:20:13 -0400 [thread overview]
Message-ID: <20230523092013.5a0b03d8@rorschach.local.home> (raw)
In-Reply-To: <1684606745.vlpj5zhydx.naveen@kernel.org>
On Sat, 20 May 2023 23:58:01 +0530
Naveen N Rao <naveen@kernel.org> wrote:
> >
> > At the begining of ftrace_replace_code(), don't you miss:
> >
> > if (unlikely(ftrace_disabled))
> > return;
>
> ftrace_disabled is a static, so it can't be tested here. FWIW, x86 also
> implements ftrace_replace_code(), and doesn't test ftrace_disabled.
>
> Looking at the call path, it looks like it gets tested much before, so
> may not be necessary. It sure would be good to get Steven's view on
> this.
Yes, ftrace_disabled should not be used in arch code. It should be
caught before then.
Thanks,
-- Steve
prev parent reply other threads:[~2023-05-23 13:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-19 19:26 [RFC PATCH] powerpc/ftrace: Refactoring and support for -fpatchable-function-entry Naveen N Rao
2023-05-20 10:34 ` Christophe Leroy
2023-05-20 16:28 ` Christophe Leroy
2023-05-20 17:48 ` Christophe Leroy
2023-05-20 18:17 ` Naveen N Rao
2023-05-21 9:14 ` Christophe Leroy
2023-05-23 9:31 ` Naveen N Rao
2023-05-26 5:35 ` Christophe Leroy
2023-06-07 17:05 ` Naveen N Rao
2023-05-20 18:28 ` Naveen N Rao
2023-05-23 13:20 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230523092013.5a0b03d8@rorschach.local.home \
--to=rostedt@goodmis.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=naveen@kernel.org \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).