From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7C7E5C77B75 for ; Tue, 23 May 2023 13:20:49 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4QQZgz4Glrz3f4l for ; Tue, 23 May 2023 23:20:47 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=2604:1380:4641:c500::1; helo=dfw.source.kernel.org; envelope-from=srs0=q/om=bm=goodmis.org=rostedt@kernel.org; receiver=) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4QQZgR6T2Kz3cdD for ; Tue, 23 May 2023 23:20:19 +1000 (AEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3F54560B60; Tue, 23 May 2023 13:20:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 46538C433EF; Tue, 23 May 2023 13:20:15 +0000 (UTC) Date: Tue, 23 May 2023 09:20:13 -0400 From: Steven Rostedt To: Naveen N Rao Subject: Re: [RFC PATCH] powerpc/ftrace: Refactoring and support for -fpatchable-function-entry Message-ID: <20230523092013.5a0b03d8@rorschach.local.home> In-Reply-To: <1684606745.vlpj5zhydx.naveen@kernel.org> References: <20230519192600.2593506-1-naveen@kernel.org> <3527b8d2-275e-29d8-fd3b-4002a4a901fd@csgroup.eu> <1684606745.vlpj5zhydx.naveen@kernel.org> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linuxppc-dev@lists.ozlabs.org" , Nicholas Piggin Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Sat, 20 May 2023 23:58:01 +0530 Naveen N Rao wrote: > > > > At the begining of ftrace_replace_code(), don't you miss: > > > > if (unlikely(ftrace_disabled)) > > return; > > ftrace_disabled is a static, so it can't be tested here. FWIW, x86 also > implements ftrace_replace_code(), and doesn't test ftrace_disabled. > > Looking at the call path, it looks like it gets tested much before, so > may not be necessary. It sure would be good to get Steven's view on > this. Yes, ftrace_disabled should not be used in arch code. It should be caught before then. Thanks, -- Steve