[PATCH 0/2] Fix COMPILE_TEST dependencies for CPM uart, TSA and QMC

linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed

* [PATCH 0/2] Fix COMPILE_TEST dependencies for CPM uart, TSA and QMC
@ 2023-05-22  8:20 Herve Codina
  2023-05-22  8:20 ` [PATCH 1/2] soc: fsl: cpm1: Fix TSA and QMC dependencies in case of COMPILE_TEST Herve Codina
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Herve Codina @ 2023-05-22  8:20 UTC (permalink / raw)
  To: Herve Codina, Qiang Zhao, Li Yang, Greg Kroah-Hartman, Jiri Slaby
  Cc: Thomas Petazzoni, linux-kernel, Mark Brown, linux-serial,
	linuxppc-dev, linux-arm-kernel

This series fixes issues raised by the kernel test robot
  https://lore.kernel.org/oe-kbuild-all/202305160221.9XgweObz-lkp@intel.com/

In COMPILE_TEST configurations, TSA and QMC need CONFIG_CPM to be set in
order to compile and CPM uart needs CONFIG_CPM2.

Best regards,
Hervé

Herve Codina (2):
  soc: fsl: cpm1: Fix TSA and QMC dependencies in case of COMPILE_TEST
  serial: cpm_uart: Fix a COMPILE_TEST dependency

 drivers/soc/fsl/qe/Kconfig | 4 ++--
 drivers/tty/serial/Kconfig | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

-- 
2.40.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 1/2] soc: fsl: cpm1: Fix TSA and QMC dependencies in case of COMPILE_TEST
  2023-05-22  8:20 [PATCH 0/2] Fix COMPILE_TEST dependencies for CPM uart, TSA and QMC Herve Codina
@ 2023-05-22  8:20 ` Herve Codina
  2023-05-22  8:20 ` [PATCH 2/2] serial: cpm_uart: Fix a COMPILE_TEST dependency Herve Codina
  2023-05-23  7:48 ` [PATCH 0/2] Fix COMPILE_TEST dependencies for CPM uart, TSA and QMC Jiri Slaby
  2 siblings, 0 replies; 6+ messages in thread
From: Herve Codina @ 2023-05-22  8:20 UTC (permalink / raw)
  To: Herve Codina, Qiang Zhao, Li Yang, Greg Kroah-Hartman, Jiri Slaby
  Cc: Thomas Petazzoni, linux-kernel, Mark Brown, linux-serial,
	linuxppc-dev, linux-arm-kernel, kernel test robot

In order to compile tsa.c and qmc.c, CONFIG_CPM must be set.

Without this dependency, the linker fails with some missing
symbols for COMPILE_TEST configurations that need QMC without
enabling CPM.

Signed-off-by: Herve Codina <herve.codina@bootlin.com>
Reported-by: kernel test robot <lkp@intel.com>
Link: https://lore.kernel.org/oe-kbuild-all/202305160221.9XgweObz-lkp@intel.com/
---
 drivers/soc/fsl/qe/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/soc/fsl/qe/Kconfig b/drivers/soc/fsl/qe/Kconfig
index 7268c2fbcbc1..e0d096607fef 100644
--- a/drivers/soc/fsl/qe/Kconfig
+++ b/drivers/soc/fsl/qe/Kconfig
@@ -36,7 +36,7 @@ config UCC
 config CPM_TSA
 	tristate "CPM TSA support"
 	depends on OF && HAS_IOMEM
-	depends on CPM1 || COMPILE_TEST
+	depends on CPM1 || (CPM && COMPILE_TEST)
 	help
 	  Freescale CPM Time Slot Assigner (TSA)
 	  controller.
@@ -47,7 +47,7 @@ config CPM_TSA
 config CPM_QMC
 	tristate "CPM QMC support"
 	depends on OF && HAS_IOMEM
-	depends on CPM1 || (FSL_SOC && COMPILE_TEST)
+	depends on CPM1 || (FSL_SOC && CPM && COMPILE_TEST)
 	depends on CPM_TSA
 	help
 	  Freescale CPM QUICC Multichannel Controller
-- 
2.40.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 2/2] serial: cpm_uart: Fix a COMPILE_TEST dependency
  2023-05-22  8:20 [PATCH 0/2] Fix COMPILE_TEST dependencies for CPM uart, TSA and QMC Herve Codina
  2023-05-22  8:20 ` [PATCH 1/2] soc: fsl: cpm1: Fix TSA and QMC dependencies in case of COMPILE_TEST Herve Codina
@ 2023-05-22  8:20 ` Herve Codina
  2023-05-23  7:52   ` Jiri Slaby
  2023-05-23  7:48 ` [PATCH 0/2] Fix COMPILE_TEST dependencies for CPM uart, TSA and QMC Jiri Slaby
  2 siblings, 1 reply; 6+ messages in thread
From: Herve Codina @ 2023-05-22  8:20 UTC (permalink / raw)
  To: Herve Codina, Qiang Zhao, Li Yang, Greg Kroah-Hartman, Jiri Slaby
  Cc: Thomas Petazzoni, linux-kernel, Mark Brown, linux-serial,
	linuxppc-dev, linux-arm-kernel, kernel test robot

In a COMPILE_TEST configuration, the cpm_uart driver uses symbols from
the cpm_uart_cpm2.c file. This file is compiled only when CONFIG_CPM2 is
set.

Without this dependency, the linker fails with some missing symbols for
COMPILE_TEST configuration that needs SERIAL_CPM without enabling CPM2.

Signed-off-by: Herve Codina <herve.codina@bootlin.com>
Reported-by: kernel test robot <lkp@intel.com>
Link: https://lore.kernel.org/oe-kbuild-all/202305160221.9XgweObz-lkp@intel.com/
Fixes: e3e7b13bffae ("serial: allow COMPILE_TEST for some drivers")
---
 drivers/tty/serial/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
index 625358f44419..68a9d9db9144 100644
--- a/drivers/tty/serial/Kconfig
+++ b/drivers/tty/serial/Kconfig
@@ -769,7 +769,7 @@ config SERIAL_PMACZILOG_CONSOLE
 
 config SERIAL_CPM
 	tristate "CPM SCC/SMC serial port support"
-	depends on CPM2 || CPM1 || (PPC32 && COMPILE_TEST)
+	depends on CPM2 || CPM1 || (PPC32 && CPM2 && COMPILE_TEST)
 	select SERIAL_CORE
 	help
 	  This driver supports the SCC and SMC serial ports on Motorola 
-- 
2.40.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/2] serial: cpm_uart: Fix a COMPILE_TEST dependency
  2023-05-22  8:20 ` [PATCH 2/2] serial: cpm_uart: Fix a COMPILE_TEST dependency Herve Codina
@ 2023-05-23  7:52   ` Jiri Slaby
  2023-05-23  8:36     ` Herve Codina
  0 siblings, 1 reply; 6+ messages in thread
From: Jiri Slaby @ 2023-05-23  7:52 UTC (permalink / raw)
  To: Herve Codina, Qiang Zhao, Li Yang, Greg Kroah-Hartman
  Cc: Thomas Petazzoni, linux-kernel, Mark Brown, linux-serial,
	linuxppc-dev, linux-arm-kernel, kernel test robot

On 22. 05. 23, 10:20, Herve Codina wrote:
> In a COMPILE_TEST configuration, the cpm_uart driver uses symbols from
> the cpm_uart_cpm2.c file. This file is compiled only when CONFIG_CPM2 is
> set.
> 
> Without this dependency, the linker fails with some missing symbols for
> COMPILE_TEST configuration that needs SERIAL_CPM without enabling CPM2.
> 
> Signed-off-by: Herve Codina <herve.codina@bootlin.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Link: https://lore.kernel.org/oe-kbuild-all/202305160221.9XgweObz-lkp@intel.com/
> Fixes: e3e7b13bffae ("serial: allow COMPILE_TEST for some drivers")
> ---
>   drivers/tty/serial/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> index 625358f44419..68a9d9db9144 100644
> --- a/drivers/tty/serial/Kconfig
> +++ b/drivers/tty/serial/Kconfig
> @@ -769,7 +769,7 @@ config SERIAL_PMACZILOG_CONSOLE
>   
>   config SERIAL_CPM
>   	tristate "CPM SCC/SMC serial port support"
> -	depends on CPM2 || CPM1 || (PPC32 && COMPILE_TEST)
> +	depends on CPM2 || CPM1 || (PPC32 && CPM2 && COMPILE_TEST)

Actually, does this makes sense? I mean, the last part after "||" is now 
superfluous and doesn't help anything, right?

>   	select SERIAL_CORE
>   	help
>   	  This driver supports the SCC and SMC serial ports on Motorola

-- 
js


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/2] serial: cpm_uart: Fix a COMPILE_TEST dependency
  2023-05-23  7:52   ` Jiri Slaby
@ 2023-05-23  8:36     ` Herve Codina
  0 siblings, 0 replies; 6+ messages in thread
From: Herve Codina @ 2023-05-23  8:36 UTC (permalink / raw)
  To: Jiri Slaby
  Cc: Thomas Petazzoni, Greg Kroah-Hartman, linux-kernel, Li Yang,
	kernel test robot, Mark Brown, linux-serial, linuxppc-dev,
	linux-arm-kernel, Qiang Zhao

On Tue, 23 May 2023 09:52:00 +0200
Jiri Slaby <jirislaby@kernel.org> wrote:

> On 22. 05. 23, 10:20, Herve Codina wrote:
> > In a COMPILE_TEST configuration, the cpm_uart driver uses symbols from
> > the cpm_uart_cpm2.c file. This file is compiled only when CONFIG_CPM2 is
> > set.
> > 
> > Without this dependency, the linker fails with some missing symbols for
> > COMPILE_TEST configuration that needs SERIAL_CPM without enabling CPM2.
> > 
> > Signed-off-by: Herve Codina <herve.codina@bootlin.com>
> > Reported-by: kernel test robot <lkp@intel.com>
> > Link: https://lore.kernel.org/oe-kbuild-all/202305160221.9XgweObz-lkp@intel.com/
> > Fixes: e3e7b13bffae ("serial: allow COMPILE_TEST for some drivers")
> > ---
> >   drivers/tty/serial/Kconfig | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> > index 625358f44419..68a9d9db9144 100644
> > --- a/drivers/tty/serial/Kconfig
> > +++ b/drivers/tty/serial/Kconfig
> > @@ -769,7 +769,7 @@ config SERIAL_PMACZILOG_CONSOLE
> >   
> >   config SERIAL_CPM
> >   	tristate "CPM SCC/SMC serial port support"
> > -	depends on CPM2 || CPM1 || (PPC32 && COMPILE_TEST)
> > +	depends on CPM2 || CPM1 || (PPC32 && CPM2 && COMPILE_TEST)  
> 
> Actually, does this makes sense? I mean, the last part after "||" is now 
> superfluous and doesn't help anything, right?

Indeed, I will remove all the (PPC32 && CPM2 && COMPILE_TEST) in the next
iteration.
I will also remove the '#elif defined(CONFIG_COMPILE_TEST)' case in the
cpm_uart.h file.

Best regards,
Hervé

> 
> >   	select SERIAL_CORE
> >   	help
> >   	  This driver supports the SCC and SMC serial ports on Motorola  
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 0/2] Fix COMPILE_TEST dependencies for CPM uart, TSA and QMC
  2023-05-22  8:20 [PATCH 0/2] Fix COMPILE_TEST dependencies for CPM uart, TSA and QMC Herve Codina
  2023-05-22  8:20 ` [PATCH 1/2] soc: fsl: cpm1: Fix TSA and QMC dependencies in case of COMPILE_TEST Herve Codina
  2023-05-22  8:20 ` [PATCH 2/2] serial: cpm_uart: Fix a COMPILE_TEST dependency Herve Codina
@ 2023-05-23  7:48 ` Jiri Slaby
  2 siblings, 0 replies; 6+ messages in thread
From: Jiri Slaby @ 2023-05-23  7:48 UTC (permalink / raw)
  To: Herve Codina, Qiang Zhao, Li Yang, Greg Kroah-Hartman
  Cc: Thomas Petazzoni, linux-kernel, Mark Brown, linux-serial,
	linuxppc-dev, linux-arm-kernel

On 22. 05. 23, 10:20, Herve Codina wrote:
> This series fixes issues raised by the kernel test robot
>    https://lore.kernel.org/oe-kbuild-all/202305160221.9XgweObz-lkp@intel.com/
> 
> In COMPILE_TEST configurations, TSA and QMC need CONFIG_CPM to be set in
> order to compile and CPM uart needs CONFIG_CPM2.

Ah, perfect. Greg, please disregard my revert posted at:
   https://lore.kernel.org/all/20230518055620.29957-1-jirislaby@kernel.org/

and take these instead.

Thanks.

> Best regards,
> Hervé
> 
> Herve Codina (2):
>    soc: fsl: cpm1: Fix TSA and QMC dependencies in case of COMPILE_TEST
>    serial: cpm_uart: Fix a COMPILE_TEST dependency
> 
>   drivers/soc/fsl/qe/Kconfig | 4 ++--
>   drivers/tty/serial/Kconfig | 2 +-
>   2 files changed, 3 insertions(+), 3 deletions(-)
> 

-- 
js


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2023-05-23  8:38 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-22  8:20 [PATCH 0/2] Fix COMPILE_TEST dependencies for CPM uart, TSA and QMC Herve Codina
2023-05-22  8:20 ` [PATCH 1/2] soc: fsl: cpm1: Fix TSA and QMC dependencies in case of COMPILE_TEST Herve Codina
2023-05-22  8:20 ` [PATCH 2/2] serial: cpm_uart: Fix a COMPILE_TEST dependency Herve Codina
2023-05-23  7:52   ` Jiri Slaby
2023-05-23  8:36     ` Herve Codina
2023-05-23  7:48 ` [PATCH 0/2] Fix COMPILE_TEST dependencies for CPM uart, TSA and QMC Jiri Slaby

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).