* [PATCH] sound: Switch i2c drivers back to use .probe()
@ 2023-05-25 20:36 Uwe Kleine-König
2023-05-25 20:52 ` Luca Ceresoli
2023-06-05 7:24 ` Takashi Iwai
0 siblings, 2 replies; 3+ messages in thread
From: Uwe Kleine-König @ 2023-05-25 20:36 UTC (permalink / raw)
To: Jaroslav Kysela, Takashi Iwai
Cc: alsa-devel, Corey Minyard, Benjamin Mugnier, Vladimir Oltean,
Lucas Tanure, Peter Senna Tschudin, Greg Kroah-Hartman,
Dmitry Torokhov, Sebastian Reichel, Andy Shevchenko, David Rhodes,
Wolfram Sang, linuxppc-dev, Richard Fitzgerald,
Krzysztof Hałasa, Adrien Grassein, kernel, patches,
Johannes Berg, James Schulman, Luca Ceresoli
After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new()
call-back type"), all drivers being converted to .probe_new() and then
03c835f498b5 ("i2c: Switch .probe() to not take an id parameter") convert
back to (the new) .probe() to be able to eventually drop .probe_new() from
struct i2c_driver.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
sound/aoa/codecs/onyx.c | 2 +-
sound/aoa/codecs/tas.c | 2 +-
sound/pci/hda/cs35l41_hda_i2c.c | 2 +-
sound/ppc/keywest.c | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/sound/aoa/codecs/onyx.c b/sound/aoa/codecs/onyx.c
index 4c75381f5ab8..a8a59d71dcec 100644
--- a/sound/aoa/codecs/onyx.c
+++ b/sound/aoa/codecs/onyx.c
@@ -1048,7 +1048,7 @@ static struct i2c_driver onyx_driver = {
.driver = {
.name = "aoa_codec_onyx",
},
- .probe_new = onyx_i2c_probe,
+ .probe = onyx_i2c_probe,
.remove = onyx_i2c_remove,
.id_table = onyx_i2c_id,
};
diff --git a/sound/aoa/codecs/tas.c b/sound/aoa/codecs/tas.c
index f906e9aaddcf..ab1472390061 100644
--- a/sound/aoa/codecs/tas.c
+++ b/sound/aoa/codecs/tas.c
@@ -936,7 +936,7 @@ static struct i2c_driver tas_driver = {
.driver = {
.name = "aoa_codec_tas",
},
- .probe_new = tas_i2c_probe,
+ .probe = tas_i2c_probe,
.remove = tas_i2c_remove,
.id_table = tas_i2c_id,
};
diff --git a/sound/pci/hda/cs35l41_hda_i2c.c b/sound/pci/hda/cs35l41_hda_i2c.c
index 7826b1a12d7d..b44536fbba17 100644
--- a/sound/pci/hda/cs35l41_hda_i2c.c
+++ b/sound/pci/hda/cs35l41_hda_i2c.c
@@ -58,7 +58,7 @@ static struct i2c_driver cs35l41_i2c_driver = {
.pm = &cs35l41_hda_pm_ops,
},
.id_table = cs35l41_hda_i2c_id,
- .probe_new = cs35l41_hda_i2c_probe,
+ .probe = cs35l41_hda_i2c_probe,
.remove = cs35l41_hda_i2c_remove,
};
module_i2c_driver(cs35l41_i2c_driver);
diff --git a/sound/ppc/keywest.c b/sound/ppc/keywest.c
index 0c4f43963c75..dfc1fc9b701d 100644
--- a/sound/ppc/keywest.c
+++ b/sound/ppc/keywest.c
@@ -90,7 +90,7 @@ static struct i2c_driver keywest_driver = {
.driver = {
.name = "PMac Keywest Audio",
},
- .probe_new = keywest_probe,
+ .probe = keywest_probe,
.remove = keywest_remove,
.id_table = keywest_i2c_id,
};
base-commit: ac9a78681b921877518763ba0e89202254349d1b
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] sound: Switch i2c drivers back to use .probe()
2023-05-25 20:36 [PATCH] sound: Switch i2c drivers back to use .probe() Uwe Kleine-König
@ 2023-05-25 20:52 ` Luca Ceresoli
2023-06-05 7:24 ` Takashi Iwai
1 sibling, 0 replies; 3+ messages in thread
From: Luca Ceresoli @ 2023-05-25 20:52 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Corey Minyard, alsa-devel, Lucas Tanure, Peter Senna Tschudin,
Benjamin Mugnier, Jaroslav Kysela, Sebastian Reichel,
Adrien Grassein, linuxppc-dev, James Schulman, Richard Fitzgerald,
Krzysztof Hałasa, Andy Shevchenko, Greg Kroah-Hartman,
Dmitry Torokhov, Takashi Iwai, Wolfram Sang, kernel, patches,
Johannes Berg, Vladimir Oltean, David Rhodes
Hi Uwe,
On Thu, 25 May 2023 22:36:40 +0200
Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:
> After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new()
> call-back type"), all drivers being converted to .probe_new() and then
> 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter") convert
> back to (the new) .probe() to be able to eventually drop .probe_new() from
> struct i2c_driver.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] sound: Switch i2c drivers back to use .probe()
2023-05-25 20:36 [PATCH] sound: Switch i2c drivers back to use .probe() Uwe Kleine-König
2023-05-25 20:52 ` Luca Ceresoli
@ 2023-06-05 7:24 ` Takashi Iwai
1 sibling, 0 replies; 3+ messages in thread
From: Takashi Iwai @ 2023-06-05 7:24 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Corey Minyard, alsa-devel, Lucas Tanure, Peter Senna Tschudin,
Benjamin Mugnier, Jaroslav Kysela, Sebastian Reichel,
Adrien Grassein, Luca Ceresoli, James Schulman,
Richard Fitzgerald, Krzysztof Hałasa, Andy Shevchenko,
Greg Kroah-Hartman, David Rhodes, Dmitry Torokhov, Takashi Iwai,
Wolfram Sang, kernel, patches, Johannes Berg, Vladimir Oltean,
linuxppc-dev
On Thu, 25 May 2023 22:36:40 +0200,
Uwe Kleine-König wrote:
>
> After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new()
> call-back type"), all drivers being converted to .probe_new() and then
> 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter") convert
> back to (the new) .probe() to be able to eventually drop .probe_new() from
> struct i2c_driver.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Applied now to for-next branch. Thanks.
Takashi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-06-05 7:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-25 20:36 [PATCH] sound: Switch i2c drivers back to use .probe() Uwe Kleine-König
2023-05-25 20:52 ` Luca Ceresoli
2023-06-05 7:24 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).