Re: [PATCH] macintosh: Switch i2c drivers back to use .probe()

[Jean Delvare <jdelvare@suse.de>]

On Tue, 23 May 2023 21:50:53 +0200, Uwe Kleine-König wrote:
> After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new()
> call-back type"), all drivers being converted to .probe_new() and then
> 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter") convert
> back to (the new) .probe() to be able to eventually drop .probe_new() from
> struct i2c_driver.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> Hello,
> 
> this patch was generated using coccinelle, but I aligned the result to
> the per-file indention.
> 
> I chose to convert all drivers below drivers/macintosh in a single
> patch, but if you prefer I can split by driver.
> 
> v6.4-rc1 was taken as a base, as there are no commits in next touching
> drivers/macintosh I don't expect problems when applying this patch. If
> conflicts arise until this is applied, feel free to just drop the files
> with conflicts from this patch. I'll care about the fallout later then.
> 
> Also note there is no coordination necessary with the i2c tree. Dropping
> .probe_new() will happen only when all (or most) drivers are converted,
> which will happen after v6.5-rc1 for sure.
> 
> Best regards
> Uwe
> 
>  drivers/macintosh/ams/ams-i2c.c             | 2 +-
>  drivers/macintosh/therm_adt746x.c           | 2 +-
>  drivers/macintosh/therm_windtunnel.c        | 2 +-
>  drivers/macintosh/windfarm_ad7417_sensor.c  | 2 +-
>  drivers/macintosh/windfarm_fcu_controls.c   | 2 +-
>  drivers/macintosh/windfarm_lm75_sensor.c    | 2 +-
>  drivers/macintosh/windfarm_lm87_sensor.c    | 2 +-
>  drivers/macintosh/windfarm_max6690_sensor.c | 2 +-
>  drivers/macintosh/windfarm_smu_sat.c        | 2 +-
>  9 files changed, 9 insertions(+), 9 deletions(-)
> (...)

Reviewed-by: Jean Delvare <jdelvare@suse.de>

-- 
Jean Delvare
SUSE L3 Support