From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5D16CEB64DA for ; Tue, 13 Jun 2023 22:14:10 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=jauu.net header.i=@jauu.net header.a=rsa-sha256 header.s=MBO0001 header.b=OyeK6ibm; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4QgjWh6GKQz3c8L for ; Wed, 14 Jun 2023 08:14:08 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=jauu.net header.i=@jauu.net header.a=rsa-sha256 header.s=MBO0001 header.b=OyeK6ibm; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=jauu.net (client-ip=2001:67c:2050:0:465::202; helo=mout-p-202.mailbox.org; envelope-from=hagen@jauu.net; receiver=lists.ozlabs.org) X-Greylist: delayed 597 seconds by postgrey-1.37 at boromir; Wed, 14 Jun 2023 06:53:23 AEST Received: from mout-p-202.mailbox.org (mout-p-202.mailbox.org [IPv6:2001:67c:2050:0:465::202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4QggkW4YcRz3003 for ; Wed, 14 Jun 2023 06:53:23 +1000 (AEST) Received: from smtp102.mailbox.org (smtp102.mailbox.org [10.196.197.102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4QggVl2Hbcz9tFc; Tue, 13 Jun 2023 22:43:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jauu.net; s=MBO0001; t=1686688991; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+Ge2zDH4C5WcYe3JrCtOQM7SlUHF5WPe+wiOXOV0zPo=; b=OyeK6ibmkrkMQ8OJEJONhckGjXAA0ePebIVRTwBjgmddRZMWPp581G+ebSJYlgOlZURkpF 8kB0idlVaDqzOAAjcM+Mhf10Gnwbe7eN0tKF9k7SLEQW5uwhNWOES4HnyGNMUod20ahhco m8BNjdtxvqc4Ckq0ZQ6zXz7HDvjrvyVq+h4XAqax0bRBZA6rtwmpzbt3QgfuiA6vln7Ows 6VmXOmKwPZ//fDTaowqutxxkRAijWYFrj0qVPn9Rc42W+OH/LTpmDQVhmgClof/TAqgiHB P6zQFUlKTf7Y6KDSiU9ByeWayZe2jKkNc1XsFyrej4MV2HOUep8/D8NI19gtVg== Date: Tue, 13 Jun 2023 22:43:05 +0200 From: Hagen Paul Pfeifer To: Arnaldo Carvalho de Melo Subject: Re: [PATCH 16/17] perf tests task_analyzer: print command on failure Message-ID: <20230613204305.uiv3g5r3cmzo2ucx@ic1101> X-Key-Id: 98350C22 X-Key-Fingerprint: 490F 557B 6C48 6D7E 5706 2EA2 4A22 8D45 9835 0C22 X-GPG-Key: gpg --recv-keys --keyserver wwwkeys.eu.pgp.net 98350C22 X-Operating-System: Linux ic1101 6.2.0-hgn References: <20230613164145.50488-1-atrajeev@linux.vnet.ibm.com> <20230613164145.50488-17-atrajeev@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailman-Approved-At: Wed, 14 Jun 2023 08:08:01 +1000 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: irogers@google.com, Athira Rajeev , john.g.garry@oracle.com, kjain@linux.ibm.com, ravi.bangoria@amd.com, linux-perf-users@vger.kernel.org, Petar Gligoric , maddy@linux.ibm.com, jolsa@kernel.org, Aditya Gupta , namhyung@kernel.org, disgoel@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" * Arnaldo Carvalho de Melo | 2023-06-13 17:07:52 [-0300]: >> From: Aditya Gupta >> >> Instead of printing "perf command failed" everytime, print the exact >> command that run earlier > >Looks like a nice improvement, added the test authors to the CC list on >this message, Thank you Aditya and really great catch - thank you very much! Shell scripting can be nasty. This is another example where you can see that with one stupid typo the whole system can be undermined and you don't get a single hint. Acked-by: Hagen Paul Pfeifer