linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Dufour <ldufour@linux.ibm.com>
To: linux-kernel@vger.kernel.org
Cc: linux-arch@vger.kernel.org, dave.hansen@linux.intel.com,
	x86@kernel.org, mingo@redhat.com, bp@alien8.de,
	npiggin@gmail.com, tglx@linutronix.de,
	linuxppc-dev@lists.ozlabs.org
Subject: [PATCH 05/10] cpu/SMT: Create topology_smt_threads_supported()
Date: Thu, 15 Jun 2023 17:46:30 +0200	[thread overview]
Message-ID: <20230615154635.13660-6-ldufour@linux.ibm.com> (raw)
In-Reply-To: <20230615154635.13660-1-ldufour@linux.ibm.com>

From: Michael Ellerman <mpe@ellerman.id.au>

A subsequent patch will enable partial SMT states, ie. when not all SMT
threads are brought online.

To support that, add an arch helper to check how many SMT threads are
supported.

To retain existing behaviour, the x86 implementation only allows a
single thread or all threads to be online.

Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
---
 arch/x86/include/asm/topology.h |  2 ++
 arch/x86/kernel/smpboot.c       | 12 ++++++++++++
 2 files changed, 14 insertions(+)

diff --git a/arch/x86/include/asm/topology.h b/arch/x86/include/asm/topology.h
index 87358a8fe843..232df5ffab34 100644
--- a/arch/x86/include/asm/topology.h
+++ b/arch/x86/include/asm/topology.h
@@ -143,6 +143,7 @@ int topology_update_die_map(unsigned int dieid, unsigned int cpu);
 int topology_phys_to_logical_pkg(unsigned int pkg);
 int topology_phys_to_logical_die(unsigned int die, unsigned int cpu);
 bool topology_is_primary_thread(unsigned int cpu);
+bool topology_smt_threads_supported(unsigned int threads);
 #else
 #define topology_max_packages()			(1)
 static inline int
@@ -155,6 +156,7 @@ static inline int topology_phys_to_logical_die(unsigned int die,
 static inline int topology_max_die_per_package(void) { return 1; }
 static inline int topology_max_smt_threads(void) { return 1; }
 static inline bool topology_is_primary_thread(unsigned int cpu) { return true; }
+static inline bool topology_smt_threads_supported(unsigned int threads) { return false; }
 #endif
 
 static inline void arch_fix_phys_package_id(int num, u32 slot)
diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
index 3052c171668d..d163ef55577b 100644
--- a/arch/x86/kernel/smpboot.c
+++ b/arch/x86/kernel/smpboot.c
@@ -278,6 +278,18 @@ bool topology_is_primary_thread(unsigned int cpu)
 	return apic_id_is_primary_thread(per_cpu(x86_cpu_to_apicid, cpu));
 }
 
+/**
+ * topology_smt_threads_supported - Check if the given number of SMT threads
+ *				    is supported.
+ *
+ * @threads:	The number of SMT threads.
+ */
+bool topology_smt_threads_supported(unsigned int threads)
+{
+	// Only support a single thread or all threads.
+	return threads == 1 || threads == smp_num_siblings;
+}
+
 /**
  * topology_phys_to_logical_pkg - Map a physical package id to a logical
  *
-- 
2.41.0


  parent reply	other threads:[~2023-06-15 15:48 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-15 15:46 [PATCH 00/10] Introduce SMT level and add PowerPC support Laurent Dufour
2023-06-15 15:46 ` [PATCH 01/10] cpu/SMT: Move SMT prototypes into cpu_smt.h Laurent Dufour
2023-06-22  8:51   ` Thomas Gleixner
2023-06-15 15:46 ` [PATCH 02/10] cpu/SMT: Move smt/control simple exit cases earlier Laurent Dufour
2023-06-15 15:46 ` [PATCH 03/10] cpu/SMT: Store the current/max number of threads Laurent Dufour
2023-06-15 15:46 ` [PATCH 04/10] cpu/SMT: Remove topology_smt_supported() Laurent Dufour
2023-06-15 15:46 ` Laurent Dufour [this message]
2023-06-15 15:46 ` [PATCH 06/10] cpu/SMT: Create topology_smt_thread_allowed() Laurent Dufour
2023-06-15 15:46 ` [PATCH 07/10] cpu/SMT: Allow enabling partial SMT states via sysfs Laurent Dufour
2023-06-22  9:12   ` Thomas Gleixner
2023-06-22 12:14     ` Michael Ellerman
2023-06-15 15:46 ` [PATCH 08/10] powerpc/pseries: Initialise CPU hotplug callbacks earlier Laurent Dufour
2023-06-15 15:46 ` [PATCH 09/10] powerpc: Add HOTPLUG_SMT support Laurent Dufour
2023-06-15 15:46 ` [PATCH 10/10] powerpc/pseries: Honour current SMT state when DLPAR onlining CPUs Laurent Dufour

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230615154635.13660-6-ldufour@linux.ibm.com \
    --to=ldufour@linux.ibm.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mingo@redhat.com \
    --cc=npiggin@gmail.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).