From: Mike Rapoport <rppt@kernel.org>
To: linux-kernel@vger.kernel.org
Cc: Mark Rutland <mark.rutland@arm.com>,
x86@kernel.org, Catalin Marinas <catalin.marinas@arm.com>,
Song Liu <song@kernel.org>,
sparclinux@vger.kernel.org, linux-riscv@lists.infradead.org,
Nadav Amit <nadav.amit@gmail.com>,
linux-s390@vger.kernel.org, Helge Deller <deller@gmx.de>,
Huacai Chen <chenhuacai@kernel.org>,
Russell King <linux@armlinux.org.uk>,
"Naveen N. Rao" <naveen.n.rao@linux.ibm.com>,
linux-trace-kernel@vger.kernel.org, Will Deacon <will@kernel.org>,
Heiko Carstens <hca@linux.ibm.com>,
Steven Rostedt <rostedt@goodmis.org>,
loongarch@lists.linux.dev, Thomas Gleixner <tglx@linutronix.de>,
bpf@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
linux-parisc@vger.kernel.org,
Puranjay Mohan <puranjay12@gmail.com>,
linux-mm@kvack.org, netdev@vger.kernel.org,
Kent Overstreet <kent.overstreet@linux.dev>,
linux-mips@vger.kernel.org, Dinh Nguyen <dinguyen@kernel.org>,
Luis Chamberlain <mcgrof@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
linux-modules@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Rick Edgecombe <rick.p.edgecombe@intel.com>,
linuxppc-dev@lists.ozlabs.org,
"David S. Miller" <davem@davemloft.net>,
Mike Rapoport <rppt@kernel.org>
Subject: [PATCH v2 07/12] arm64, execmem: extend execmem_params for generated code definitions
Date: Fri, 16 Jun 2023 11:50:33 +0300 [thread overview]
Message-ID: <20230616085038.4121892-8-rppt@kernel.org> (raw)
In-Reply-To: <20230616085038.4121892-1-rppt@kernel.org>
From: "Mike Rapoport (IBM)" <rppt@kernel.org>
The memory allocations for kprobes on arm64 can be placed anywhere in
vmalloc address space and currently this is implemented with an override
of alloc_insn_page() in arm64.
Extend execmem_params with a range for generated code allocations and
make kprobes on arm64 use this extension rather than override
alloc_insn_page().
Signed-off-by: Mike Rapoport (IBM) <rppt@kernel.org>
---
arch/arm64/kernel/module.c | 9 +++++++++
arch/arm64/kernel/probes/kprobes.c | 7 -------
include/linux/execmem.h | 11 +++++++++++
mm/execmem.c | 14 +++++++++++++-
4 files changed, 33 insertions(+), 8 deletions(-)
diff --git a/arch/arm64/kernel/module.c b/arch/arm64/kernel/module.c
index c3d999f3a3dd..52b09626bc0f 100644
--- a/arch/arm64/kernel/module.c
+++ b/arch/arm64/kernel/module.c
@@ -30,6 +30,13 @@ static struct execmem_params execmem_params = {
.alignment = MODULE_ALIGN,
},
},
+ .jit = {
+ .text = {
+ .start = VMALLOC_START,
+ .end = VMALLOC_END,
+ .alignment = 1,
+ },
+ },
};
struct execmem_params __init *execmem_arch_params(void)
@@ -40,6 +47,8 @@ struct execmem_params __init *execmem_arch_params(void)
execmem_params.modules.text.start = module_alloc_base;
execmem_params.modules.text.end = module_alloc_end;
+ execmem_params.jit.text.pgprot = PAGE_KERNEL_ROX;
+
/*
* KASAN without KASAN_VMALLOC can only deal with module
* allocations being served from the reserved module region,
diff --git a/arch/arm64/kernel/probes/kprobes.c b/arch/arm64/kernel/probes/kprobes.c
index 70b91a8c6bb3..6fccedd02b2a 100644
--- a/arch/arm64/kernel/probes/kprobes.c
+++ b/arch/arm64/kernel/probes/kprobes.c
@@ -129,13 +129,6 @@ int __kprobes arch_prepare_kprobe(struct kprobe *p)
return 0;
}
-void *alloc_insn_page(void)
-{
- return __vmalloc_node_range(PAGE_SIZE, 1, VMALLOC_START, VMALLOC_END,
- GFP_KERNEL, PAGE_KERNEL_ROX, VM_FLUSH_RESET_PERMS,
- NUMA_NO_NODE, __builtin_return_address(0));
-}
-
/* arm kprobe: install breakpoint in text */
void __kprobes arch_arm_kprobe(struct kprobe *p)
{
diff --git a/include/linux/execmem.h b/include/linux/execmem.h
index 2e1221310d13..dc7c9a446111 100644
--- a/include/linux/execmem.h
+++ b/include/linux/execmem.h
@@ -52,12 +52,23 @@ struct execmem_modules_range {
struct execmem_range data;
};
+/**
+ * struct execmem_jit_range - architecure parameters for address space
+ * suitable for JIT code allocations
+ * @text: address range for text allocations
+ */
+struct execmem_jit_range {
+ struct execmem_range text;
+};
+
/**
* struct execmem_params - architecure parameters for code allocations
* @modules: parameters for modules address space
+ * @jit: parameters for jit memory address space
*/
struct execmem_params {
struct execmem_modules_range modules;
+ struct execmem_jit_range jit;
};
/**
diff --git a/mm/execmem.c b/mm/execmem.c
index f7bf496ad4c3..9730ecef9a30 100644
--- a/mm/execmem.c
+++ b/mm/execmem.c
@@ -89,7 +89,12 @@ void execmem_free(void *ptr)
void *jit_text_alloc(size_t size)
{
- return execmem_text_alloc(size);
+ unsigned long start = execmem_params.jit.text.start;
+ unsigned long end = execmem_params.jit.text.end;
+ pgprot_t pgprot = execmem_params.jit.text.pgprot;
+ unsigned int align = execmem_params.jit.text.alignment;
+
+ return execmem_alloc(size, start, end, align, pgprot, 0, 0, false);
}
void jit_free(void *ptr)
@@ -135,6 +140,13 @@ static void execmem_init_missing(struct execmem_params *p)
execmem_params.modules.data.fallback_start = m->text.fallback_start;
execmem_params.modules.data.fallback_end = m->text.fallback_end;
}
+
+ if (!execmem_params.jit.text.start) {
+ execmem_params.jit.text.start = m->text.start;
+ execmem_params.jit.text.end = m->text.end;
+ execmem_params.jit.text.alignment = m->text.alignment;
+ execmem_params.jit.text.pgprot = m->text.pgprot;
+ }
}
void __init execmem_init(void)
--
2.35.1
next prev parent reply other threads:[~2023-06-16 8:58 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-16 8:50 [PATCH v2 00/12] mm: jit/text allocator Mike Rapoport
2023-06-16 8:50 ` [PATCH v2 01/12] nios2: define virtual address space for modules Mike Rapoport
2023-06-16 16:00 ` Edgecombe, Rick P
2023-06-17 5:52 ` Mike Rapoport
2023-06-16 18:14 ` Song Liu
2023-06-16 8:50 ` [PATCH v2 02/12] mm: introduce execmem_text_alloc() and jit_text_alloc() Mike Rapoport
2023-06-16 16:48 ` Kent Overstreet
2023-06-16 18:18 ` Song Liu
2023-06-17 5:57 ` Mike Rapoport
2023-06-17 20:38 ` Andy Lutomirski
2023-06-18 8:00 ` Mike Rapoport
2023-06-19 17:09 ` Andy Lutomirski
2023-06-19 20:18 ` Nadav Amit
2023-06-20 17:24 ` Andy Lutomirski
2023-06-25 16:14 ` Mike Rapoport
2023-06-25 16:59 ` Andy Lutomirski
2023-06-25 17:42 ` Mike Rapoport
2023-06-25 18:07 ` Kent Overstreet
2023-06-26 6:13 ` Song Liu
2023-06-26 9:54 ` Puranjay Mohan
2023-06-26 12:23 ` Mark Rutland
2023-06-26 12:31 ` Mark Rutland
2023-06-26 17:48 ` Song Liu
2023-07-17 17:23 ` Andy Lutomirski
2023-06-26 13:01 ` Mark Rutland
2023-06-19 11:34 ` Kent Overstreet
2023-06-16 8:50 ` [PATCH v2 03/12] mm/execmem, arch: convert simple overrides of module_alloc to execmem Mike Rapoport
2023-06-16 18:36 ` Song Liu
2023-06-16 8:50 ` [PATCH v2 04/12] mm/execmem, arch: convert remaining " Mike Rapoport
2023-06-16 16:16 ` Edgecombe, Rick P
2023-06-17 6:10 ` Mike Rapoport
2023-06-16 18:53 ` Song Liu
2023-06-17 6:14 ` Mike Rapoport
2023-06-16 8:50 ` [PATCH v2 05/12] modules, execmem: drop module_alloc Mike Rapoport
2023-06-16 18:56 ` Song Liu
2023-06-16 8:50 ` [PATCH v2 06/12] mm/execmem: introduce execmem_data_alloc() Mike Rapoport
2023-06-16 16:55 ` Edgecombe, Rick P
2023-06-17 6:44 ` Mike Rapoport
2023-06-16 20:01 ` Song Liu
2023-06-17 6:51 ` Mike Rapoport
2023-06-18 22:32 ` Thomas Gleixner
2023-06-18 23:14 ` Kent Overstreet
2023-06-19 0:43 ` Thomas Gleixner
2023-06-19 2:12 ` Kent Overstreet
2023-06-20 14:51 ` Steven Rostedt
2023-06-20 15:32 ` Alexei Starovoitov
2023-06-19 15:23 ` Mike Rapoport
2023-06-16 8:50 ` Mike Rapoport [this message]
2023-06-16 20:05 ` [PATCH v2 07/12] arm64, execmem: extend execmem_params for generated code definitions Song Liu
2023-06-17 6:57 ` Mike Rapoport
2023-06-17 15:36 ` Kent Overstreet
2023-06-17 16:38 ` Song Liu
2023-06-17 20:37 ` Kent Overstreet
2023-06-16 8:50 ` [PATCH v2 08/12] riscv: extend execmem_params for kprobes allocations Mike Rapoport
2023-06-16 20:09 ` Song Liu
2023-06-16 8:50 ` [PATCH v2 09/12] powerpc: " Mike Rapoport
2023-06-16 20:09 ` Song Liu
2023-06-16 8:50 ` [PATCH v2 10/12] arch: make execmem setup available regardless of CONFIG_MODULES Mike Rapoport
2023-06-16 20:17 ` Song Liu
2023-06-16 8:50 ` [PATCH v2 11/12] x86/ftrace: enable dynamic ftrace without CONFIG_MODULES Mike Rapoport
2023-06-16 20:18 ` Song Liu
2023-06-16 8:50 ` [PATCH v2 12/12] kprobes: remove dependcy on CONFIG_MODULES Mike Rapoport
2023-06-16 11:44 ` Björn Töpel
2023-06-17 6:52 ` Mike Rapoport
2023-06-16 17:02 ` [PATCH v2 00/12] mm: jit/text allocator Edgecombe, Rick P
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230616085038.4121892-8-rppt@kernel.org \
--to=rppt@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=bpf@vger.kernel.org \
--cc=catalin.marinas@arm.com \
--cc=chenhuacai@kernel.org \
--cc=davem@davemloft.net \
--cc=deller@gmx.de \
--cc=dinguyen@kernel.org \
--cc=hca@linux.ibm.com \
--cc=kent.overstreet@linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-modules@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=loongarch@lists.linux.dev \
--cc=mark.rutland@arm.com \
--cc=mcgrof@kernel.org \
--cc=nadav.amit@gmail.com \
--cc=naveen.n.rao@linux.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=palmer@dabbelt.com \
--cc=puranjay12@gmail.com \
--cc=rick.p.edgecombe@intel.com \
--cc=rostedt@goodmis.org \
--cc=song@kernel.org \
--cc=sparclinux@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tsbogend@alpha.franken.de \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).