linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Gray <bgray@linux.ibm.com>
To: linux-rtc@vger.kernel.org
Cc: linuxppc-dev@lists.ozlabs.org, Benjamin Gray <bgray@linux.ibm.com>
Subject: [PATCH] rtc: Kconfig: select REGMAP for RTC_DRV_DS1307
Date: Wed,  5 Jul 2023 10:30:24 +1000	[thread overview]
Message-ID: <20230705003024.1486757-1-bgray@linux.ibm.com> (raw)

The drivers/rtc/rtc-ds1307.c driver has a direct dependency on
struct regmap_config, which is guarded behind CONFIG_REGMAP.

Commit 70a640c0efa7 ("regmap: REGMAP_KUNIT should not select REGMAP")
exposed this by disabling the default pick unless KUNIT_ALL_TESTS is
set, causing the ppc64be allnoconfig build to fail.

Signed-off-by: Benjamin Gray <bgray@linux.ibm.com>
---
 drivers/rtc/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
index ffca9a8bb878..7455ebd189fe 100644
--- a/drivers/rtc/Kconfig
+++ b/drivers/rtc/Kconfig
@@ -246,6 +246,7 @@ config RTC_DRV_AS3722
 
 config RTC_DRV_DS1307
 	tristate "Dallas/Maxim DS1307/37/38/39/40/41, ST M41T00, EPSON RX-8025, ISL12057"
+	select REGMAP
 	select REGMAP_I2C
 	select WATCHDOG_CORE if WATCHDOG
 	help
-- 
2.41.0


             reply	other threads:[~2023-07-05  0:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-05  0:30 Benjamin Gray [this message]
2023-07-06  5:13 ` [PATCH] rtc: Kconfig: select REGMAP for RTC_DRV_DS1307 Christophe Leroy
2023-07-06  6:14   ` Benjamin Gray
2023-07-06  6:35     ` Christophe Leroy
2023-07-06  7:50     ` Geert Uytterhoeven
2023-07-06 11:43       ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230705003024.1486757-1-bgray@linux.ibm.com \
    --to=bgray@linux.ibm.com \
    --cc=linux-rtc@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).