From: Thomas Zimmermann <tzimmermann@suse.de>
To: deller@gmx.de, javierm@redhat.com
Cc: linux-fbdev@vger.kernel.org, Andy Walls <awalls@md.metrocast.net>,
kvm@vger.kernel.org, linux-hyperv@vger.kernel.org,
linux-sh@vger.kernel.org, Sam Ravnborg <sam@ravnborg.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
amd-gfx@lists.freedesktop.org, linux-geode@lists.infradead.org,
Hans Verkuil <hverkuil@xs4all.nl>,
dri-devel@lists.freedesktop.org,
Thomas Zimmermann <tzimmermann@suse.de>,
linux-input@vger.kernel.org, linux-nvidia@lists.surfsouth.com,
linux-omap@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org
Subject: [PATCH v2 11/18] media: Remove flag FBINFO_FLAG_DEFAULT from fbdev drivers
Date: Thu, 13 Jul 2023 14:58:31 +0200 [thread overview]
Message-ID: <20230713130338.31086-12-tzimmermann@suse.de> (raw)
In-Reply-To: <20230713130338.31086-1-tzimmermann@suse.de>
The flag FBINFO_FLAG_DEFAULT is 0 and has no effect, as struct
fbinfo.flags has been allocated to zero by kzalloc(). So do not
set it.
Flags should signal differences from the default values. After cleaning
up all occurrences of FBINFO_DEFAULT, the token will be removed.
v2:
* fix commit message (Miguel)
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Andy Walls <awalls@md.metrocast.net>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Hans Verkuil <hverkuil@xs4all.nl>
---
drivers/media/pci/ivtv/ivtvfb.c | 1 -
drivers/media/test-drivers/vivid/vivid-osd.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/media/pci/ivtv/ivtvfb.c b/drivers/media/pci/ivtv/ivtvfb.c
index 0aeb9daaee4c..23c8c094e791 100644
--- a/drivers/media/pci/ivtv/ivtvfb.c
+++ b/drivers/media/pci/ivtv/ivtvfb.c
@@ -1048,7 +1048,6 @@ static int ivtvfb_init_vidmode(struct ivtv *itv)
/* Generate valid fb_info */
oi->ivtvfb_info.node = -1;
- oi->ivtvfb_info.flags = FBINFO_FLAG_DEFAULT;
oi->ivtvfb_info.par = itv;
oi->ivtvfb_info.var = oi->ivtvfb_defined;
oi->ivtvfb_info.fix = oi->ivtvfb_fix;
diff --git a/drivers/media/test-drivers/vivid/vivid-osd.c b/drivers/media/test-drivers/vivid/vivid-osd.c
index ec25edc679b3..051f1805a16d 100644
--- a/drivers/media/test-drivers/vivid/vivid-osd.c
+++ b/drivers/media/test-drivers/vivid/vivid-osd.c
@@ -310,7 +310,6 @@ static int vivid_fb_init_vidmode(struct vivid_dev *dev)
/* Generate valid fb_info */
dev->fb_info.node = -1;
- dev->fb_info.flags = FBINFO_FLAG_DEFAULT;
dev->fb_info.par = dev;
dev->fb_info.var = dev->fb_defined;
dev->fb_info.fix = dev->fb_fix;
--
2.41.0
next prev parent reply other threads:[~2023-07-13 13:13 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-13 12:58 [PATCH v2 00/18] fbdev: Remove FBINFO_DEFAULT and FBINFO_FLAG_DEFAULT flags Thomas Zimmermann
2023-07-13 12:58 ` [PATCH v2 01/18] drm: Remove flag FBINFO_DEFAULT from fbdev emulation Thomas Zimmermann
2023-07-13 12:58 ` [PATCH v2 02/18] fbdev: Remove flag FBINFO_DEFAULT from fbdev drivers Thomas Zimmermann
2023-07-13 12:58 ` [PATCH v2 03/18] " Thomas Zimmermann
2023-07-13 12:58 ` [PATCH v2 04/18] " Thomas Zimmermann
2023-07-13 12:58 ` [PATCH v2 05/18] " Thomas Zimmermann
2023-07-13 12:58 ` [PATCH v2 06/18] fbdev/fsl-diu-fb: Remove flag FBINFO_DEFAULT Thomas Zimmermann
2023-07-13 12:58 ` [PATCH v2 07/18] vfio-mdev: Remove flag FBINFO_DEFAULT from fbdev sample driver Thomas Zimmermann
2023-07-13 12:58 ` [PATCH v2 08/18] sh: Assign FB_MODE_IS_UNKNOWN to struct fb_videomode.flag Thomas Zimmermann
2023-07-13 13:53 ` John Paul Adrian Glaubitz
2023-07-13 13:56 ` John Paul Adrian Glaubitz
2023-07-13 12:58 ` [PATCH v2 09/18] auxdisplay: Remove flag FBINFO_FLAG_DEFAULT from fbdev drivers Thomas Zimmermann
2023-07-13 12:58 ` [PATCH v2 10/18] hid/picolcd: Remove flag FBINFO_FLAG_DEFAULT from fbdev driver Thomas Zimmermann
2023-07-13 12:58 ` Thomas Zimmermann [this message]
2023-07-13 12:58 ` [PATCH v2 12/18] staging: Remove flag FBINFO_FLAG_DEFAULT from fbdev drivers Thomas Zimmermann
2023-07-13 12:58 ` [PATCH v2 13/18] fbdev: " Thomas Zimmermann
2023-07-13 12:58 ` [PATCH v2 14/18] " Thomas Zimmermann
2023-07-13 12:58 ` [PATCH v2 15/18] fbdev/atafb: Remove flag FBINFO_FLAG_DEFAULT Thomas Zimmermann
2023-07-13 12:58 ` [PATCH v2 16/18] fbdev/pxafb: " Thomas Zimmermann
2023-07-13 12:58 ` [PATCH v2 17/18] fbdev: Remove FBINFO_DEFAULT and FBINFO_FLAG_DEFAULT Thomas Zimmermann
2023-07-13 12:58 ` [PATCH v2 18/18] fbdev: Document that framebuffer_alloc() returns zero'ed data Thomas Zimmermann
2023-07-13 13:21 ` Miguel Ojeda
2023-07-13 16:02 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230713130338.31086-12-tzimmermann@suse.de \
--to=tzimmermann@suse.de \
--cc=amd-gfx@lists.freedesktop.org \
--cc=awalls@md.metrocast.net \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=hverkuil@xs4all.nl \
--cc=javierm@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-geode@lists.infradead.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-nvidia@lists.surfsouth.com \
--cc=linux-omap@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mchehab@kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).