From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9FCA1C0015E for ; Thu, 27 Jul 2023 01:08:39 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=HnMhty9U; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4RBCMB1KLgz3dCS for ; Thu, 27 Jul 2023 11:08:38 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=HnMhty9U; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=139.178.84.217; helo=dfw.source.kernel.org; envelope-from=andi.shyti@kernel.org; receiver=lists.ozlabs.org) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4RBBk53zySz2ytG; Thu, 27 Jul 2023 10:39:57 +1000 (AEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0CE4261CEB; Thu, 27 Jul 2023 00:39:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DAFE0C433C7; Thu, 27 Jul 2023 00:39:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690418394; bh=hjLR4NUeMP4IVUC9ETRe2AQg79Rs8N5wqjGvIEE1P00=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HnMhty9UoZVYTW2+QGN9V5v0VmCGklzjGs/NcHhcqmP7o5s77N+NrhxYytPNdPYSz cPvttFygDUPA6wFU6n0bunWdzCfsZvDk7ZNUOMkqL4S776tkebPFD7MIggAXnpqnVS ID2FI1GaiZFtfsX5LoixIIXJP0jJpftfK7jHAQ/hHona7EIP8lGMLtH2ggAAMd5L/e vlrk6qsAP/CjTn6GpLjsG7fkWifsXMd/j4O7ahabsR9ZQJrqhGnyNi+TsWLjwVq6E2 eDci/Cd+dvSGavZJBkJmF3gLVVOIs3vxRy7nD3xFF0RN+iCspjMdqfe+NKdpZDhMVf THCzdK9MIDqnw== Date: Thu, 27 Jul 2023 02:39:51 +0200 From: Andi Shyti To: Rob Herring Subject: Re: [PATCH] I2C: Explicitly include correct DT includes Message-ID: <20230727003951.q7vyps26t4kjfwmm@intel.intel> References: <20230714174619.4057577-1-robh@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230714174619.4057577-1-robh@kernel.org> X-Mailman-Approved-At: Thu, 27 Jul 2023 11:04:55 +1000 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , Tomer Maimon , Jean-Marie Verdun , Tali Perry , Paul Cercueil , Wolfram Sang , Chris Brandt , Thierry Reding , linux-i2c@vger.kernel.org, Alim Akhtar , Dmitry Osipenko , Stefan Roese , Fabio Estevam , linux-kernel@vger.kernel.org, Jerome Brunet , linux-samsung-soc@vger.kernel.org, Benjamin Fair , Florian Fainelli , Peter Rosin , Kevin Hilman , Bartosz Golaszewski , Khalil Blaiech , Jonathan Hunter , Nancy Yuen , Broadcom internal kernel review list , NXP Linux Tea m , Orson Zhai , Codrin Ciubotariu , linux-mips@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-tegra@vger.kernel.org, Asmaa Mnebhi , Michael Hennerich , Manivannan Sadhasivam , Martin Blumenstingl , Ray Jui , Sascha Hauer , openbmc@lists.ozlabs.org, linuxppc-dev@lists.ozlabs.org, Vladimir Zapolskiy , Chris Packham , linux-mediatek@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, Nick Hawkins , Chunyan Zhang , Matthias Brugger , linux-amlogic@lists.infradead.org, Qii Wang , AngeloGioacchino Del Regno , Dong Aisheng , Nei l Armstrong , Baolin Wang , Scott Branden , Avi Fishman , Patrick Venture , Nicolas Ferre , Oleksij Rempel , linux-renesas-soc@vger.kernel.org, Krzysztof Kozlowski , Laxman Dewangan , linux-actions@lists.infradead.org, Pengutronix Kernel Team , Andreas =?utf-8?Q?F=C3=A4rber?= , Shawn Guo , Claudiu Beznea Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hi Rob, On Fri, Jul 14, 2023 at 11:46:16AM -0600, Rob Herring wrote: > The DT of_device.h and of_platform.h date back to the separate > of_platform_bus_type before it as merged into the regular platform bus. > As part of that merge prepping Arm DT support 13 years ago, they > "temporarily" include each other. They also include platform_device.h > and of.h. As a result, there's a pretty much random mix of those include > files used throughout the tree. In order to detangle these headers and > replace the implicit includes with struct declarations, users need to > explicitly include the correct includes. > > Signed-off-by: Rob Herring I went through all of the changes and they look fine to me. Reviewed-by: Andi Shyti Thanks, Andi