* [PATCH 03/10] tty: hvsi: remove an extra variable from hvsi_write()
[not found] <20230731080244.2698-1-jirislaby@kernel.org>
@ 2023-07-31 8:02 ` Jiri Slaby (SUSE)
0 siblings, 0 replies; only message in thread
From: Jiri Slaby (SUSE) @ 2023-07-31 8:02 UTC (permalink / raw)
To: gregkh; +Cc: linuxppc-dev, Jiri Slaby (SUSE), linux-kernel, linux-serial
'source' is the same as 'buf'. Rename the parameter ('buf') to
'source' and drop the local variable.
Likely, the two were introduced to have a different type. But 'char' and
'unsigned char' are the same in the kernel for a long time.
Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
Cc: linuxppc-dev@lists.ozlabs.org
---
drivers/tty/hvc/hvsi.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/tty/hvc/hvsi.c b/drivers/tty/hvc/hvsi.c
index a200d01eceed..c1b8a4fd8b1e 100644
--- a/drivers/tty/hvc/hvsi.c
+++ b/drivers/tty/hvc/hvsi.c
@@ -905,10 +905,9 @@ static unsigned int hvsi_chars_in_buffer(struct tty_struct *tty)
}
static int hvsi_write(struct tty_struct *tty,
- const unsigned char *buf, int count)
+ const unsigned char *source, int count)
{
struct hvsi_struct *hp = tty->driver_data;
- const char *source = buf;
unsigned long flags;
int total = 0;
int origcount = count;
--
2.41.0
^ permalink raw reply related [flat|nested] only message in thread