[PATCH -next 0/2] soc: Do not check for 0 return after calling platform_get_irq()

[PATCH -next 0/2] soc: Do not check for 0 return after calling platform_get_irq()

[Ruan Jinjie]

Since commit ce753ad1549c ("platform: finally disallow IRQ0 in
platform_get_irq() and its ilk"), there is no possible for
platform_get_irq() to return 0.

And the return value of platform_get_irq() is
more sensible to show the error reason.

Ruan Jinjie (2):
  soc: fsl: qe: Do not check for 0 return after calling
    platform_get_irq()
  soc: xilinx: Do not check for 0 return after calling
    platform_get_irq()

 drivers/soc/fsl/qe/qe_ic.c        | 4 ++--
 drivers/soc/xilinx/zynqmp_power.c | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

-- 
2.34.1

[PATCH -next 1/2] soc: fsl: qe: Do not check for 0 return after calling platform_get_irq()

[Ruan Jinjie]

There is no possible for platform_get_irq() to
return 0. Use the return value from platform_get_irq().

Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
---
 drivers/soc/fsl/qe/qe_ic.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/soc/fsl/qe/qe_ic.c b/drivers/soc/fsl/qe/qe_ic.c
index bbae3d39c7be..8ab6e51e4f28 100644
--- a/drivers/soc/fsl/qe/qe_ic.c
+++ b/drivers/soc/fsl/qe/qe_ic.c
@@ -435,8 +435,8 @@ static int qe_ic_init(struct platform_device *pdev)
 	qe_ic->virq_high = platform_get_irq(pdev, 0);
 	qe_ic->virq_low = platform_get_irq(pdev, 1);
 
-	if (qe_ic->virq_low <= 0)
-		return -ENODEV;
+	if (qe_ic->virq_low < 0)
+		return qe_ic->virq_low;
 
 	if (qe_ic->virq_high > 0 && qe_ic->virq_high != qe_ic->virq_low) {
 		low_handler = qe_ic_cascade_low;
-- 
2.34.1

[PATCH -next 2/2] soc: xilinx: Do not check for 0 return after calling platform_get_irq()

[Ruan Jinjie]

There is no possible for platform_get_irq() to
return 0. Use the return value from platform_get_irq().

Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
---
 drivers/soc/xilinx/zynqmp_power.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/soc/xilinx/zynqmp_power.c b/drivers/soc/xilinx/zynqmp_power.c
index 641dcc958911..eddfc8141a42 100644
--- a/drivers/soc/xilinx/zynqmp_power.c
+++ b/drivers/soc/xilinx/zynqmp_power.c
@@ -242,8 +242,8 @@ static int zynqmp_pm_probe(struct platform_device *pdev)
 		}
 	} else if (of_property_present(pdev->dev.of_node, "interrupts")) {
 		irq = platform_get_irq(pdev, 0);
-		if (irq <= 0)
-			return -ENXIO;
+		if (irq < 0)
+			return irq;
 
 		ret = devm_request_threaded_irq(&pdev->dev, irq, NULL,
 						zynqmp_pm_isr,
-- 
2.34.1

Re: [PATCH -next 2/2] soc: xilinx: Do not check for 0 return after calling platform_get_irq()

[Michal Simek]

On 8/3/23 12:48, Ruan Jinjie wrote:
> There is no possible for platform_get_irq() to
> return 0. Use the return value from platform_get_irq().
> 
> Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
> ---
>   drivers/soc/xilinx/zynqmp_power.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/soc/xilinx/zynqmp_power.c b/drivers/soc/xilinx/zynqmp_power.c
> index 641dcc958911..eddfc8141a42 100644
> --- a/drivers/soc/xilinx/zynqmp_power.c
> +++ b/drivers/soc/xilinx/zynqmp_power.c
> @@ -242,8 +242,8 @@ static int zynqmp_pm_probe(struct platform_device *pdev)
>   		}
>   	} else if (of_property_present(pdev->dev.of_node, "interrupts")) {
>   		irq = platform_get_irq(pdev, 0);
> -		if (irq <= 0)
> -			return -ENXIO;
> +		if (irq < 0)
> +			return irq;
>   
>   		ret = devm_request_threaded_irq(&pdev->dev, irq, NULL,
>   						zynqmp_pm_isr,

Applied this 2/2 patch.

Thanks,
Michal