* [PATCH] Revert "powerpc/xmon: Relax frame size for clang"
@ 2023-08-17 18:11 ndesaulniers
2023-08-17 18:43 ` Nathan Chancellor
2023-08-23 11:55 ` Michael Ellerman
0 siblings, 2 replies; 3+ messages in thread
From: ndesaulniers @ 2023-08-17 18:11 UTC (permalink / raw)
To: Michael Ellerman, Nicholas Piggin, Christophe Leroy,
Nathan Chancellor, Tom Rix
Cc: Nick Desaulniers, llvm, linuxppc-dev, Joel Stanley, linux-kernel
This reverts commit 9c87156cce5a63735d1218f0096a65c50a7a32aa.
I have not been able to reproduce the reported -Wframe-larger-than=
warning (or disassembly) with clang-11 or clang-18.
I don't know precisely when this was fixed in llvm, but it may be time
to revert this.
Closes: https://github.com/ClangBuiltLinux/linux/issues/252
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
---
arch/powerpc/xmon/Makefile | 6 ------
1 file changed, 6 deletions(-)
diff --git a/arch/powerpc/xmon/Makefile b/arch/powerpc/xmon/Makefile
index d334de392e6c..7705aa74a24d 100644
--- a/arch/powerpc/xmon/Makefile
+++ b/arch/powerpc/xmon/Makefile
@@ -10,12 +10,6 @@ KCSAN_SANITIZE := n
# Disable ftrace for the entire directory
ccflags-remove-$(CONFIG_FUNCTION_TRACER) += $(CC_FLAGS_FTRACE)
-ifdef CONFIG_CC_IS_CLANG
-# clang stores addresses on the stack causing the frame size to blow
-# out. See https://github.com/ClangBuiltLinux/linux/issues/252
-KBUILD_CFLAGS += -Wframe-larger-than=4096
-endif
-
ccflags-$(CONFIG_PPC64) := $(NO_MINIMAL_TOC)
obj-y += xmon.o nonstdio.o spr_access.o xmon_bpts.o
---
base-commit: 16931859a6500d360b90aeacab3b505a3560a3ed
change-id: 20230817-ppc_xmon-d288d803610e
Best regards,
--
Nick Desaulniers <ndesaulniers@google.com>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Revert "powerpc/xmon: Relax frame size for clang"
2023-08-17 18:11 [PATCH] Revert "powerpc/xmon: Relax frame size for clang" ndesaulniers
@ 2023-08-17 18:43 ` Nathan Chancellor
2023-08-23 11:55 ` Michael Ellerman
1 sibling, 0 replies; 3+ messages in thread
From: Nathan Chancellor @ 2023-08-17 18:43 UTC (permalink / raw)
To: ndesaulniers
Cc: llvm, Nicholas Piggin, linux-kernel, Joel Stanley, Tom Rix,
linuxppc-dev
On Thu, Aug 17, 2023 at 11:11:56AM -0700, ndesaulniers@google.com wrote:
> This reverts commit 9c87156cce5a63735d1218f0096a65c50a7a32aa.
>
> I have not been able to reproduce the reported -Wframe-larger-than=
> warning (or disassembly) with clang-11 or clang-18.
>
> I don't know precisely when this was fixed in llvm, but it may be time
> to revert this.
>
> Closes: https://github.com/ClangBuiltLinux/linux/issues/252
> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
> ---
> arch/powerpc/xmon/Makefile | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/arch/powerpc/xmon/Makefile b/arch/powerpc/xmon/Makefile
> index d334de392e6c..7705aa74a24d 100644
> --- a/arch/powerpc/xmon/Makefile
> +++ b/arch/powerpc/xmon/Makefile
> @@ -10,12 +10,6 @@ KCSAN_SANITIZE := n
> # Disable ftrace for the entire directory
> ccflags-remove-$(CONFIG_FUNCTION_TRACER) += $(CC_FLAGS_FTRACE)
>
> -ifdef CONFIG_CC_IS_CLANG
> -# clang stores addresses on the stack causing the frame size to blow
> -# out. See https://github.com/ClangBuiltLinux/linux/issues/252
> -KBUILD_CFLAGS += -Wframe-larger-than=4096
> -endif
> -
> ccflags-$(CONFIG_PPC64) := $(NO_MINIMAL_TOC)
>
> obj-y += xmon.o nonstdio.o spr_access.o xmon_bpts.o
>
> ---
> base-commit: 16931859a6500d360b90aeacab3b505a3560a3ed
> change-id: 20230817-ppc_xmon-d288d803610e
>
> Best regards,
> --
> Nick Desaulniers <ndesaulniers@google.com>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Revert "powerpc/xmon: Relax frame size for clang"
2023-08-17 18:11 [PATCH] Revert "powerpc/xmon: Relax frame size for clang" ndesaulniers
2023-08-17 18:43 ` Nathan Chancellor
@ 2023-08-23 11:55 ` Michael Ellerman
1 sibling, 0 replies; 3+ messages in thread
From: Michael Ellerman @ 2023-08-23 11:55 UTC (permalink / raw)
To: Nicholas Piggin, Christophe Leroy, Nathan Chancellor, Tom Rix,
ndesaulniers
Cc: llvm, linuxppc-dev, Joel Stanley, linux-kernel
On Thu, 17 Aug 2023 11:11:56 -0700, ndesaulniers@google.com wrote:
> This reverts commit 9c87156cce5a63735d1218f0096a65c50a7a32aa.
>
> I have not been able to reproduce the reported -Wframe-larger-than=
> warning (or disassembly) with clang-11 or clang-18.
>
> I don't know precisely when this was fixed in llvm, but it may be time
> to revert this.
>
> [...]
Applied to powerpc/next.
[1/1] Revert "powerpc/xmon: Relax frame size for clang"
https://git.kernel.org/powerpc/c/7f3c5d099b6f8452dc4dcfe4179ea48e6a13d0eb
cheers
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-08-23 12:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-17 18:11 [PATCH] Revert "powerpc/xmon: Relax frame size for clang" ndesaulniers
2023-08-17 18:43 ` Nathan Chancellor
2023-08-23 11:55 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).